From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <goldstein.w.n@gmail.com>
Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com
 [IPv6:2607:f8b0:4864:20::629])
 by sourceware.org (Postfix) with ESMTPS id 1BCEB385840A
 for <libc-alpha@sourceware.org>; Sat, 12 Feb 2022 21:44:45 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1BCEB385840A
Received: by mail-pl1-x629.google.com with SMTP id j4so7508688plj.8
 for <libc-alpha@sourceware.org>; Sat, 12 Feb 2022 13:44:45 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=eaZfoyVJMw256iW3/qGIO/ZP8nQx7bqypGETFfeb23U=;
 b=aPH1URYBVKG08zo6v+BMTwIxD5/Kvguqq2BaF+5PTP3tPA9KrbHJmTpeS+zInAwcG6
 F+QDZ+YgB2D1lirGcHO2sghb+s9YUbJ6AJ75WJognDcs9yxx69qCFmM4RWThrn21I/9g
 Bg5z62A4WH9/CBhButfetLHhZIIj82TFrbnxHXYbYJK1uerGKOtnoUhlMmJrHQ8O21Wl
 LJrnsUpy16a736kW28Yq4rqTJom0SCunovFt5w1TOebnvNnS9/0mxbW9YrMAicBSJImM
 qo8bJ9UKqfr0SSSaRm2S1WMVz0o60EPcwJriOy7DTqM+D80QTAFffQgJoG5nQBWYn/g9
 UTMg==
X-Gm-Message-State: AOAM533hveV1qwV09ReCApiysTXaIqrEEdXhpzDWhEgIZoXCRevmg4Xt
 LKgWBJ/ltzESAtpkLJRP4CPtyLxxWHSxvfyURgTmPXnM
X-Google-Smtp-Source: ABdhPJx8EOCCJN7AYUcj8Oh0oqx74caYDFwRT1t/T2819snVWZCOCEKdk0Qcx2hUBFK72cVq3guOYlIJl3iBQA5d+nk=
X-Received: by 2002:a17:903:124e:: with SMTP id
 u14mr7378325plh.57.1644702284210; 
 Sat, 12 Feb 2022 13:44:44 -0800 (PST)
MIME-Version: 1.0
References: <20220212102529.1380928-1-goldstein.w.n@gmail.com>
 <CAMe9rOq8mXuHvTLnpa_awhm5Cr_qDNg9YQNsis0RTQ7cgY3bKA@mail.gmail.com>
In-Reply-To: <CAMe9rOq8mXuHvTLnpa_awhm5Cr_qDNg9YQNsis0RTQ7cgY3bKA@mail.gmail.com>
From: Noah Goldstein <goldstein.w.n@gmail.com>
Date: Sat, 12 Feb 2022 15:44:33 -0600
Message-ID: <CAFUsyf+1n23T61OP=miV0N=x_XfaL7XD0HL5aLoi9=D5fvw1bg@mail.gmail.com>
Subject: Re: [PATCH v1] x86: Set .text section in memset-vec-unaligned-erms
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
 "Carlos O'Donell" <carlos@systemhalted.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Feb 2022 21:44:48 -0000

On Sat, Feb 12, 2022 at 9:47 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Sat, Feb 12, 2022 at 2:25 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > commit 3d9f171bfb5325bd5f427e9fc386453358c6e840
> > Author: H.J. Lu <hjl.tools@gmail.com>
> > Date:   Mon Feb 7 05:55:15 2022 -0800
> >
> >     x86-64: Optimize bzero
> >
> > Remove setting the .text section for the code. This commit
> > adds that back.
> > ---
> >  sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> > index 7c94fcdae1..785fee1d57 100644
> > --- a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> > +++ b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> > @@ -114,6 +114,7 @@
> >  # error SECTION is not defined!
> >  #endif
> >
> > +       .section SECTION(.text), "ax", @progbits
> >  #if IS_IN (libc)
> >  # if defined SHARED
> >  ENTRY_CHK (WMEMSET_CHK_SYMBOL (__wmemset_chk, unaligned))
> > --
> > 2.25.1
> >
>
> LGTM.
>
> Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
>
> Thanks.
>

Thanks pushed.
> --
> H.J.