From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id 9B5B63858D28 for ; Sun, 5 Mar 2023 18:18:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9B5B63858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52a.google.com with SMTP id o12so29790765edb.9 for ; Sun, 05 Mar 2023 10:18:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=K4SDUv1LF1MB6F+GfxO80yOK+KkEGwrWxL2p9EAemso=; b=X7lSsXAXUxW5gccAd69g3T0Xl+DB3yhuhaB7hYMAZ0EH3DkZGtcin56cygWO/Qpwxm S4YtxjDYElrDE1XnaScptZXrqKGjrDl+ga0h0OyH2NZVlKGSqBRtOCa097/XJTybpNH9 TVpnIjgKef49Es4oBuTwhPRkci1qiX/mEYZqJEcatjkNRfZa4tCfAieDqTbbicsp/ykL u+41vwWAm7xXgnLv5c6yxuyrZqs+9JSzlpnk3gtCc0o/5dJhrhkSY2lXys2zvPTRIEym mz1rsknKNLVTqT3CGp/Q+E8D53hDQjEs+qRexF38eKTJ1b8HAE+GWM0qz8Wz8XO9SkQH ol4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K4SDUv1LF1MB6F+GfxO80yOK+KkEGwrWxL2p9EAemso=; b=Fa7rXaHrLD6TTpiMRJhICrv1WHQoM4TfgkjFLxZr+Nj5+iFaFAg7TxpwNzbgtQxwWT SavcH3uo42NoMF0rPjlCyvfcEwSlXXU5UQ7RC2T6IdBrXVO/fuCCJUdzuvyyFU6HOSyq x2wGcILxnIoXYM3HQ9LkaFQbup0rHg15Pn+/0jzzf66SWYJasnFfsvDQ81HIkfFX58V9 XggeIrLoLR98GUItWhDROawDuLB31yL62uhCW9lTmmx/s/bUNn/IZSD07RHdfyjm0J6J A1o340SW27vRnAbBBlTWbPTg88hvhn+cov4kfsGQ9RKsmA4G49DWzwYEyqh2oJ/db8pn cFow== X-Gm-Message-State: AO0yUKUxDXuoqInnK3uTfuX62hOetCJ65ggiWiIxJylxw/aV9ywRosHG iip0dijmFIhcozoBX7Fk8/U3xZ1eUQAv+4n9mLb0VkQ7 X-Google-Smtp-Source: AK7set+RVbEChWaj7l0DDihl9Yp9AfVG40XMX1qoNT3ly7v2zMmwkNVwy70Ap/y1ZAokFCa/H/q1OgAko5HRo0cgm5o= X-Received: by 2002:a50:a69e:0:b0:4c0:5f85:efd2 with SMTP id e30-20020a50a69e000000b004c05f85efd2mr4337769edc.6.1678040297128; Sun, 05 Mar 2023 10:18:17 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Noah Goldstein Date: Sun, 5 Mar 2023 12:18:05 -0600 Message-ID: Subject: Re: [PATCH] build: All microbenchmarks should output in JSON. (bug 27740) To: Girish Joshi Cc: Girish Joshi via Libc-alpha , Siddhesh Poyarekar Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Mar 5, 2023 at 12:15=E2=80=AFAM Girish Joshi via Libc-alpha wrote: > > Ping. > > Girish Joshi > > > On Sun, Feb 19, 2023 at 6:20=E2=80=AFPM Girish Joshi wrote: > > > > Hello, > > According to bug #27740 [1], I found that the following files need to > > be updated. > > > > - benchtests/bench-memccpy.c > > - benchtests/bench-strcasestr.c > > - benchtests/bench-strcpy_chk.c > > - benchtests/bench-strsep.c > > - benchtests/bench-strtok.c > > > > Also, the output json needs to be fixed in two files. > > - bench-math-inlines.c > > - bench-strcoll.c > > > > This patch fixes both of these things. > > The output is tested using > > benchtests/scripts/compare_strings.py. > > > > Please let me know if some correction is needed in this patch. When applying: ``` Applying: build: All microbenchmarks should output in JSON. (bug 27740) .git/rebase-apply/patch:235: trailing whitespace. json_element_string(&json_ctx, impl->name); warning: 1 line adds whitespace errors. ``` Also can you please post the patch as inline text in the email? It allows patchwork to detect it and easier to inline comments during review. Some general feedback: 1) The changes to `benchtests/bench-math-inlines.c`/`benchtests/bench-strco= ll.c` seem unrelated, can you make that a seperate patch. 2) You are missing some test parameters in most of the files (mostly `max_c= har`) also `dlen` in `bench_strcpy_chk.c`. Can you make sure you get all of them = that are relevant to the input. > > > > Thanks, > > Girish Joshi > > girishjoshi.io > > > > [1]: https://sourceware.org/bugzilla/show_bug.cgi?id=3D27740