From: Noah Goldstein <goldstein.w.n@gmail.com>
To: Ricardo Bittencourt <ricbit@ricbit.com>
Cc: Joseph Myers <joseph@codesourcery.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] string: Replace outdated comments in strlen().
Date: Sat, 9 Apr 2022 11:46:24 -0500 [thread overview]
Message-ID: <CAFUsyf+93cNnspFm4YLJkSNpUzBNOOfjepVnOyLkdunvr+FAaw@mail.gmail.com> (raw)
In-Reply-To: <CAMEigpkJp1nvF7WVyH1eD4BAQNeO7U4jiOs0GtkHwd9pM7opFg@mail.gmail.com>
On Sat, Apr 9, 2022 at 10:50 AM Ricardo Bittencourt via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Hi people, by any chance can someone commit this change? I asked for a
> sourceware account to do it myself, but it's taking a while, so it
> would be best if someone applies this patch meanwhile.
Pushed.
>
> --
> Ricardo
>
> On Mon, Mar 21, 2022 at 3:50 PM Ricardo Bittencourt <ricbit@ricbit.com> wrote:
> >
> > I checked the bug and it's the same comment issue (the comments
> > describe an earlier version of the algorithm). After sending this
> > patch I can update the others.
> >
> > The generic string improvements in the bug are better than the current
> > implementation, is there something stopping us from just applying it?
> >
> > --
> > Ricardo
> >
> > On Mon, Mar 21, 2022 at 3:18 PM Joseph Myers <joseph@codesourcery.com> wrote:
> > >
> > > Some incidental comments (this is not a review of the patch and should not
> > > delay it going in):
> > >
> > > * Do I understand correctly that this is a *different* comment issue from
> > > the one described in bug 5806 with comments in various string functions?
> > > (Maybe the issue described in comment#10 in that bug?)
> > >
> > > * I'd still like to see the generic string function improvements discussed
> > > in that bug getting into glibc at some point.
> > >
> > > --
> > > Joseph S. Myers
> > > joseph@codesourcery.com
prev parent reply other threads:[~2022-04-09 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 1:04 Ricardo Bittencourt
2022-03-20 4:41 ` Noah Goldstein
2022-03-21 18:18 ` Joseph Myers
2022-03-21 18:50 ` Ricardo Bittencourt
2022-04-09 15:50 ` Ricardo Bittencourt
2022-04-09 16:46 ` Noah Goldstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFUsyf+93cNnspFm4YLJkSNpUzBNOOfjepVnOyLkdunvr+FAaw@mail.gmail.com \
--to=goldstein.w.n@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=ricbit@ricbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).