From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id 33AF2392AC39 for ; Wed, 5 Apr 2023 21:05:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 33AF2392AC39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5027d3f4cd7so812118a12.0 for ; Wed, 05 Apr 2023 14:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680728749; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=v3+vInW0XN5ZUlLY3VYYNS9U9xiO66/o347P9sojNfM=; b=CtXyW1uh0jvEGGn16kVDBg5dMgvBcXvLoybhaqnejCTOznCp/5LMX1BeewUSBhfLMy OFYahyi2FpymlgFBwHgwb8/bA7LlDgDJFyJ3iShPmI7T63r0GqH3kuR5TLS2AwT36Ckz K2/zRaFilCTJXQaQH4g0YCrDYPR52/vMm7pJdYN1+6RednVFus4LVY/IgyNfb0DAlNvE m6sfmmbINTXIaUeXDWcTUMi5blrLdyJPqWFIgIMvtOj1XEvxWbsQKFVcPht+BqQgMe5P AoMD1WKPCXm+SmsyVYdb6HWHc1wj0W3WwJ5Cekah9ixfjicNh1u3/EgWAGeGZtsmk4Ti RE2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680728749; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v3+vInW0XN5ZUlLY3VYYNS9U9xiO66/o347P9sojNfM=; b=6zVqXxQoGjWvtcbcHr1C7pLMpHAuyYndys/iyulfU+X0hHKDgy5pOnKPkOc0QF3lEd 9bIjnfjMzcGBim4U3xPfO0v6m4uQ/4nEiCFvj/m0VnfNu+ty23vUYwl8kMg4GCSRL3Ed WoXdMGH7xjXLhAoU5S94zC/G3nR3Vxk3LY72nYkmaxA3s/hDLVaZP1gEklXxfdMxGyKN ZTes0cdUeqCyumP8zXkXYHS0SI99vCIefmMGQIQlnsuZcVmw6MRU5FLvP0dwuWWJ1zfv aP8XaRsLLUsNs9xbz0XiAsshquhncXhpc55ruZp72+uu4I3Sfes/MYUMf9knsv/7d5Vf QdnQ== X-Gm-Message-State: AAQBX9c+KM0OwcmiypedYubNGYXscC7yjK8e8pAdN/xM5rQY1+k5S/X+ jO2uoHN5+DUtl6E1yuQfVswEnCWnVaySXYDLuDM= X-Google-Smtp-Source: AKy350a0Xb1rsMA6u29/dFjUZTEOtcCj2OG/qxuWFcoYTVuhEVMmdrJMd7WIx5GyvJhx8wvI3w9g6i2GEyJwzneTVO4= X-Received: by 2002:a50:cd07:0:b0:4fa:7e99:9e2c with SMTP id z7-20020a50cd07000000b004fa7e999e2cmr1979828edi.0.1680728749309; Wed, 05 Apr 2023 14:05:49 -0700 (PDT) MIME-Version: 1.0 References: <20230405162144.984598-1-hjl.tools@gmail.com> <20230405162144.984598-18-hjl.tools@gmail.com> In-Reply-To: <20230405162144.984598-18-hjl.tools@gmail.com> From: Noah Goldstein Date: Wed, 5 Apr 2023 16:05:37 -0500 Message-ID: Subject: Re: [PATCH 17/19] : Add AVX-NE-CONVERT support To: "H.J. Lu" Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Apr 5, 2023 at 11:27=E2=80=AFAM H.J. Lu via Libc-alpha wrote: > > Add AVX-NE-CONVERT support to . > --- > manual/platform.texi | 3 +++ > sysdeps/x86/bits/platform/x86.h | 1 + > sysdeps/x86/cpu-features.c | 2 ++ > sysdeps/x86/include/cpu-features.h | 3 +++ > sysdeps/x86/tst-get-cpu-features.c | 2 ++ > 5 files changed, 11 insertions(+) > > diff --git a/manual/platform.texi b/manual/platform.texi > index 873ea0a84a..1e120993d7 100644 > --- a/manual/platform.texi > +++ b/manual/platform.texi > @@ -222,6 +222,9 @@ Leaf (EAX =3D 23H). > @item > @code{AVX_IFMA} -- The AVX-IFMA instruction extensions. > > +@item > +@code{AVX_NE_CONVERT} -- The AVX-NE-CONVERT instruction extensions. > + > @item > @code{AVX_VNNI} -- The AVX-VNNI instruction extensions. > > diff --git a/sysdeps/x86/bits/platform/x86.h b/sysdeps/x86/bits/platform/= x86.h > index 7b239ef188..d8ba33bd42 100644 > --- a/sysdeps/x86/bits/platform/x86.h > +++ b/sysdeps/x86/bits/platform/x86.h > @@ -309,6 +309,7 @@ enum > + cpuid_register_index_edx * 8 * sizeof (unsigned int)), > > x86_cpu_AVX_VNNI_INT8 =3D x86_cpu_index_7_ecx_1_edx + 4= , > + x86_cpu_AVX_NE_CONVERT =3D x86_cpu_index_7_ecx_1_edx + 5, > > x86_cpu_index_19_ebx > =3D (CPUID_INDEX_19 * 8 * 4 * sizeof (unsigned int) > diff --git a/sysdeps/x86/cpu-features.c b/sysdeps/x86/cpu-features.c > index f34f4884eb..dfd1b85dce 100644 > --- a/sysdeps/x86/cpu-features.c > +++ b/sysdeps/x86/cpu-features.c > @@ -141,6 +141,8 @@ update_active (struct cpu_features *cpu_features) > } > /* Determine if AVX-IFMA is usable. */ > CPU_FEATURE_SET_ACTIVE (cpu_features, AVX_IFMA); > + /* Determine if AVX-NE-CONVERT is usable. */ > + CPU_FEATURE_SET_ACTIVE (cpu_features, AVX_NE_CONVERT); > /* Determine if AVX-VNNI is usable. */ > CPU_FEATURE_SET_ACTIVE (cpu_features, AVX_VNNI); > /* Determine if AVX-VNNI-INT8 is usable. */ > diff --git a/sysdeps/x86/include/cpu-features.h b/sysdeps/x86/include/cpu= -features.h > index 5e09c58d9c..673cf8ca92 100644 > --- a/sysdeps/x86/include/cpu-features.h > +++ b/sysdeps/x86/include/cpu-features.h > @@ -316,6 +316,7 @@ enum > > /* EDX. */ > #define bit_cpu_AVX_VNNI_INT8 (1u << 4) > +#define bit_cpu_AVX_NE_CONVERT (1u << 5) > > /* CPUID_INDEX_19. */ > > @@ -556,6 +557,7 @@ enum > #define index_cpu_AVX_IFMA CPUID_INDEX_7_ECX_1 > #define index_cpu_LAM CPUID_INDEX_7_ECX_1 > #define index_cpu_AVX_VNNI_INT8 CPUID_INDEX_7_ECX_1 > +#define index_cpu_AVX_NE_CONVERT CPUID_INDEX_7_ECX_1 > > /* CPUID_INDEX_19. */ > > @@ -798,6 +800,7 @@ enum > > /* EDX. */ > #define reg_AVX_VNNI_INT8 edx > +#define reg_AVX_NE_CONVERT edx > > /* CPUID_INDEX_19. */ > > diff --git a/sysdeps/x86/tst-get-cpu-features.c b/sysdeps/x86/tst-get-cpu= -features.c > index f0585cf330..bb1b67fd1c 100644 > --- a/sysdeps/x86/tst-get-cpu-features.c > +++ b/sysdeps/x86/tst-get-cpu-features.c > @@ -216,6 +216,7 @@ do_test (void) > CHECK_CPU_FEATURE_PRESENT (LAM); > CHECK_CPU_FEATURE_PRESENT (MSRLIST); > CHECK_CPU_FEATURE_PRESENT (AVX_VNNI_INT8); > + CHECK_CPU_FEATURE_PRESENT (AVX_NE_CONVERT); > CHECK_CPU_FEATURE_PRESENT (AESKLE); > CHECK_CPU_FEATURE_PRESENT (WIDE_KL); > CHECK_CPU_FEATURE_PRESENT (PTWRITE); > @@ -384,6 +385,7 @@ do_test (void) > CHECK_CPU_FEATURE_ACTIVE (AMX_FP16); > CHECK_CPU_FEATURE_ACTIVE (AVX_IFMA); > CHECK_CPU_FEATURE_ACTIVE (AVX_VNNI_INT8); > + CHECK_CPU_FEATURE_ACTIVE (AVX_NE_CONVERT); > CHECK_CPU_FEATURE_ACTIVE (AESKLE); > CHECK_CPU_FEATURE_ACTIVE (WIDE_KL); > CHECK_CPU_FEATURE_ACTIVE (PTWRITE); > -- > 2.39.2 > LGTM Reviewed-by: Noah Goldstein