From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id E3AC73858C52 for ; Fri, 3 Feb 2023 23:30:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E3AC73858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x636.google.com with SMTP id dr8so19491239ejc.12 for ; Fri, 03 Feb 2023 15:30:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Dg9AfqzzsuXx96YjVwGbQFRp/y8ac5FL72ZXVkkGdVo=; b=MLqFF/wTAHXItacjzc28/y03S2dRKd90ZTkJ7yDxu5BZYXmISu/PnNZBO7N3H9kO0f WNPrpbtFrcE+lJz63v794ssZwVSdNf4WqvFnoqud6OLUVbzzQLjgJLBWPst2+gYWQmqU Nzbwf7m9Nlb0AKnSwSvX3vdPzVWqhREL887Z7Yrcae0kUSHgMl3dCjVc/46OeAYMzVvW TLJstQw2Oi3g8KRbu30WUa3tBp/3j/P5tnQEXIzHHkodZHir1fuiGna25vM3iKTNUrSY UGI9UcY3MS7UMrzy1VQd4EIl1ORMNSWAuiTiGaEXywwzD2A3qsOmYczQSWex2clgveKa EY4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Dg9AfqzzsuXx96YjVwGbQFRp/y8ac5FL72ZXVkkGdVo=; b=1dpuvHY/T/5tz1msR9YrY2CL+wVtjOnWGptdolBv2JnUuBfBliaYERxK9jrSDEHPrb HQD42ORrjl41EBU3A51wJQ3B/6L25A8sO2pbKlhTHN+nXjNh7dJzpyz9FO3ejIRACzCH qXuDEnwrZMuLxPEJE06EMMi+bHnnKozObVDnU0psvU/+s0bW7iRvmmKf6Uu5prot0r0c zfuUoppLXv6uO2bGb34il35W3D/a0vDbt9hItJtHjxfa3QfnhNduWuE1VOKUjXGsZcGz ufeZ3MHknEoYfYX7T7S8SqRSzNFDj7ChQib2djiitZl+TY1akogSqLo6fxwdqqvQHPIc +AJQ== X-Gm-Message-State: AO0yUKVBwIgvFuITJAC5oJMeXkyqfyrAXoGT3fO7Lu+NfKDGpqZ76DKF GLm5IWfiPf8gLNeeA0nv6KGbNCNxwneWHPnKBjM= X-Google-Smtp-Source: AK7set90r1aD3LmHWrDI6Oks2vaYmkaaaF7RMcjrx1hRb7mZJNPnQzt3DjSBcPINkm/zgfAVj4miL8bAoI/azYZz5Hc= X-Received: by 2002:a17:907:7670:b0:87b:db55:f3e5 with SMTP id kk16-20020a170907767000b0087bdb55f3e5mr3503815ejc.289.1675467030698; Fri, 03 Feb 2023 15:30:30 -0800 (PST) MIME-Version: 1.0 References: <20230202181149.2181553-1-adhemerval.zanella@linaro.org> <20230202181149.2181553-23-adhemerval.zanella@linaro.org> In-Reply-To: <20230202181149.2181553-23-adhemerval.zanella@linaro.org> From: Noah Goldstein Date: Fri, 3 Feb 2023 17:30:19 -0600 Message-ID: Subject: Re: [PATCH v12 22/31] string: Hook up the default implementation on test-strlen To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Richard Henderson , Jeff Law , Xi Ruoyao Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Feb 2, 2023 at 12:12 PM Adhemerval Zanella wrote: > > Also remove the simple_STRLEN and builtin_strlen, which are not used > anywhere. Think I'm slightly opposed to removing the simple_* test implementations as they can be useful to hook in when debugging. > > Reviewed-by: Richard Henderson > --- > string/test-strlen.c | 31 ++++++++++++++----------------- > 1 file changed, 14 insertions(+), 17 deletions(-) > > diff --git a/string/test-strlen.c b/string/test-strlen.c > index 81adf23737..0f98576f40 100644 > --- a/string/test-strlen.c > +++ b/string/test-strlen.c > @@ -37,27 +37,24 @@ > > typedef size_t (*proto_t) (const CHAR *); > > -/* Naive implementation to verify results. */ > -size_t > -simple_STRLEN (const CHAR *s) > -{ > - const CHAR *p; > - > - for (p = s; *p; ++p); > - return p - s; > -} > +IMPL (STRLEN, 1) > > +/* Also check the generic implementation. */ > +#undef STRLEN > +#undef weak_alias > +#define weak_alias(a, b) > +#undef libc_hidden_builtin_def > +#define libc_hidden_builtin_def(a) > #ifndef WIDE > -size_t > -builtin_strlen (const CHAR *p) > -{ > - return __builtin_strlen (p); > -} > -IMPL (builtin_strlen, 0) > +# define STRLEN __strlen_default > +# include "string/strlen.c" > +IMPL (__strlen_default, 1) > +#else > +# define WCSLEN __wcslen_default > +# include "wcsmbs/wcslen.c" > +IMPL (__wcslen_default, 1) > #endif > > -IMPL (STRLEN, 1) > - > > static void > do_one_test (impl_t *impl, const CHAR *s, size_t exp_len) > -- > 2.34.1 >