From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 7F0463858D37 for ; Mon, 26 Sep 2022 19:00:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F0463858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62a.google.com with SMTP id a26so16164206ejc.4 for ; Mon, 26 Sep 2022 12:00:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=AJHKmHJjN4uLalEARKiJZYRhkFyn2kknU85hPNy9eKY=; b=aj7o5f+3RLAszNSXhp5l3D0jWI29cynrmNuGBXu5RvcjlpZRa4DhoE+LooG7mXzDsz NfY4CPq3267rNLC0eNQ1Yx/GxpnljsAD5Za5HWXdksKvcow30BhtLyx/KPdDLKJ11iFo VjTh/89BxEYYtyeN0iYl+YNUR7ffiAE8Noi9rdT4IYA0S2VVdTzn84hM6afy30npuGpr 5WtSft0HLFzmsmDeykXBR98Nu5bsa+TtQmb081pKtcHgvrHhoOeoz5cgfBI+tlePUIqa pujh5AJP4kD3Si/ZNlRWPDXJV79vVZGe4p/Sl83BtKB0Ifh5NyaPjqr52UlKkIiLTLfO uY3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=AJHKmHJjN4uLalEARKiJZYRhkFyn2kknU85hPNy9eKY=; b=a1UsQOQLf5Nl0C/SnSXsnjYS78V5AshofSHL9IsauAPYPSFWL4E+AIvtDp39fy8+bz NHZxoJd1vT9twvTH60J7ktCU8mwZTxI+fVeTT+FIY0Q3IcQl/yJD81v+YgLGeWwxXnHp F6WiBwQ0q8bEbCF2zLYSof6zAZKsjQ7T6Yb+zHql4YrMfdfFzkDxH+fvGT7HSZOUnf01 tqG9U0A5NSDFo4lyYguwb3vA76CLPZmOaXKeZGQy0/MOwRCLpcTWz7b3vQbRSv2N4w29 +T7GgYP5OnhRGdHqLXPLzVeiNaxxBKBW+bs3JCj0mpM7Ek91VMAbVSenqaSYww0eqP+f wlfw== X-Gm-Message-State: ACrzQf1g+oOa/iHdv0vIfCiLsJ0P+L33BlhIQShUjedkAlc/BW3KtB2u iFXqD/sAYgY5SGoeOyarGrSqhxVNWX50/m4Tu3SUP//x X-Google-Smtp-Source: AMsMyM7HYIDUXpJdM9UVksdNT4gTYXyRn50Jgps7yevdUv0oANrxYOBj+1bNjHx18zJo3xBgcMI1NUt3eMMiFKeh88Y= X-Received: by 2002:a17:906:fe46:b0:73d:939a:ec99 with SMTP id wz6-20020a170906fe4600b0073d939aec99mr19823461ejb.169.1664218818965; Mon, 26 Sep 2022 12:00:18 -0700 (PDT) MIME-Version: 1.0 References: <20220926165314.4005859-1-adhemerval.zanella@linaro.org> In-Reply-To: <20220926165314.4005859-1-adhemerval.zanella@linaro.org> From: Noah Goldstein Date: Mon, 26 Sep 2022 12:00:06 -0700 Message-ID: Subject: Re: [PATCH] x86: Remove .tfloat usage To: Adhemerval Zanella Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_LOTSOFHASH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Sep 26, 2022 at 9:53 AM Adhemerval Zanella via Libc-alpha wrote: > > Some compiler does not support it (such as clang integrated assembly) > neither gcc emits it. Does libm object change at all due to this change? > --- > sysdeps/i386/fpu/e_atanh.S | 3 ++- > sysdeps/i386/fpu/e_atanhf.S | 3 ++- > sysdeps/i386/fpu/e_atanhl.S | 3 ++- > sysdeps/i386/fpu/s_asinhl.S | 3 ++- > sysdeps/i386/fpu/s_cbrtl.S | 44 +++++++++++++++++++++-------------- > sysdeps/i386/fpu/s_expm1.S | 3 ++- > sysdeps/i386/fpu/s_expm1f.S | 3 ++- > sysdeps/i386/fpu/s_log1pl.S | 3 ++- > sysdeps/x86_64/fpu/s_log1pl.S | 3 ++- > 9 files changed, 42 insertions(+), 26 deletions(-) > > diff --git a/sysdeps/i386/fpu/e_atanh.S b/sysdeps/i386/fpu/e_atanh.S > index 6e4fef06b2..a7fd9a60fa 100644 > --- a/sysdeps/i386/fpu/e_atanh.S > +++ b/sysdeps/i386/fpu/e_atanh.S > @@ -33,7 +33,8 @@ one: .double 1.0 > limit: .double 0.29 > ASM_SIZE_DIRECTIVE(limit) > .type ln2_2,@object > -ln2_2: .tfloat 0.3465735902799726547086160 > +ln2_2: .quad 0xb17217f7d1cf79ac /* 0.3465735902799726547086160L */ > + .short 0x3ffd > ASM_SIZE_DIRECTIVE(ln2_2) > > DEFINE_DBL_MIN > diff --git a/sysdeps/i386/fpu/e_atanhf.S b/sysdeps/i386/fpu/e_atanhf.S > index 146196eced..4ab1fa31fb 100644 > --- a/sysdeps/i386/fpu/e_atanhf.S > +++ b/sysdeps/i386/fpu/e_atanhf.S > @@ -34,7 +34,8 @@ limit: .double 0.29 > ASM_SIZE_DIRECTIVE(limit) > .align ALIGNARG(4) > .type ln2_2,@object > -ln2_2: .tfloat 0.3465735902799726547086160 > +ln2_2: .quad 0xb17217f7d1cf79ac /* 0.3465735902799726547086160L */ > + .short 0x3ffd > ASM_SIZE_DIRECTIVE(ln2_2) > > DEFINE_FLT_MIN > diff --git a/sysdeps/i386/fpu/e_atanhl.S b/sysdeps/i386/fpu/e_atanhl.S > index 1f6eb7ce48..df3f1b8f84 100644 > --- a/sysdeps/i386/fpu/e_atanhl.S > +++ b/sysdeps/i386/fpu/e_atanhl.S > @@ -39,7 +39,8 @@ limit: .double 0.29 > ASM_SIZE_DIRECTIVE(limit) > .align ALIGNARG(4) > .type ln2_2,@object > -ln2_2: .tfloat 0.3465735902799726547086160 > +ln2_2: .quad 0xb17217f7d1cf79ac /* 0.3465735902799726547086160 */ > + .short 0x3ffd > ASM_SIZE_DIRECTIVE(ln2_2) > > #ifdef PIC > diff --git a/sysdeps/i386/fpu/s_asinhl.S b/sysdeps/i386/fpu/s_asinhl.S > index bd442c6a09..f4f420d060 100644 > --- a/sysdeps/i386/fpu/s_asinhl.S > +++ b/sysdeps/i386/fpu/s_asinhl.S > @@ -23,7 +23,8 @@ > > .align ALIGNARG(4) > .type huge,@object > -huge: .tfloat 1e+4930 > +huge: .quad 0x89b634e7456ffa1d /* 1e+4930 */ > + .short 0x7ff8 > ASM_SIZE_DIRECTIVE(huge) > .align ALIGNARG(4) > /* Please note that we use double value for 1.0. This number > diff --git a/sysdeps/i386/fpu/s_cbrtl.S b/sysdeps/i386/fpu/s_cbrtl.S > index 8802164706..935ac20530 100644 > --- a/sysdeps/i386/fpu/s_cbrtl.S > +++ b/sysdeps/i386/fpu/s_cbrtl.S > @@ -23,55 +23,63 @@ > > .align ALIGNARG(4) > .type f8,@object > -f8: .tfloat 0.161617097923756032 > +f8: .quad 0xa57ef3d83a542839 /* 0.161617097923756032 */ > + .short 0x3ffc > ASM_SIZE_DIRECTIVE(f8) > .align ALIGNARG(4) > .type f7,@object > -f7: .tfloat -0.988553671195413709 > +f7: .quad 0xfd11da7820029014 /* -0.988553671195413709 */ > + .short 0xbffe > ASM_SIZE_DIRECTIVE(f7) > .align ALIGNARG(4) > .type f6,@object > -f6: .tfloat 2.65298938441952296 > +f6: .quad 0xa9ca93fcade3b4ad /* 2.65298938441952296 */ > + .short 0x4000 > ASM_SIZE_DIRECTIVE(f6) > .align ALIGNARG(4) > .type f5,@object > -f5: .tfloat -4.11151425200350531 > +f5: .quad 0x839186562c931c34 /* -4.11151425200350531 */ > + .short 0xc001 > ASM_SIZE_DIRECTIVE(f5) > .align ALIGNARG(4) > .type f4,@object > -f4: .tfloat 4.09559907378707839 > +f4: .quad 0x830f25c9ee304594 /* 4.09559907378707839 */ > + .short 0x4001 > ASM_SIZE_DIRECTIVE(f4) > .align ALIGNARG(4) > .type f3,@object > -f3: .tfloat -2.82414939754975962 > +f3: .quad 0xb4bedd1d5fa2f0c6 /* -2.82414939754975962 */ > + .short 0xc000 > ASM_SIZE_DIRECTIVE(f3) > .align ALIGNARG(4) > .type f2,@object > -f2: .tfloat 1.67595307700780102 > +f2: .quad 0xd685a163b08586e3 /* 1.67595307700780102 */ > + .short 0x3fff > ASM_SIZE_DIRECTIVE(f2) > .align ALIGNARG(4) > .type f1,@object > -f1: .tfloat 0.338058687610520237 > +f1: .quad 0xad16073ed4ec3b45 /* 0.338058687610520237 */ > + .short 0x3ffd > ASM_SIZE_DIRECTIVE(f1) > > -#define CBRT2 1.2599210498948731648 > -#define ONE_CBRT2 0.793700525984099737355196796584 > -#define SQR_CBRT2 1.5874010519681994748 > -#define ONE_SQR_CBRT2 0.629960524947436582364439673883 > - > /* We make the entries in the following table all 16 bytes > wide to avoid having to implement a multiplication by 10. */ > .type factor,@object > .align ALIGNARG(4) > -factor: .tfloat ONE_SQR_CBRT2 > +factor: .quad 0xa14517cc6b945711 /* 0.629960524947436582364439673883L */ > + .short 0x3ffe > .byte 0, 0, 0, 0, 0, 0 > - .tfloat ONE_CBRT2 > + .quad 0xcb2ff529eb71e415 /* 1.5874010519681994748L */ > + .short 0x3ffe > .byte 0, 0, 0, 0, 0, 0 > - .tfloat 1.0 > + .quad 0x8000000000000000 /* 1.0L */ > + .short 0x3fff > .byte 0, 0, 0, 0, 0, 0 > - .tfloat CBRT2 > + .quad 0xa14517cc6b945711 /* 1.2599210498948731648L */ > + .short 0x3fff > .byte 0, 0, 0, 0, 0, 0 > - .tfloat SQR_CBRT2 > + .quad 0xcb2ff529eb71e416 /* 1.5874010519681994748L */ > + .short 0x3fff > ASM_SIZE_DIRECTIVE(factor) > > .type two64,@object > diff --git a/sysdeps/i386/fpu/s_expm1.S b/sysdeps/i386/fpu/s_expm1.S > index 7199d681ba..038ff72feb 100644 > --- a/sysdeps/i386/fpu/s_expm1.S > +++ b/sysdeps/i386/fpu/s_expm1.S > @@ -33,7 +33,8 @@ minus1: .double -1.0 > one: .double 1.0 > ASM_SIZE_DIRECTIVE(one) > .type l2e,@object > -l2e: .tfloat 1.442695040888963407359924681002 > +l2e: .quad 0xb8aa3b295c17f0bc /* 1.442695040888963407359924681002 */ > + .short 0x3fff > ASM_SIZE_DIRECTIVE(l2e) > > DEFINE_DBL_MIN > diff --git a/sysdeps/i386/fpu/s_expm1f.S b/sysdeps/i386/fpu/s_expm1f.S > index 04c37bda1b..b0406a45aa 100644 > --- a/sysdeps/i386/fpu/s_expm1f.S > +++ b/sysdeps/i386/fpu/s_expm1f.S > @@ -33,7 +33,8 @@ minus1: .double -1.0 > one: .double 1.0 > ASM_SIZE_DIRECTIVE(one) > .type l2e,@object > -l2e: .tfloat 1.442695040888963407359924681002 > +l2e: .quad 0xb8aa3b295c17f0bc /* 1.442695040888963407359924681002 */ > + .short 0x3fff > ASM_SIZE_DIRECTIVE(l2e) > > DEFINE_FLT_MIN > diff --git a/sysdeps/i386/fpu/s_log1pl.S b/sysdeps/i386/fpu/s_log1pl.S > index f28349f7d2..202995d3d6 100644 > --- a/sysdeps/i386/fpu/s_log1pl.S > +++ b/sysdeps/i386/fpu/s_log1pl.S > @@ -14,7 +14,8 @@ RCSID("$NetBSD: s_log1p.S,v 1.7 1995/05/09 00:10:58 jtc Exp $") > -1 + sqrt(2) / 2 <= x <= 1 - sqrt(2) / 2 > 0.29 is a safe value. > */ > -limit: .tfloat 0.29 > +limit: .quad 0x947ae147ae147ae1 /* 0.29 */ > + .short 0x3ffd > /* Please note: we use a double value here. Since 1.0 has > an exact representation this does not effect the accuracy > but it helps to optimize the code. */ > diff --git a/sysdeps/x86_64/fpu/s_log1pl.S b/sysdeps/x86_64/fpu/s_log1pl.S > index 8219f6fbcc..b053579dc5 100644 > --- a/sysdeps/x86_64/fpu/s_log1pl.S > +++ b/sysdeps/x86_64/fpu/s_log1pl.S > @@ -14,7 +14,8 @@ RCSID("$NetBSD: s_log1p.S,v 1.7 1995/05/09 00:10:58 jtc Exp $") > -1 + sqrt(2) / 2 <= x <= 1 - sqrt(2) / 2 > 0.29 is a safe value. > */ > -limit: .tfloat 0.29 > +limit: .quad 0x947ae147ae147ae1 /* 0.29L */ > + .short 0x3ffd > /* Please note: we use a double value here. Since 1.0 has > an exact representation this does not effect the accuracy > but it helps to optimize the code. */ > -- > 2.34.1 >