From: Noah Goldstein <goldstein.w.n@gmail.com>
To: Sunil Pandey <skpgkp2@gmail.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
Libc-stable Mailing List <libc-stable@sourceware.org>,
Florian Weimer <fweimer@redhat.com>,
Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v8 1/4] math: redirect roundeven function
Date: Tue, 13 Sep 2022 18:25:17 -0700 [thread overview]
Message-ID: <CAFUsyf+D86qBVCX6AK4+1dzvEQxDQrOS8fRi5_f=X4nMpfcJVw@mail.gmail.com> (raw)
In-Reply-To: <CAMAf5_fuReMupm7DVhU2HPkqGKZO52P6ytXQDf7CsqcWDUYG+Q@mail.gmail.com>
On Sun, Sep 11, 2022 at 12:57 PM Sunil Pandey via Libc-stable
<libc-stable@sourceware.org> wrote:
>
> On Wed, Jun 23, 2021 at 3:32 PM H.J. Lu via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
> >
> > From: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
> >
> > This patch redirect roundeven function for futhermore changes.
> >
> > Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
> > Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
> > ---
> > include/math.h | 2 +-
> > sysdeps/ieee754/dbl-64/s_roundeven.c | 4 +++-
> > sysdeps/ieee754/float128/s_roundevenf128.c | 1 +
> > sysdeps/ieee754/flt-32/s_roundevenf.c | 3 +++
> > sysdeps/ieee754/ldbl-128/s_roundevenl.c | 1 +
> > sysdeps/ieee754/ldbl-96/s_roundevenl.c | 1 +
> > 6 files changed, 10 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/math.h b/include/math.h
> > index e1c2a4eb64..b4772d3d3b 100644
> > --- a/include/math.h
> > +++ b/include/math.h
> > @@ -38,7 +38,6 @@ libm_hidden_proto (__issignaling)
> > libm_hidden_proto (__issignalingf)
> > libm_hidden_proto (__exp)
> > libm_hidden_proto (__expf)
> > -libm_hidden_proto (__roundeven)
> >
> > # if !defined __NO_LONG_DOUBLE_MATH \
> > && __LDOUBLE_REDIRECTS_TO_FLOAT128_ABI == 0
> > @@ -159,6 +158,7 @@ fabsf128 (_Float128 x)
> > MATH_REDIRECT (sqrt, "__ieee754_", MATH_REDIRECT_UNARY_ARGS)
> > MATH_REDIRECT (ceil, "__", MATH_REDIRECT_UNARY_ARGS)
> > MATH_REDIRECT (floor, "__", MATH_REDIRECT_UNARY_ARGS)
> > +MATH_REDIRECT (roundeven, "__", MATH_REDIRECT_UNARY_ARGS)
> > MATH_REDIRECT (rint, "__", MATH_REDIRECT_UNARY_ARGS)
> > MATH_REDIRECT (trunc, "__", MATH_REDIRECT_UNARY_ARGS)
> > MATH_REDIRECT (round, "__", MATH_REDIRECT_UNARY_ARGS)
> > diff --git a/sysdeps/ieee754/dbl-64/s_roundeven.c b/sysdeps/ieee754/dbl-64/s_roundeven.c
> > index 943b2c634c..5deff3bb8a 100644
> > --- a/sysdeps/ieee754/dbl-64/s_roundeven.c
> > +++ b/sysdeps/ieee754/dbl-64/s_roundeven.c
> > @@ -16,6 +16,7 @@
> > License along with the GNU C Library; if not, see
> > <https://www.gnu.org/licenses/>. */
> >
> > +#define NO_MATH_REDIRECT
> > #include <math.h>
> > #include <math_private.h>
> > #include <libm-alias-double.h>
> > @@ -66,5 +67,6 @@ __roundeven (double x)
> > INSERT_WORDS64 (x, ix);
> > return x;
> > }
> > -hidden_def (__roundeven)
> > +#ifndef __roundeven
> > libm_alias_double (__roundeven, roundeven)
> > +#endif
> > diff --git a/sysdeps/ieee754/float128/s_roundevenf128.c b/sysdeps/ieee754/float128/s_roundevenf128.c
> > index 5a9b3f395f..e0faf727f6 100644
> > --- a/sysdeps/ieee754/float128/s_roundevenf128.c
> > +++ b/sysdeps/ieee754/float128/s_roundevenf128.c
> > @@ -1,2 +1,3 @@
> > +#define NO_MATH_REDIRECT
> > #include <float128_private.h>
> > #include "../ldbl-128/s_roundevenl.c"
> > diff --git a/sysdeps/ieee754/flt-32/s_roundevenf.c b/sysdeps/ieee754/flt-32/s_roundevenf.c
> > index ae54365bbe..2cc0d7b001 100644
> > --- a/sysdeps/ieee754/flt-32/s_roundevenf.c
> > +++ b/sysdeps/ieee754/flt-32/s_roundevenf.c
> > @@ -17,6 +17,7 @@
> > License along with the GNU C Library; if not, see
> > <https://www.gnu.org/licenses/>. */
> >
> > +#define NO_MATH_REDIRECT
> > #include <math.h>
> > #include <math_private.h>
> > #include <libm-alias-float.h>
> > @@ -67,4 +68,6 @@ __roundevenf (float x)
> > SET_FLOAT_WORD (x, ix);
> > return x;
> > }
> > +#ifndef __roundevenf
> > libm_alias_float (__roundeven, roundeven)
> > +#endif
> > diff --git a/sysdeps/ieee754/ldbl-128/s_roundevenl.c b/sysdeps/ieee754/ldbl-128/s_roundevenl.c
> > index 02765be0e0..7c9c11fad2 100644
> > --- a/sysdeps/ieee754/ldbl-128/s_roundevenl.c
> > +++ b/sysdeps/ieee754/ldbl-128/s_roundevenl.c
> > @@ -17,6 +17,7 @@
> > License along with the GNU C Library; if not, see
> > <https://www.gnu.org/licenses/>. */
> >
> > +#define NO_MATH_REDIRECT
> > #include <math.h>
> > #include <math_private.h>
> > #include <libm-alias-ldouble.h>
> > diff --git a/sysdeps/ieee754/ldbl-96/s_roundevenl.c b/sysdeps/ieee754/ldbl-96/s_roundevenl.c
> > index 8340116ed8..f826829c31 100644
> > --- a/sysdeps/ieee754/ldbl-96/s_roundevenl.c
> > +++ b/sysdeps/ieee754/ldbl-96/s_roundevenl.c
> > @@ -17,6 +17,7 @@
> > License along with the GNU C Library; if not, see
> > <https://www.gnu.org/licenses/>. */
> >
> > +#define NO_MATH_REDIRECT
> > #include <math.h>
> > #include <math_private.h>
> > #include <libm-alias-ldouble.h>
> > --
> > 2.31.1
> >
>
> I would like to backport this patch to release branch 2.33.
>
> Any comments/suggestions or objections on this.
>
> commit 447954a206837b5f153869cfeeeab44631c3fac9
> Author: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
> Date: Mon May 24 09:43:10 2021 +0800
>
> math: redirect roundeven function
>
> This patch redirect roundeven function for futhermore changes.
>
> Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
> Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
Fine by me.
next prev parent reply other threads:[~2022-09-14 1:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 22:28 [PATCH v8 0/4] Improve " H.J. Lu
2021-06-23 22:28 ` [PATCH v8 1/4] math: redirect " H.J. Lu
2022-09-11 19:56 ` Sunil Pandey
2022-09-14 1:25 ` Noah Goldstein [this message]
2022-09-23 10:49 ` 謝昇達(Shen-Ta Hsieh)
2022-09-24 2:12 ` Sunil Pandey
2021-06-23 22:28 ` [PATCH v8 2/4] Update " H.J. Lu
2021-06-28 8:08 ` Andreas Schwab
2021-06-28 8:33 ` Stefan Liebler
2021-06-28 11:42 ` H.J. Lu
2021-06-29 7:14 ` Stefan Liebler
2021-06-23 22:28 ` [PATCH v8 3/4] x86_64: roundeven with sse4.1 support H.J. Lu
2022-04-28 0:11 ` Sunil Pandey
2022-09-11 20:08 ` Sunil Pandey
2022-09-14 1:25 ` Noah Goldstein
2022-09-23 10:50 ` 謝昇達(Shen-Ta Hsieh)
2021-06-23 22:28 ` [PATCH v8 4/4] Use GCC builtins for roundeven functions if desired H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFUsyf+D86qBVCX6AK4+1dzvEQxDQrOS8fRi5_f=X4nMpfcJVw@mail.gmail.com' \
--to=goldstein.w.n@gmail.com \
--cc=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=ibmibmibm.tw@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-stable@sourceware.org \
--cc=skpgkp2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).