From: Noah Goldstein <goldstein.w.n@gmail.com>
To: Mayshao-oc <Mayshao-oc@zhaoxin.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
GNU C Library <libc-alpha@sourceware.org>,
Florian Weimer <fw@deneb.enyo.de>,
"Carlos O'Donell" <carlos@redhat.com>,
"Louis Qi(BJ-RD)" <LouisQi@zhaoxin.com>
Subject: Re: [PATCH v1 3/6] x86: Remove mem{move|cpy}-ssse3
Date: Mon, 28 Mar 2022 21:57:03 -0500 [thread overview]
Message-ID: <CAFUsyf+DD-fFtat_z41iq-dsCw-g7VVEDG=WvWasDqMxobAqxQ@mail.gmail.com> (raw)
In-Reply-To: <09816f3ba25043339d57121bbae3d991@zhaoxin.com>
On Mon, Mar 28, 2022 at 9:51 PM Mayshao-oc <Mayshao-oc@zhaoxin.com> wrote:
>
> On Mon, Mar 28, 2022 at 9:07 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
>
> > On Mon, Mar 28, 2022 at 1:10 AM Mayshao-oc <Mayshao-oc@zhaoxin.com> wrote:
> > >
> > > On Fri, Mar 25, 2022 at 6:36 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > >
> > > > With SSE2, SSE4.1, AVX2, and EVEX versions very few targets prefer
> > > > SSSE3. As a result its no longer with the code size cost.
> > > > ---
> > > > sysdeps/x86_64/multiarch/Makefile | 2 -
> > > > sysdeps/x86_64/multiarch/ifunc-impl-list.c | 15 -
> > > > sysdeps/x86_64/multiarch/ifunc-memmove.h | 18 +-
> > > > sysdeps/x86_64/multiarch/memcpy-ssse3.S | 3151 --------------------
> > > > sysdeps/x86_64/multiarch/memmove-ssse3.S | 4 -
> > > > 5 files changed, 7 insertions(+), 3183 deletions(-)
> > > > delete mode 100644 sysdeps/x86_64/multiarch/memcpy-ssse3.S
> > > > delete mode 100644 sysdeps/x86_64/multiarch/memmove-ssse3.S
> > >
> > > > On some platforms, such as Zhaoxin, the memcpy performance of SSSE3
> > > is better than that of AVX2, and the current computer system has sufficient
> > > disk capacity and memory capacity.
> >
> > How does the SSSE3 version compare against the SSE2 version?
>
> On some Zhaoxin processors, the overall performance of SSSE3 is about
> 10% higher than that of SSE2.
>
>
> Best Regards,
> May Shao
Any chance you can post the result from running `bench-memset` or some
equivalent benchmark? Curious where the regressions are. Ideally we would
fix the SSE2 version so its optimal.
>
> > > It is strongly recommended to keep the SSSE3 version.
> > >
> >
> >
> > --
> > H.J.
next prev parent reply other threads:[~2022-03-29 2:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 8:10 Mayshao-oc
2022-03-28 13:07 ` H.J. Lu
2022-03-29 2:51 ` Mayshao-oc
2022-03-29 2:57 ` Noah Goldstein [this message]
2022-03-30 9:56 ` Mayshao-oc
2022-03-30 16:45 ` Noah Goldstein
2022-03-30 16:54 ` Noah Goldstein
2022-03-31 3:34 ` Mayshao-oc
2022-03-31 3:47 ` Noah Goldstein
2022-03-31 4:54 ` Mayshao-oc
-- strict thread matches above, loose matches on Subject: below --
2022-03-25 18:36 [PATCH v1 1/6] x86: Remove {w}memcmp-ssse3 Noah Goldstein
2022-03-25 18:36 ` [PATCH v1 3/6] x86: Remove mem{move|cpy}-ssse3 Noah Goldstein
2022-03-25 19:56 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFUsyf+DD-fFtat_z41iq-dsCw-g7VVEDG=WvWasDqMxobAqxQ@mail.gmail.com' \
--to=goldstein.w.n@gmail.com \
--cc=LouisQi@zhaoxin.com \
--cc=Mayshao-oc@zhaoxin.com \
--cc=carlos@redhat.com \
--cc=fw@deneb.enyo.de \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).