From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id 9197C3858D33 for ; Fri, 30 Jun 2023 23:22:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9197C3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-x229.google.com with SMTP id 5614622812f47-3a0423ea74eso1798222b6e.1 for ; Fri, 30 Jun 2023 16:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688167363; x=1690759363; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FDsKoRXIl964rweUIG8UWIsAMQ0eBwVtPPcEZgDfnFA=; b=FiSJVKnZhhxWqcsH5mgXFvTANkEL5HC0K9EJdV3Ih59AvKAUcdH4KccK6tTOvs3REv sobchscIgliqemTmahV3Ami2m6keOJlDNpsk9j/vorS8cqXgFDgSfRukIC+jG/Pls3MX ZMvdz9M9v0DY3VsngyL2OCieVxPPJH58hnZLcNZ0m/uANQh/yL3MdM9o8xJQDvtnUmBv jC8uXyL1d5cY+cd8eR3Aad1m6qLGrZmlg/Xyd//uSTQwgX+nIYA8h1CXTRrFMbSY2rvA 2yfu4dEOUF40J2id5jhgQ0Xt/tvzwJUUVTI+aWLEDYByAYQuoHksSKGnqtiLdeGMMeJY Sc6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688167363; x=1690759363; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FDsKoRXIl964rweUIG8UWIsAMQ0eBwVtPPcEZgDfnFA=; b=anpW8oWsZSVXfTcXQXNI/sEu3NrZwRZz8ORaHDVAqipqvbgRgjarUEInkL0TYK0uuq WHtdQ6kiZkHF258663B4ieii5w05ly3WyfcpLZkZkwlzJhFVyMbb5Ebtods+3lr6eVSo EKafE3+5KK6uf5rV/8eoC1IRimEvv0kd5emypzoxzS+dWJ9ypBBXpxxnOlSgiClxA4sG wK8s52WLzP39WQuRj207pObAG1g4XWVXAt5myRQ23+ERs/KbE9qSmrD26xKhmpARb8eR 3q9LinD+T5AoZZOBO1kDhJUQ91zp6wKbnvkkI/WwXj3T7XgjiWpE8yKR5+wIC/d5dzK/ 9biw== X-Gm-Message-State: AC+VfDwhmRoFxAJIKkiqV55zYguzJ7A6PE3u3quoG/rU8N01EnEbAXD9 q36t9eVOWRs/4sG3AoPgQSEjFFxeNuvzDrEAXNk= X-Google-Smtp-Source: ACHHUZ63QOoFu8qtDtm5smK6gBO0vinUQ6SGPO1HWxqI8mMSchgL6CaS0Lfr2DaxKykjctlWc7gGdixm0jPwGwpcRvU= X-Received: by 2002:a05:6808:8c9:b0:3a3:623f:d840 with SMTP id k9-20020a05680808c900b003a3623fd840mr3876460oij.21.1688167362860; Fri, 30 Jun 2023 16:22:42 -0700 (PDT) MIME-Version: 1.0 References: <20230630204812.2059831-1-skpgkp2@gmail.com> In-Reply-To: From: Noah Goldstein Date: Fri, 30 Jun 2023 18:22:31 -0500 Message-ID: Subject: Re: [PATCH] x86_64: Implement AVX2 version of strlcpy/wcslcpy function To: Sunil Pandey Cc: Paul Eggert , libc-alpha@sourceware.org, hjl.tools@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Jun 30, 2023 at 5:21=E2=80=AFPM Sunil Pandey wr= ote: > > > > On Fri, Jun 30, 2023 at 2:27=E2=80=AFPM Paul Eggert = wrote: >> >> On 2023-06-30 14:04, Noah Goldstein via Libc-alpha wrote: >> > Think we should at the very least wait for the generic strlcpy codes >> > to land first. >> >> Let's not optimize these functions at all, unless there's good and >> measured reason to do so. In practice I expected they're called with >> small sizes for which optimization is a net minus as it consumes >> valuable maintenance time with no real benefit. > > > Hi Paul, > > Attached is strcpy/wcslcpy microbenchmark data based on Noah strlcpy/wcsl= cpy microbenchmark patch. > I don't think the concern is that we can beat the generic impl (which hasn'= t even landed yet AFAICT), it whether doing so makes sense given the usage/goal of the functions. > https://sourceware.org/pipermail/libc-alpha/2023-April/147557.html > > Thanks, > Sunil