From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by sourceware.org (Postfix) with ESMTPS id E9CF53858C27 for ; Wed, 13 Jul 2022 01:34:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E9CF53858C27 Received: by mail-oi1-x22c.google.com with SMTP id n206so3835354oia.6 for ; Tue, 12 Jul 2022 18:34:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=c8DEOin75tPLR/xUWkEnQ4DpjeKksly1DAy9XR8VUTU=; b=VeY5ZfBFUYhkE+4uDMT1y/WP/KSy95mR5lAP/TmZmmecdpUTlS2jSXBQcH6anPy8m/ 0EDS+QLn5FT3Iup46cBIfv4rWgiJKitZ+kHnDOFsqM6hH5UXWKqIkjQDoIuHBcW+LPnX 9R7C/PMIQ+NP+Lvm4P1RWNUjOb6W9AGJd9GqhsNRY2VH2dNPD2gr9KB+GrfdoHdPqU7j h69SBcnc++hcq30UT2Sgr4DCe9wc1sin6vr7Eh1T+qa3Y733ncu2yAuOvNJKOVzGvx3I oTuymCx/2gmrIOxJAAZlUDus5biTctS6dt8cWHrjOOXUlUitqJ5XD8laLZnN6kA+lLwb pebQ== X-Gm-Message-State: AJIora+4Qu14AveGbJWNmgcX3wPqNHvA70lXoDFLsCECty/3WwGtfvzj QVfxWbxQ6IxT+ni90cG42eMkLuwdVZt5GHDLsg+Klq0o X-Google-Smtp-Source: AGRyM1vAjEHMevQqg/HYf8cPs5BfQ9jqBP3+XsGYCxFLb2bVMOrbIbDpgVwCoQanCIYNMqZMt8PpSuKPv73jGBfz6U8= X-Received: by 2002:a05:6808:170b:b0:335:1807:e4a2 with SMTP id bc11-20020a056808170b00b003351807e4a2mr544769oib.89.1657676083899; Tue, 12 Jul 2022 18:34:43 -0700 (PDT) MIME-Version: 1.0 References: <20220704041550.3858613-1-goldstein.w.n@gmail.com> In-Reply-To: <20220704041550.3858613-1-goldstein.w.n@gmail.com> From: Noah Goldstein Date: Tue, 12 Jul 2022 18:34:33 -0700 Message-ID: Subject: Re: [PATCH v1] scripts: Add support for build x86-64 glibc with multiple ISA levels To: GNU C Library Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2022 01:34:47 -0000 On Sun, Jul 3, 2022 at 9:17 PM Noah Goldstein wro= te: > > Tested all added builds on x86-64-v3 machine. > --- > I was a bit concerned we would need to check the host (building) machine > before enabling higher ISA builds, but everything seems to be working. > > I tested the x86-64 v4 build on a v3 machine. If there is a case I missed > and we do need to check host machine LMK. > > Result running all x86-64 builds: > > rm -rf build-many; python3 src/glibc/scripts/build-many-glibcs.py build-= many/ checkout gcc-vcs-11; python3 src/glibc/scripts/build-many-glibcs.py b= uild-many/ host-libraries --keep=3Dfailed; python3 src/glibc/scripts/build-= many-glibcs.py build-many compilers x86_64-linux-gnu --keep=3Dfailed; pytho= n3 src/glibc/scripts/build-many-glibcs.py build-many glibcs x86_64-linux-gn= u x86_64-linux-gnu-disable-multi-arch x86_64-linux-gnu-isa-v2 x86_64-linux-= gnu-isa-v2-disable-multi-arch x86_64-linux-gnu-isa-v3 x86_64-linux-gnu-isa-= v3-disable-multi-arch x86_64-linux-gnu-isa-v4 x86_64-linux-gnu-isa-v4-disab= le-multi-arch x86_64-linux-gnu-minimal x86_64-linux-gnu-no-pie x86_64-linux= -gnu-x32 x86_64-linux-gnu-x32-no-pie x86_64-linux-gnu --keep=3Dfailed > configure.ac:83: installing 'build-aux/compile' > configure.ac:46: installing 'build-aux/config.guess' > configure.ac:46: installing 'build-aux/config.sub' > configure.ac:26: installing 'build-aux/install-sh' > configure.ac:26: installing 'build-aux/missing' > Makefile.am: installing './INSTALL' > Makefile.am: installing 'build-aux/depcomp' > Makefile.am:32: installing 'build-aux/mdate-sh' > doc/Makefrag.am:106: warning: user target '$(srcdir)/doc/version.texi' de= fined here ... > Makefile.am:155: 'doc/Makefrag.am' included from here > /usr/share/automake-1.16/am/texi-vers.am: ... overrides Automake target '= $(srcdir)/doc/version.texi' defined here > Makefile.am:32: installing 'build-aux/texinfo.tex' > parallel-tests: installing 'build-aux/test-driver' > configure.ac:25: installing 'build-aux/compile' > configure.ac:9: installing 'build-aux/config.guess' > configure.ac:9: installing 'build-aux/config.sub' > configure.ac:14: installing 'build-aux/install-sh' > configure.ac:14: installing 'build-aux/missing' > Makefile.am: installing './INSTALL' > Makefile.am: installing 'build-aux/depcomp' > configure.ac: installing 'build-aux/ylwrap' > parallel-tests: installing 'build-aux/test-driver' > PASS: host-libraries gmp rm > PASS: host-libraries gmp mkdir > PASS: host-libraries gmp configure > PASS: host-libraries gmp build > PASS: host-libraries gmp check > PASS: host-libraries gmp install > PASS: host-libraries gmp cleanup > PASS: host-libraries mpfr rm > PASS: host-libraries mpfr mkdir > PASS: host-libraries mpfr configure > PASS: host-libraries mpfr build > PASS: host-libraries mpfr check > PASS: host-libraries mpfr install > PASS: host-libraries mpfr cleanup > PASS: host-libraries mpc rm > PASS: host-libraries mpc mkdir > PASS: host-libraries mpc configure > PASS: host-libraries mpc build > PASS: host-libraries mpc check > PASS: host-libraries mpc install > PASS: host-libraries mpc cleanup > PASS: host-libraries done > PASS: compilers-x86_64-linux-gnu check-host-libraries > PASS: compilers-x86_64-linux-gnu binutils rm > PASS: compilers-x86_64-linux-gnu binutils mkdir > PASS: compilers-x86_64-linux-gnu binutils configure > PASS: compilers-x86_64-linux-gnu binutils build > PASS: compilers-x86_64-linux-gnu binutils install > PASS: compilers-x86_64-linux-gnu binutils cleanup > PASS: compilers-x86_64-linux-gnu linux rm > PASS: compilers-x86_64-linux-gnu linux mkdir > PASS: compilers-x86_64-linux-gnu linux install-headers > PASS: compilers-x86_64-linux-gnu linux cleanup > PASS: compilers-x86_64-linux-gnu gcc-first rm > PASS: compilers-x86_64-linux-gnu gcc-first mkdir > PASS: compilers-x86_64-linux-gnu gcc-first configure > PASS: compilers-x86_64-linux-gnu gcc-first build > PASS: compilers-x86_64-linux-gnu gcc-first install > PASS: compilers-x86_64-linux-gnu gcc-first cleanup > PASS: compilers-x86_64-linux-gnu glibc x86_64-linux-gnu rm > PASS: compilers-x86_64-linux-gnu glibc x86_64-linux-gnu mkdir > PASS: compilers-x86_64-linux-gnu glibc x86_64-linux-gnu configure > PASS: compilers-x86_64-linux-gnu glibc x86_64-linux-gnu build > PASS: compilers-x86_64-linux-gnu glibc x86_64-linux-gnu install > PASS: compilers-x86_64-linux-gnu glibc x86_64-linux-gnu mkdir-lib > PASS: compilers-x86_64-linux-gnu glibc x86_64-linux-gnu cleanup > PASS: compilers-x86_64-linux-gnu glibc x86_64-linux-gnu-x32 rm > PASS: compilers-x86_64-linux-gnu glibc x86_64-linux-gnu-x32 mkdir > PASS: compilers-x86_64-linux-gnu glibc x86_64-linux-gnu-x32 configure > PASS: compilers-x86_64-linux-gnu glibc x86_64-linux-gnu-x32 build > PASS: compilers-x86_64-linux-gnu glibc x86_64-linux-gnu-x32 install > PASS: compilers-x86_64-linux-gnu glibc x86_64-linux-gnu-x32 mkdir-lib > PASS: compilers-x86_64-linux-gnu glibc x86_64-linux-gnu-x32 cleanup > PASS: compilers-x86_64-linux-gnu glibc i686-linux-gnu rm > PASS: compilers-x86_64-linux-gnu glibc i686-linux-gnu mkdir > PASS: compilers-x86_64-linux-gnu glibc i686-linux-gnu configure > PASS: compilers-x86_64-linux-gnu glibc i686-linux-gnu build > PASS: compilers-x86_64-linux-gnu glibc i686-linux-gnu install > PASS: compilers-x86_64-linux-gnu glibc i686-linux-gnu mkdir-lib > PASS: compilers-x86_64-linux-gnu glibc i686-linux-gnu cleanup > PASS: compilers-x86_64-linux-gnu gcc rm > PASS: compilers-x86_64-linux-gnu gcc mkdir > PASS: compilers-x86_64-linux-gnu gcc configure > PASS: compilers-x86_64-linux-gnu gcc build > PASS: compilers-x86_64-linux-gnu gcc install > PASS: compilers-x86_64-linux-gnu gcc cleanup > PASS: compilers-x86_64-linux-gnu done > Makefile:161: warning: overriding recipe for target 'glibcs-x86_64-linux-= gnu' > Makefile:5: warning: ignoring old recipe for target 'glibcs-x86_64-linux-= gnu' > PASS: glibcs-x86_64-linux-gnu check-compilers > PASS: glibcs-x86_64-linux-gnu-isa-v3 check-compilers > PASS: glibcs-x86_64-linux-gnu-disable-multi-arch check-compilers > PASS: glibcs-x86_64-linux-gnu-isa-v2-disable-multi-arch check-compilers > PASS: glibcs-x86_64-linux-gnu-isa-v4 check-compilers > PASS: glibcs-x86_64-linux-gnu-isa-v3-disable-multi-arch check-compilers > PASS: glibcs-x86_64-linux-gnu-isa-v2 check-compilers > PASS: glibcs-x86_64-linux-gnu-minimal check-compilers > PASS: glibcs-x86_64-linux-gnu-no-pie check-compilers > PASS: glibcs-x86_64-linux-gnu-x32-no-pie check-compilers > PASS: glibcs-x86_64-linux-gnu-x32 check-compilers > PASS: glibcs-x86_64-linux-gnu-isa-v4-disable-multi-arch check-compilers > PASS: glibcs-x86_64-linux-gnu-isa-v3 rm > PASS: glibcs-x86_64-linux-gnu-disable-multi-arch rm > PASS: glibcs-x86_64-linux-gnu rm > PASS: glibcs-x86_64-linux-gnu-isa-v2-disable-multi-arch rm > PASS: glibcs-x86_64-linux-gnu-isa-v4 rm > PASS: glibcs-x86_64-linux-gnu-isa-v3-disable-multi-arch rm > PASS: glibcs-x86_64-linux-gnu-isa-v2 rm > PASS: glibcs-x86_64-linux-gnu-minimal rm > PASS: glibcs-x86_64-linux-gnu-x32-no-pie rm > PASS: glibcs-x86_64-linux-gnu-isa-v4-disable-multi-arch rm > PASS: glibcs-x86_64-linux-gnu-no-pie rm > PASS: glibcs-x86_64-linux-gnu-x32 rm > PASS: glibcs-x86_64-linux-gnu mkdir > PASS: glibcs-x86_64-linux-gnu-isa-v2-disable-multi-arch mkdir > PASS: glibcs-x86_64-linux-gnu-disable-multi-arch mkdir > PASS: glibcs-x86_64-linux-gnu-isa-v3-disable-multi-arch mkdir > PASS: glibcs-x86_64-linux-gnu-isa-v2 mkdir > PASS: glibcs-x86_64-linux-gnu-minimal mkdir > PASS: glibcs-x86_64-linux-gnu-isa-v3 mkdir > PASS: glibcs-x86_64-linux-gnu-no-pie mkdir > PASS: glibcs-x86_64-linux-gnu-x32-no-pie mkdir > PASS: glibcs-x86_64-linux-gnu-isa-v4-disable-multi-arch mkdir > PASS: glibcs-x86_64-linux-gnu-isa-v4 mkdir > PASS: glibcs-x86_64-linux-gnu-x32 mkdir > PASS: glibcs-x86_64-linux-gnu-minimal configure > PASS: glibcs-x86_64-linux-gnu-disable-multi-arch configure > PASS: glibcs-x86_64-linux-gnu configure > PASS: glibcs-x86_64-linux-gnu-x32 configure > PASS: glibcs-x86_64-linux-gnu-isa-v2 configure > PASS: glibcs-x86_64-linux-gnu-isa-v2-disable-multi-arch configure > PASS: glibcs-x86_64-linux-gnu-x32-no-pie configure > PASS: glibcs-x86_64-linux-gnu-isa-v3-disable-multi-arch configure > PASS: glibcs-x86_64-linux-gnu-isa-v3 configure > PASS: glibcs-x86_64-linux-gnu-no-pie configure > PASS: glibcs-x86_64-linux-gnu-isa-v4-disable-multi-arch configure > PASS: glibcs-x86_64-linux-gnu-isa-v4 configure > PASS: glibcs-x86_64-linux-gnu-minimal build > PASS: glibcs-x86_64-linux-gnu-disable-multi-arch build > PASS: glibcs-x86_64-linux-gnu-isa-v3-disable-multi-arch build > PASS: glibcs-x86_64-linux-gnu-isa-v2-disable-multi-arch build > PASS: glibcs-x86_64-linux-gnu-minimal install > PASS: glibcs-x86_64-linux-gnu-minimal mkdir-lib > PASS: glibcs-x86_64-linux-gnu-isa-v4-disable-multi-arch build > PASS: glibcs-x86_64-linux-gnu build > PASS: glibcs-x86_64-linux-gnu-x32-no-pie build > PASS: glibcs-x86_64-linux-gnu-isa-v2 build > PASS: glibcs-x86_64-linux-gnu-no-pie build > PASS: glibcs-x86_64-linux-gnu-isa-v4 build > PASS: glibcs-x86_64-linux-gnu-x32 build > PASS: glibcs-x86_64-linux-gnu-isa-v3 build > PASS: glibcs-x86_64-linux-gnu-disable-multi-arch install > PASS: glibcs-x86_64-linux-gnu-disable-multi-arch mkdir-lib > PASS: glibcs-x86_64-linux-gnu-isa-v3-disable-multi-arch install > PASS: glibcs-x86_64-linux-gnu-isa-v3-disable-multi-arch mkdir-lib > PASS: glibcs-x86_64-linux-gnu-isa-v2-disable-multi-arch install > PASS: glibcs-x86_64-linux-gnu-isa-v2-disable-multi-arch mkdir-lib > PASS: glibcs-x86_64-linux-gnu-isa-v4-disable-multi-arch install > PASS: glibcs-x86_64-linux-gnu-isa-v4-disable-multi-arch mkdir-lib > PASS: glibcs-x86_64-linux-gnu install > PASS: glibcs-x86_64-linux-gnu mkdir-lib > PASS: glibcs-x86_64-linux-gnu-isa-v2 install > PASS: glibcs-x86_64-linux-gnu-isa-v2 mkdir-lib > PASS: glibcs-x86_64-linux-gnu-x32-no-pie install > PASS: glibcs-x86_64-linux-gnu-x32-no-pie mkdir-lib > PASS: glibcs-x86_64-linux-gnu-no-pie install > PASS: glibcs-x86_64-linux-gnu-no-pie mkdir-lib > PASS: glibcs-x86_64-linux-gnu-isa-v3 install > PASS: glibcs-x86_64-linux-gnu-isa-v3 mkdir-lib > PASS: glibcs-x86_64-linux-gnu-isa-v4 install > PASS: glibcs-x86_64-linux-gnu-isa-v4 mkdir-lib > PASS: glibcs-x86_64-linux-gnu-x32 install > PASS: glibcs-x86_64-linux-gnu-x32 mkdir-lib > PASS: glibcs-x86_64-linux-gnu-minimal check > PASS: glibcs-x86_64-linux-gnu-minimal save-logs > PASS: glibcs-x86_64-linux-gnu-minimal cleanup > PASS: glibcs-x86_64-linux-gnu-disable-multi-arch check > PASS: glibcs-x86_64-linux-gnu-disable-multi-arch save-logs > PASS: glibcs-x86_64-linux-gnu-disable-multi-arch cleanup > PASS: glibcs-x86_64-linux-gnu-isa-v3-disable-multi-arch check > PASS: glibcs-x86_64-linux-gnu-isa-v3-disable-multi-arch save-logs > PASS: glibcs-x86_64-linux-gnu-isa-v2-disable-multi-arch check > PASS: glibcs-x86_64-linux-gnu-isa-v2-disable-multi-arch save-logs > PASS: glibcs-x86_64-linux-gnu-isa-v3-disable-multi-arch cleanup > PASS: glibcs-x86_64-linux-gnu-isa-v2-disable-multi-arch cleanup > PASS: glibcs-x86_64-linux-gnu-isa-v4-disable-multi-arch check > PASS: glibcs-x86_64-linux-gnu-isa-v4-disable-multi-arch save-logs > PASS: glibcs-x86_64-linux-gnu-isa-v4-disable-multi-arch cleanup > PASS: glibcs-x86_64-linux-gnu check > PASS: glibcs-x86_64-linux-gnu save-logs > PASS: glibcs-x86_64-linux-gnu cleanup > PASS: glibcs-x86_64-linux-gnu-isa-v2 check > PASS: glibcs-x86_64-linux-gnu-isa-v2 save-logs > PASS: glibcs-x86_64-linux-gnu-isa-v2 cleanup > PASS: glibcs-x86_64-linux-gnu-x32 check > PASS: glibcs-x86_64-linux-gnu-x32 save-logs > PASS: glibcs-x86_64-linux-gnu-x32 cleanup > PASS: glibcs-x86_64-linux-gnu-x32-no-pie check > PASS: glibcs-x86_64-linux-gnu-x32-no-pie save-logs > PASS: glibcs-x86_64-linux-gnu-x32-no-pie cleanup > PASS: glibcs-x86_64-linux-gnu-no-pie check > PASS: glibcs-x86_64-linux-gnu-no-pie save-logs > PASS: glibcs-x86_64-linux-gnu-isa-v3 check > PASS: glibcs-x86_64-linux-gnu-isa-v3 save-logs > PASS: glibcs-x86_64-linux-gnu-no-pie cleanup > PASS: glibcs-x86_64-linux-gnu-isa-v4 check > PASS: glibcs-x86_64-linux-gnu-isa-v4 save-logs > PASS: glibcs-x86_64-linux-gnu-isa-v3 cleanup > PASS: glibcs-x86_64-linux-gnu-isa-v4 cleanup > > > scripts/build-many-glibcs.py | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py > index 35b82752fa..54f9b2318c 100755 > --- a/scripts/build-many-glibcs.py > +++ b/scripts/build-many-glibcs.py > @@ -458,7 +458,22 @@ class Context(object): > {'arch': 'i486', > 'ccopts': '-m32 -march=3Di486'}, > {'arch': 'i586', > - 'ccopts': '-m32 -march=3Di586'}]) > + 'ccopts': '-m32 -march=3Di586'}, > + {'variant': 'isa-v2', > + 'ccopts': '-march=3Dx86-64-v2'}, > + {'variant': 'isa-v2-disable-multi-= arch', > + 'ccopts': '-march=3Dx86-64-v2', > + 'cfg': ['--disable-multi-arch']}, > + {'variant': 'isa-v3', > + 'ccopts': '-march=3Dx86-64-v3'}, > + {'variant': 'isa-v3-disable-multi-= arch', > + 'ccopts': '-march=3Dx86-64-v3', > + 'cfg': ['--disable-multi-arch']}, > + {'variant': 'isa-v4', > + 'ccopts': '-march=3Dx86-64-v4'}, > + {'variant': 'isa-v4-disable-multi-= arch', > + 'ccopts': '-march=3Dx86-64-v4', > + 'cfg': ['--disable-multi-arch']}]= ) > > def add_config(self, **args): > """Add an individual build configuration.""" > -- > 2.34.1 > Ping1