From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 3B2333945C38 for ; Wed, 5 Apr 2023 21:06:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3B2333945C38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-946a769ae5cso70173066b.1 for ; Wed, 05 Apr 2023 14:06:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680728766; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2YVE3RqKMypVAkyuIpy8FrmQklkuDxh1TrapYsWRKA4=; b=AHpJxpKA/pgFkzpwytpSplUA+2s2mh5yxZaVxc+S/u7AwgQXw/DVTHsQFRnlJU8FTv NASpGp8K2MO2H2fb8LCmYNAGMzWStn/Zwam4jM9gju82rjcXqxllrhc48fdYcj7yFe2v eLQVxZIf0rmy7KpuAmo/5LMct6xxRZTq6gohUvsLU/g17Wv1nVhwXiDPZ9waZv/uJJKA rySLaLs82kWgOCui0TwaY043rdmGfNXSOIuyhwLO6Wb16wbw2Jffr9fpuYkVed6OX91V CjoDjtHGIhwgjywG6pk6TXaM7CjAR1So8097Tmxylp26Upk4RjZspPe2dzkOV9hhvF67 PEBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680728766; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2YVE3RqKMypVAkyuIpy8FrmQklkuDxh1TrapYsWRKA4=; b=5cT5lglg8yfIwO0PTIsVQJUslt7TOWQkvdoEffvN63vFO80s2PqjuBWMNs3IEr2T6H S7L+s/PqwA54arOrI6ytlkqOtOUgwjVjUgLTqBwgqUFtpDj3nYEHQC4LQMg0totb3Vv+ ePJiSGePq7rGvATk4/5tsPJvc7jtbr+fT9hU0p+8yt4fHV0PN5U/daGSOjR75a95Tm1v 98sRA1pxxT4Y6XBUPuSvPvMzN45ATyIQg2nqfCaF3Bpoqu/fIUzid+1jjL0tNQJTe+Rg T6N6HcJVg35eyKQbVzdSSoS350Y+LCr/TcSJb3RXb3YJjbQMeipJMiRLOYtsHLQZ9HSQ 8nuQ== X-Gm-Message-State: AAQBX9c2a/ROsHPx8uI3Tr7kawrIH6LQEOv2szpAATNYe2C6q3vO20di IcDNnxKLAvVvf0vfvdkwaUQ8ce8pHj1Q6Xc4lKRXPNoX3vs= X-Google-Smtp-Source: AKy350asCH8bQfpnP+5F+btl3XgPuf1mYa3Xtg6AhLMZChpqdB45TDfZortKGv2t/1GC4rqS+XtMNdxInwPl1svs70g= X-Received: by 2002:a50:c049:0:b0:501:d3a2:b4b3 with SMTP id u9-20020a50c049000000b00501d3a2b4b3mr1898407edd.0.1680728765969; Wed, 05 Apr 2023 14:06:05 -0700 (PDT) MIME-Version: 1.0 References: <20230405162144.984598-1-hjl.tools@gmail.com> <20230405162144.984598-20-hjl.tools@gmail.com> In-Reply-To: <20230405162144.984598-20-hjl.tools@gmail.com> From: Noah Goldstein Date: Wed, 5 Apr 2023 16:05:54 -0500 Message-ID: Subject: Re: [PATCH 19/19] : Add PREFETCHI support To: "H.J. Lu" Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Apr 5, 2023 at 11:29=E2=80=AFAM H.J. Lu via Libc-alpha wrote: > > Add PREFETCHI support to . > --- > manual/platform.texi | 3 +++ > sysdeps/x86/bits/platform/x86.h | 1 + > sysdeps/x86/cpu-features.c | 1 + > sysdeps/x86/include/cpu-features.h | 3 +++ > sysdeps/x86/tst-get-cpu-features.c | 2 ++ > 5 files changed, 10 insertions(+) > > diff --git a/manual/platform.texi b/manual/platform.texi > index e7448ffc1a..c6ed73cb97 100644 > --- a/manual/platform.texi > +++ b/manual/platform.texi > @@ -533,6 +533,9 @@ extended state management using XSAVE/XRSTOR. > @item > @code{PREFETCHWT1} -- PREFETCHWT1 instruction. > > +@item > +@code{PREFETCHI} -- PREFETCHIT0/1 instructions. > + > @item > @code{PSE} -- Page Size Extension. > > diff --git a/sysdeps/x86/bits/platform/x86.h b/sysdeps/x86/bits/platform/= x86.h > index 96eb4c070d..6555f9b91d 100644 > --- a/sysdeps/x86/bits/platform/x86.h > +++ b/sysdeps/x86/bits/platform/x86.h > @@ -311,6 +311,7 @@ enum > x86_cpu_AVX_VNNI_INT8 =3D x86_cpu_index_7_ecx_1_edx + 4= , > x86_cpu_AVX_NE_CONVERT =3D x86_cpu_index_7_ecx_1_edx + 5, > x86_cpu_AMX_COMPLEX =3D x86_cpu_index_7_ecx_1_edx + 8, > + x86_cpu_PREFETCHI =3D x86_cpu_index_7_ecx_1_edx + 14, > > x86_cpu_index_19_ebx > =3D (CPUID_INDEX_19 * 8 * 4 * sizeof (unsigned int) > diff --git a/sysdeps/x86/cpu-features.c b/sysdeps/x86/cpu-features.c > index c2bea6a32d..5bff8ec0b4 100644 > --- a/sysdeps/x86/cpu-features.c > +++ b/sysdeps/x86/cpu-features.c > @@ -104,6 +104,7 @@ update_active (struct cpu_features *cpu_features) > CPU_FEATURE_SET_ACTIVE (cpu_features, FZLRM); > CPU_FEATURE_SET_ACTIVE (cpu_features, FSRS); > CPU_FEATURE_SET_ACTIVE (cpu_features, FSRCS); > + CPU_FEATURE_SET_ACTIVE (cpu_features, PREFETCHI); > CPU_FEATURE_SET_ACTIVE (cpu_features, PTWRITE); > > if (!CPU_FEATURES_CPU_P (cpu_features, RTM_ALWAYS_ABORT)) > diff --git a/sysdeps/x86/include/cpu-features.h b/sysdeps/x86/include/cpu= -features.h > index f14c1078d5..40b8129d6a 100644 > --- a/sysdeps/x86/include/cpu-features.h > +++ b/sysdeps/x86/include/cpu-features.h > @@ -318,6 +318,7 @@ enum > #define bit_cpu_AVX_VNNI_INT8 (1u << 4) > #define bit_cpu_AVX_NE_CONVERT (1u << 5) > #define bit_cpu_AMX_COMPLEX (1u << 8) > +#define bit_cpu_PREFETCHI (1u << 14) > > /* CPUID_INDEX_19. */ > > @@ -560,6 +561,7 @@ enum > #define index_cpu_AVX_VNNI_INT8 CPUID_INDEX_7_ECX_1 > #define index_cpu_AVX_NE_CONVERT CPUID_INDEX_7_ECX_1 > #define index_cpu_AMX_COMPLEX CPUID_INDEX_7_ECX_1 > +#define index_cpu_PREFETCHI CPUID_INDEX_7_ECX_1 > > /* CPUID_INDEX_19. */ > > @@ -804,6 +806,7 @@ enum > #define reg_AVX_VNNI_INT8 edx > #define reg_AVX_NE_CONVERT edx > #define reg_AMX_COMPLEX edx > +#define reg_PREFETCHI edx > > /* CPUID_INDEX_19. */ > > diff --git a/sysdeps/x86/tst-get-cpu-features.c b/sysdeps/x86/tst-get-cpu= -features.c > index 87fe27340f..1bd7e0be53 100644 > --- a/sysdeps/x86/tst-get-cpu-features.c > +++ b/sysdeps/x86/tst-get-cpu-features.c > @@ -218,6 +218,7 @@ do_test (void) > CHECK_CPU_FEATURE_PRESENT (AVX_VNNI_INT8); > CHECK_CPU_FEATURE_PRESENT (AVX_NE_CONVERT); > CHECK_CPU_FEATURE_PRESENT (AMX_COMPLEX); > + CHECK_CPU_FEATURE_PRESENT (PREFETCHI); > CHECK_CPU_FEATURE_PRESENT (AESKLE); > CHECK_CPU_FEATURE_PRESENT (WIDE_KL); > CHECK_CPU_FEATURE_PRESENT (PTWRITE); > @@ -388,6 +389,7 @@ do_test (void) > CHECK_CPU_FEATURE_ACTIVE (AVX_VNNI_INT8); > CHECK_CPU_FEATURE_ACTIVE (AVX_NE_CONVERT); > CHECK_CPU_FEATURE_ACTIVE (AMX_COMPLEX); > + CHECK_CPU_FEATURE_ACTIVE (PREFETCHI); > CHECK_CPU_FEATURE_ACTIVE (AESKLE); > CHECK_CPU_FEATURE_ACTIVE (WIDE_KL); > CHECK_CPU_FEATURE_ACTIVE (PTWRITE); > -- > 2.39.2 > LGTM Reviewed-by: Noah Goldstein