From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by sourceware.org (Postfix) with ESMTPS id D5684385842F for ; Thu, 30 Jun 2022 20:13:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D5684385842F Received: by mail-yb1-xb29.google.com with SMTP id x184so319776ybg.12 for ; Thu, 30 Jun 2022 13:13:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4HLHSdDodHPjJI5AVmnkEcL41IF++piBEAE1IF9cZyk=; b=3PyaZGtfHwb9A3XWWGS1ex0rcIrk9ETqQ79B4xIBva9dqGQgba/B40UyvbjLbZXA8x w2+wGx4V0OhtumshJpvrKZJavMsmIZx3av7kxpOYryOJHKyZ1l1d4UfkY7eNrlFM2bOm xAfAY2rywwkiwj9RWi3MDdZMSQbrwNVUJ9a2pze904XvDHAzbxFmYknykgnBn5p/ggCZ hz03FTNO+CXR3+ld6pxP912UD82yJ4GLumRwj+P96BZAQv/h0BlYw0Bmmbc36O3DKqyp lmz26cLG9I6GCmGwBqzryF/Ll4sL30vuGeXPc9+6Qp0gWddLuorZy6xRTlgfRIZKbzDb 5CWQ== X-Gm-Message-State: AJIora8bQOuXffb/TT7GyBtJnSWq9vX4uoLQJIVZD85YMugQoo0hGx5i TxPfJPDdb9P4lWsLBIlOqso3I7OPBpKYgbff0xwMjrA9/bU= X-Google-Smtp-Source: AGRyM1sUOtM/d/634Ii/U6ospwWh0/LHuVpB60VfdXLAkByzbgBbxR4gre5kMLuYYJuBvUZtNp2FCH/6jGOawZd1LSE= X-Received: by 2002:a25:b9c3:0:b0:668:a418:13c with SMTP id y3-20020a25b9c3000000b00668a418013cmr11645051ybj.498.1656620036188; Thu, 30 Jun 2022 13:13:56 -0700 (PDT) MIME-Version: 1.0 References: <20220628152717.17838-1-goldstein.w.n@gmail.com> <20220630034432.3749620-1-goldstein.w.n@gmail.com> In-Reply-To: From: Noah Goldstein Date: Thu, 30 Jun 2022 13:13:45 -0700 Message-ID: Subject: Re: [PATCH v6 1/2] x86: Add comment explaining no Slow_SSE4_2 check in ifunc-sse4_2 To: Andreas Schwab Cc: Noah Goldstein via Libc-alpha Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2022 20:13:57 -0000 On Thu, Jun 30, 2022 at 12:47 AM Andreas Schwab wrote: > > On Jun 29 2022, Noah Goldstein via Libc-alpha wrote: > > > diff --git a/sysdeps/x86_64/multiarch/ifunc-sse4_2.h b/sysdeps/x86_64/multiarch/ifunc-sse4_2.h > > index ee36525bcf..4eb9cca7f0 100644 > > --- a/sysdeps/x86_64/multiarch/ifunc-sse4_2.h > > +++ b/sysdeps/x86_64/multiarch/ifunc-sse4_2.h > > @@ -27,6 +27,10 @@ IFUNC_SELECTOR (void) > > { > > const struct cpu_features* cpu_features = __get_cpu_features (); > > > > + /* This function uses slow sse4.2 instructions (pcmpstri) but since > > + there is no other optimized implementation keep using. If an > > I think there is something missing at the end of the sentence. Fixed in V6. > > -- > Andreas Schwab, SUSE Labs, schwab@suse.de > GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 > "And now for something completely different."