From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) by sourceware.org (Postfix) with ESMTPS id BECCC3857811 for ; Thu, 14 Apr 2022 00:00:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BECCC3857811 Received: by mail-yb1-xb34.google.com with SMTP id m132so6626460ybm.4 for ; Wed, 13 Apr 2022 17:00:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WEZkmaMP3ovAssyNrfs+6qpbptA3GtTWfEE/Q0Bukns=; b=VdZTAZnqh8ixRxMxN4ssnb4ugubjy9LihYGVUKgw6Gfoejy3rQ+I9QM+YWiVwjt7V+ ka3wFr9QwqCAdVFCgRVBf3ta6uUWrmvArkilhUDvMnBWXpd9dBiuwTEoAb20qfrEEOv3 +I9xwSbNkh69qgdz63jv44FHpPKTwm28IpA43Y+HPNIjWNDUzX0HKPON5e2yDYaHS6VK 1CyJ0Zcd+q6uMMqZGs5gkJT+uImjdAIdMqwnhSpuYm7LzsYJDlH/4l2z2rH6TzksU2+2 5PLZ+8Px/ZALhAX6jD88jshTk47kKU5iLoCy2QilvyuAZfU9Ds33pj5p0gUFrPQTN3BB dKQA== X-Gm-Message-State: AOAM533GyjohOpy5xqjMOOWDrHWrY34djYp7KVVTFfkuTufc4WPPSRHQ W2IcV0NV5qw/4v4VTxIkX2ElK8QUwPTDfoNhEJRVlg8E X-Google-Smtp-Source: ABdhPJzZSYuiL9Kl1f+IIfBd71j+cRQMI9PL0+tWPVj0DLpznjV/OsF3Ov7IQwOFUD2ftJ25cfPJfF5vxrFJTy4jOp4= X-Received: by 2002:a25:7544:0:b0:629:33a2:b142 with SMTP id q65-20020a257544000000b0062933a2b142mr20429ybc.136.1649894444185; Wed, 13 Apr 2022 17:00:44 -0700 (PDT) MIME-Version: 1.0 References: <20220411165835.4028009-1-goldstein.w.n@gmail.com> <9a1dd0bc-57cc-0fa7-0d61-1b9cbae247a0@cs.ucla.edu> <92b7db75-0536-d28b-0618-34519305223b@cs.ucla.edu> <56ae0132-0509-31a9-a003-29c752575332@cs.ucla.edu> <5e6e21de-b437-35fd-7f5a-d08400f93e1e@cs.ucla.edu> In-Reply-To: <5e6e21de-b437-35fd-7f5a-d08400f93e1e@cs.ucla.edu> From: Noah Goldstein Date: Wed, 13 Apr 2022 19:00:33 -0500 Message-ID: Subject: Re: [PATCH v1] Replace {u}int_fast{16|32} with {u}int32_t To: Paul Eggert Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Apr 2022 00:00:47 -0000 On Wed, Apr 13, 2022 at 6:38 PM Paul Eggert wrote: > > On 4/13/22 16:28, Noah Goldstein wrote: > > he reason not replacing fast32 with int is int can be 2-bytes so it can > > be incorrect. > > No, int cannot be 2 8-bit bytes in GNU code. GNU code can assume that > int is at least 32 bits. See the first paragraph of: > > https://www.gnu.org/prep/standards/html_node/CPU-Portability.html > > Similarly, POSIX code can assume that int is at least 32 bits; look for > "INT_MIN" and "INT_MAX" in: > > https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/limits.h.html Okay, fixed in v5 to use int/unsigned int unless it very obviously went against the style of the function.