From: Noah Goldstein <goldstein.w.n@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
Florian Weimer <fweimer@redhat.com>,
Oleh Derevenko <oleh.derevenko@gmail.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Andreas Schwab <schwab@linux-m68k.org>,
"Paul A . Clarke" <pc@us.ibm.com>
Subject: Re: [PATCH v6 1/4] Add LLL_MUTEX_READ_LOCK [BZ #28537]
Date: Wed, 17 Nov 2021 18:03:35 -0600 [thread overview]
Message-ID: <CAFUsyf+Yf=QM-0Zj31=k6fANCdXa6XnzVn=Kj6im3xDYbanbnA@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOqOv3WC9rWwtFyzc7rJFDDbNTAfTio-FZC4oW5y751FWA@mail.gmail.com>
On Wed, Nov 17, 2021 at 5:55 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Tue, Nov 16, 2021 at 6:24 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > On Thu, Nov 11, 2021 at 10:24 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> > >
> > > CAS instruction is expensive. From the x86 CPU's point of view, getting
> > > a cache line for writing is more expensive than reading. See Appendix
> > > A.2 Spinlock in:
> > >
> > > https://www.intel.com/content/dam/www/public/us/en/documents/white-papers/xeon-lock-scaling-analysis-paper.pdf
> > >
> > > The full compare and swap will grab the cache line exclusive and cause
> > > excessive cache line bouncing.
> > >
> > > Add LLL_MUTEX_READ_LOCK to do an atomic load and skip CAS in spinlock
> > > loop if compare may fail to reduce cache line bouncing on contended locks.
> > > ---
> > > nptl/pthread_mutex_lock.c | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/nptl/pthread_mutex_lock.c b/nptl/pthread_mutex_lock.c
> > > index 2bd41767e0..72058c719c 100644
> > > --- a/nptl/pthread_mutex_lock.c
> > > +++ b/nptl/pthread_mutex_lock.c
> > > @@ -64,6 +64,11 @@ lll_mutex_lock_optimized (pthread_mutex_t *mutex)
> > > # define PTHREAD_MUTEX_VERSIONS 1
> > > #endif
> > >
> > > +#ifndef LLL_MUTEX_READ_LOCK
> > > +# define LLL_MUTEX_READ_LOCK(mutex) \
> > > + atomic_load_relaxed (&(mutex)->__data.__lock)
> > > +#endif
> > > +
> > > static int __pthread_mutex_lock_full (pthread_mutex_t *mutex)
> > > __attribute_noinline__;
> > >
> > > @@ -141,6 +146,8 @@ PTHREAD_MUTEX_LOCK (pthread_mutex_t *mutex)
> > > break;
> > > }
> > > atomic_spin_nop ();
> > > + if (LLL_MUTEX_READ_LOCK (mutex) != 0)
> > > + continue;
> >
> > Now that the lock spins on a simple read should `max_cnt` be adjusted?
>
> Adding LLL_MUTEX_READ_LOCK just avoids the more expensive
> LLL_MUTEX_TRYLOCK. It doesn't change the flow.
Yes, but the loop will be able to run `max_cnt` iterations much faster now.
Just wondering if the value needs to be re-tuned. Not that is necessarily needs
to be.
>
> > https://sourceware.org/git/?p=glibc.git;a=blob;f=nptl/pthread_mutex_lock.c;h=762059b230ba97140d6ca16c7273b489592dd3bc;hb=d672a98a1af106bd68deb15576710cd61363f7a6#l143
> > > }
> > > while (LLL_MUTEX_TRYLOCK (mutex) != 0);
> > >
> > > --
> > > 2.33.1
> > >
>
>
>
> --
> H.J.
next prev parent reply other threads:[~2021-11-18 0:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 16:24 [PATCH v6 0/4] Optimize CAS " H.J. Lu
2021-11-11 16:24 ` [PATCH v6 1/4] Add LLL_MUTEX_READ_LOCK " H.J. Lu
2021-11-12 17:23 ` Szabolcs Nagy
2021-11-17 2:24 ` Noah Goldstein
2021-11-17 23:54 ` H.J. Lu
2021-11-18 0:03 ` Noah Goldstein [this message]
2021-11-18 0:31 ` H.J. Lu
2021-11-18 1:16 ` Arjan van de Ven
2022-09-11 20:19 ` Sunil Pandey
2022-09-29 0:10 ` Noah Goldstein
2021-11-11 16:24 ` [PATCH v6 2/4] Avoid extra load with CAS in __pthread_mutex_lock_full " H.J. Lu
2021-11-12 16:31 ` Szabolcs Nagy
2021-11-12 18:50 ` Andreas Schwab
2022-09-11 20:16 ` Sunil Pandey
2022-09-29 0:10 ` Noah Goldstein
2021-11-11 16:24 ` [PATCH v6 3/4] Reduce CAS in malloc spinlocks H.J. Lu
2023-02-23 5:48 ` DJ Delorie
2021-11-11 16:24 ` [PATCH v6 4/4] Avoid extra load with CAS in __pthread_mutex_clocklock_common [BZ #28537] H.J. Lu
2021-11-12 16:32 ` Szabolcs Nagy
2021-11-12 18:51 ` Andreas Schwab
2022-09-11 20:12 ` Sunil Pandey
2022-09-11 20:15 ` Arjan van de Ven
2022-09-11 21:26 ` Florian Weimer
2022-09-29 0:09 ` Noah Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFUsyf+Yf=QM-0Zj31=k6fANCdXa6XnzVn=Kj6im3xDYbanbnA@mail.gmail.com' \
--to=goldstein.w.n@gmail.com \
--cc=arjan@linux.intel.com \
--cc=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=oleh.derevenko@gmail.com \
--cc=pc@us.ibm.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).