From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by sourceware.org (Postfix) with ESMTPS id 9BC9E3858D37 for ; Wed, 28 Sep 2022 20:42:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9BC9E3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x535.google.com with SMTP id a13so3682240edj.0 for ; Wed, 28 Sep 2022 13:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=Gpi8vfiLUy3bNAQj6mHdH+wi9T5cJ+Unp/Mayl4Ov5Q=; b=hUD7ZQk5w+eWb9Px/9JG/nJ9oLY/qWxbj58kgQ8SMhzTcf9lrcnESf84raBqYzKo06 M5y/jadqZ3VkEfXL8BBuHywBDRXZP+97xaT6oVi7gEKlNerSN0vB3X5m9TOw68daqb8H YiIZWrWOGq6lmrY5ZWoxMm7nyZpmHtADNwAqgl8DVNEsf0916jyCsXWrx5oeWyoksIQJ aqmHpA1tGEU/0h66t2EzwCFdIfEbymKPnnN0QLLOk7E9Y/cR0Sy61WQ/ZG5gm/A+lTqV Vpzdl70DPGo0r2GvNGp2r1T7AxSvk7LXYBl27LF47wIOyGD21d7e4jwuGfKH/ovFleUf E/lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=Gpi8vfiLUy3bNAQj6mHdH+wi9T5cJ+Unp/Mayl4Ov5Q=; b=dkDuZTdUgIqGVPjfWmPb/hFfLPNuhOwj9td9pRAN+CoyDv7x3AdVxr0X02xepxiDSf Fw+txfc9DpCpR0m3VUWhU5WFn5lgoebBuIeRkawx3LetKaNtBZ2Tl6No0uyJV3miXXTH U25fP0XFapcGJp0DnsxHxM51+Xt52z8dgf+JgL5NlG9OpMRWa9LM8NYNL2hwxPIJBYmB Hx+Od/eWrMi8I99O5v2NotTKZ5fZEBsg2Jv0OIkhdWoP2FSikDjxORxaCVUnR15kArpp iiuPoFcVlOHfBD72poaIci+W5L34T0aXpIR7MsDDzNA5gwTYBj9KtPmQnCqe632A6G4O rKYg== X-Gm-Message-State: ACrzQf3DbFxI1+nJto38euXGTP/Sv8S/qsP7hZKlrWRlqMGaH5yGxdYp VsJrmMPb8babkASGHaZLR2z1xH/xCRPTsQ/NsKNGZY6O X-Google-Smtp-Source: AMsMyM5wxbCz9DYC2LVdpLDZIKUyVOTCDeSFxQq5yLq+NohxG2ckUgtkjKBOlFI/nNwY+yUGP2O1a+jM9LFZTmwxQfA= X-Received: by 2002:a05:6402:43cc:b0:451:129e:1b1e with SMTP id p12-20020a05640243cc00b00451129e1b1emr35317907edc.258.1664397726475; Wed, 28 Sep 2022 13:42:06 -0700 (PDT) MIME-Version: 1.0 References: <20220928192012.2143620-1-goldstein.w.n@gmail.com> In-Reply-To: From: Noah Goldstein Date: Wed, 28 Sep 2022 13:41:55 -0700 Message-ID: Subject: Re: [PATCH v1] Benchtest: Add additional benchmarks for strlen and strnlen To: Sunil Pandey Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Sep 28, 2022 at 12:27 PM Sunil Pandey wrote: > > On Wed, Sep 28, 2022 at 12:20 PM Noah Goldstein via Libc-alpha > wrote: > > > > Current benchmarks are missing many cases in the mid-length range > > which is often the hottest size range. > > How do you know if the mid-length range is the hottest size range? > Can you please share data to back your claim. Its moreso mid/small, just we are missing mid range. > > > --- > > benchtests/bench-strlen.c | 33 ++++++++++++++++++++--- > > benchtests/bench-strnlen.c | 55 +++++++++++++++++++++++++++++++++++--- > > 2 files changed, 81 insertions(+), 7 deletions(-) > > > > diff --git a/benchtests/bench-strlen.c b/benchtests/bench-strlen.c > > index 602e52ee83..696e4541d7 100644 > > --- a/benchtests/bench-strlen.c > > +++ b/benchtests/bench-strlen.c > > @@ -128,10 +128,10 @@ test_main (void) > > /* Checking with only 4 * N alignments for wcslen, other alignments are wrong for wchar_t type arrays*/ > > > > for (i = 1; i < 8; ++i) > > - { > > - do_test (&json_ctx, sizeof (CHAR) * i, i); > > - do_test (&json_ctx, 0, i); > > - } > > + { > > + do_test (&json_ctx, sizeof (CHAR) * i, i); > > + do_test (&json_ctx, 0, i); > > + } > > > > for (i = 2; i <= 12; ++i) > > { > > @@ -141,6 +141,31 @@ test_main (void) > > do_test (&json_ctx, sizeof (CHAR) * i, (size_t)((1 << i) / 1.5)); > > } > > > > + for (i = 0; i < 512; i += 32) > > + { > > + do_test (&json_ctx, 0, i / sizeof (CHAR)); > > + } > > + > > + for (i = 512; i < 1024; i += 64) > > + { > > + do_test (&json_ctx, 0, i / sizeof (CHAR)); > > + } > > + > > + for (i = 1024; i < 2048; i += 128) > > + { > > + do_test (&json_ctx, 0, i / sizeof (CHAR)); > > + } > > + > > + for (i = 2048; i < 4096; i += 256) > > + { > > + do_test (&json_ctx, 0, i / sizeof (CHAR)); > > + } > > + > > + for (i = 4096; i < 8192; i += 512) > > + { > > + do_test (&json_ctx, 0, i / sizeof (CHAR)); > > + } > > + > > json_array_end (&json_ctx); > > json_attr_object_end (&json_ctx); > > json_attr_object_end (&json_ctx); > > diff --git a/benchtests/bench-strnlen.c b/benchtests/bench-strnlen.c > > index 2cd561dfd5..13b46b3f57 100644 > > --- a/benchtests/bench-strnlen.c > > +++ b/benchtests/bench-strnlen.c > > @@ -63,6 +63,11 @@ do_one_test (json_ctx_t *json_ctx, impl_t *impl, const CHAR *s, size_t maxlen, > > ret = 1; > > return; > > } > > + /* Warmup. */ > > + for (i = 0; i < iters / 16; ++i) > > + { > > + CALL (impl, s, maxlen); > > + } > > > > TIMING_NOW (start); > > for (i = 0; i < iters; ++i) > > @@ -110,7 +115,7 @@ do_test (json_ctx_t *json_ctx, size_t align, size_t len, size_t maxlen, > > int > > test_main (void) > > { > > - size_t i; > > + size_t i, j; > > json_ctx_t json_ctx; > > > > test_init (); > > @@ -131,6 +136,19 @@ test_main (void) > > > > json_array_begin (&json_ctx, "results"); > > > > + for (i = 0; i <= 1; ++i) > > + { > > + do_test (&json_ctx, i, 1, 128, MIDDLE_CHAR); > > + do_test (&json_ctx, i, 128, 1, MIDDLE_CHAR); > > + do_test (&json_ctx, i, 1, 2, MIDDLE_CHAR); > > + do_test (&json_ctx, i, 2, 1, MIDDLE_CHAR); > > + > > + do_test (&json_ctx, 32 + i, 1, 128, MIDDLE_CHAR); > > + do_test (&json_ctx, 32 + i, 128, 1, MIDDLE_CHAR); > > + do_test (&json_ctx, 32 + i, 1, 2, MIDDLE_CHAR); > > + do_test (&json_ctx, 32 + i, 2, 1, MIDDLE_CHAR); > > + } > > + > > for (i = 1; i < 8; ++i) > > { > > do_test (&json_ctx, 0, i, i - 1, MIDDLE_CHAR); > > @@ -149,18 +167,49 @@ test_main (void) > > { > > do_test (&json_ctx, 0, 1 << i, 5000, MIDDLE_CHAR); > > do_test (&json_ctx, 1, 1 << i, 5000, MIDDLE_CHAR); > > + do_test (&json_ctx, 0, 5000, 1 << i, MIDDLE_CHAR); > > + do_test (&json_ctx, 1, 5000, 1 << i, MIDDLE_CHAR); > > } > > > > for (i = 1; i < 8; ++i) > > - do_test (&json_ctx, 0, i, 5000, BIG_CHAR); > > + { > > + do_test (&json_ctx, 0, i, 5000, BIG_CHAR); > > + do_test (&json_ctx, 0, 5000, i, BIG_CHAR); > > + } > > > > for (i = 1; i < 8; ++i) > > - do_test (&json_ctx, i, i, 5000, BIG_CHAR); > > + { > > + do_test (&json_ctx, i, i, 5000, BIG_CHAR); > > + do_test (&json_ctx, i, 5000, i, BIG_CHAR); > > + } > > > > for (i = 2; i <= 10; ++i) > > { > > do_test (&json_ctx, 0, 1 << i, 5000, BIG_CHAR); > > do_test (&json_ctx, 1, 1 << i, 5000, BIG_CHAR); > > + do_test (&json_ctx, 0, 5000, 1 << i, BIG_CHAR); > > + do_test (&json_ctx, 1, 5000, 1 << i, BIG_CHAR); > > + } > > + > > + for (i = (16 / sizeof (CHAR)); i <= (8192 / sizeof (CHAR)); i += i) > > + { > > + for (j = 0; j <= (704 / sizeof (CHAR)); j += (32 / sizeof (CHAR))) > > + { > > + do_test (&json_ctx, 0, 1 << i, (i + j), BIG_CHAR); > > + do_test (&json_ctx, 0, i + j, i, BIG_CHAR); > > + > > + do_test (&json_ctx, 64, 1 << i, (i + j), BIG_CHAR); > > + do_test (&json_ctx, 64, i + j, i, BIG_CHAR); > > + > > + if (j < i) > > + { > > + do_test (&json_ctx, 0, 1 << i, i - j, BIG_CHAR); > > + do_test (&json_ctx, 0, i - j, i, BIG_CHAR); > > + > > + do_test (&json_ctx, 64, 1 << i, i - j, BIG_CHAR); > > + do_test (&json_ctx, 64, i - j, i, BIG_CHAR); > > + } > > + } > > } > > > > json_array_end (&json_ctx); > > -- > > 2.34.1 > >