Re: [PATCH v1 1/3] x86: Add definition for __wmemset_chk AVX2 RTM in ifunc impl list

[Noah Goldstein <goldstein.w.n@gmail.com>]

On Wed, Jun 29, 2022 at 12:22 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Tue, Jun 28, 2022 at 8:27 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > This was simply missing and meant we weren't testing it properly.
> > ---
> >  sysdeps/x86_64/multiarch/ifunc-impl-list.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/sysdeps/x86_64/multiarch/ifunc-impl-list.c b/sysdeps/x86_64/multiarch/ifunc-impl-list.c
> > index 251b0022d9..3ae4d49bee 100644
> > --- a/sysdeps/x86_64/multiarch/ifunc-impl-list.c
> > +++ b/sysdeps/x86_64/multiarch/ifunc-impl-list.c
> > @@ -1028,6 +1028,10 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
> >               IFUNC_IMPL_ADD (array, i, __wmemset_chk,
> >                               CPU_FEATURE_USABLE (AVX2),
> >                               __wmemset_chk_avx2_unaligned)
> > +             IFUNC_IMPL_ADD (array, i, wmemset_chk,
This wasn't __wmemset_chk
> > +                             (CPU_FEATURE_USABLE (AVX2)
> > +                              && CPU_FEATURE_USABLE (RTM)),
> > +                             __wmemset_chk_avx2_unaligned_rtm)
> >               IFUNC_IMPL_ADD (array, i, __wmemset_chk,
> >                               (CPU_FEATURE_USABLE (AVX512VL)
> >                                && CPU_FEATURE_USABLE (AVX512BW)
> > --
> > 2.34.1
> >
>
> LGTM.
>
> Thanks.
>

There was an issue with this patch standalone.

Fixed in V3.
> --
> H.J.