From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <goldstein.w.n@gmail.com>
Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com
 [IPv6:2607:f8b0:4864:20::1131])
 by sourceware.org (Postfix) with ESMTPS id C76F538485A1
 for <libc-alpha@sourceware.org>; Wed, 29 Jun 2022 23:09:00 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C76F538485A1
Received: by mail-yw1-x1131.google.com with SMTP id
 00721157ae682-3177f4ce3e2so163082127b3.5
 for <libc-alpha@sourceware.org>; Wed, 29 Jun 2022 16:09:00 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=uqxTKHn2CUXhIqFkB6uV02Sd+s7JtxdiCp7nPwKoj6Y=;
 b=Wj3FXBsJBTeN1F9Tl6djWb7K3KPK0kQuK3Jq0BvrWigvpCc2c01tt4pDhx7M8oTKa7
 4es2WM7nMG9IuXN+Oi4q3u0BzUR7bxL8dG19CVq+Kb4PrO+USOSMVXZ4jksS/Hid41rh
 mtcXkjBhs4bUrBT/Bcg3R7+PzWt/Z1BhmmhuClJec42ABRsocAUZGldrmu1oHDDJXBEj
 s9g9f5WW59nycVeeXvgXnIYUEMrnEL/nN8vMDL/62f08Kz5sjWP8ct5OGCRUE8DOcJ3s
 DY7HlXhZ0U3XSNPLMCXS1rLRZJHoIpDh5wKtjjgZG76xYAe0KVTA9g12ZxJLvd9tu4c2
 n5PQ==
X-Gm-Message-State: AJIora98YhmnZbVkxvWUT7QvDENlCvsvCuK6G4O1LKIUG2GMAmFrI/hC
 auFhmHEfshFVnmLmaGSoERG6psHMkek+s3avHBVjkck2aAU=
X-Google-Smtp-Source: AGRyM1tl4QG+YPg3uxjaXR9G0boKN+YMhnGN8JViw/gqXFxnJnha5xD3hDGAq0wSSrYlCFIeDDaLGj2D2BRyrjKTPf8=
X-Received: by 2002:a81:72c5:0:b0:318:27ef:702c with SMTP id
 n188-20020a8172c5000000b0031827ef702cmr6946985ywc.294.1656544140136; Wed, 29
 Jun 2022 16:09:00 -0700 (PDT)
MIME-Version: 1.0
References: <20220628152735.17863-1-goldstein.w.n@gmail.com>
 <CAMe9rOpyb8t8SXvg=qxEU0hDgjHxPZDYMHSMX6zTviUNAw0rqw@mail.gmail.com>
In-Reply-To: <CAMe9rOpyb8t8SXvg=qxEU0hDgjHxPZDYMHSMX6zTviUNAw0rqw@mail.gmail.com>
From: Noah Goldstein <goldstein.w.n@gmail.com>
Date: Wed, 29 Jun 2022 16:08:49 -0700
Message-ID: <CAFUsyf+r0J_mykF4k0YW_WAo3WWC05mwykZDrSg_8AAjhGK3Tw@mail.gmail.com>
Subject: Re: [PATCH v1 1/3] x86: Add definition for __wmemset_chk AVX2 RTM in
 ifunc impl list
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
 "Carlos O'Donell" <carlos@systemhalted.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jun 2022 23:09:02 -0000

On Wed, Jun 29, 2022 at 12:22 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Tue, Jun 28, 2022 at 8:27 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > This was simply missing and meant we weren't testing it properly.
> > ---
> >  sysdeps/x86_64/multiarch/ifunc-impl-list.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/sysdeps/x86_64/multiarch/ifunc-impl-list.c b/sysdeps/x86_64/multiarch/ifunc-impl-list.c
> > index 251b0022d9..3ae4d49bee 100644
> > --- a/sysdeps/x86_64/multiarch/ifunc-impl-list.c
> > +++ b/sysdeps/x86_64/multiarch/ifunc-impl-list.c
> > @@ -1028,6 +1028,10 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
> >               IFUNC_IMPL_ADD (array, i, __wmemset_chk,
> >                               CPU_FEATURE_USABLE (AVX2),
> >                               __wmemset_chk_avx2_unaligned)
> > +             IFUNC_IMPL_ADD (array, i, wmemset_chk,
This wasn't __wmemset_chk
> > +                             (CPU_FEATURE_USABLE (AVX2)
> > +                              && CPU_FEATURE_USABLE (RTM)),
> > +                             __wmemset_chk_avx2_unaligned_rtm)
> >               IFUNC_IMPL_ADD (array, i, __wmemset_chk,
> >                               (CPU_FEATURE_USABLE (AVX512VL)
> >                                && CPU_FEATURE_USABLE (AVX512BW)
> > --
> > 2.34.1
> >
>
> LGTM.
>
> Thanks.
>

There was an issue with this patch standalone.

Fixed in V3.
> --
> H.J.