From: Noah Goldstein <goldstein.w.n@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: Noah Goldstein via Libc-alpha <libc-alpha@sourceware.org>,
Sunil K Pandey <skpgkp2@gmail.com>,
andrey.kolesov@intel.com
Subject: Re: [PATCH v3 1/1] x86-64: Add vector acos/acosf implementation to libmvec
Date: Wed, 15 Dec 2021 14:32:38 -0600 [thread overview]
Message-ID: <CAFUsyfJ+sURnik75vJ5XXpS9FwZruoH4yNOECg6=eH3qH1uASg@mail.gmail.com> (raw)
In-Reply-To: <87sfutpro5.fsf@oldenburg.str.redhat.com>
On Wed, Dec 15, 2021 at 1:57 PM Florian Weimer <fweimer@redhat.com> wrote:
>
> * Noah Goldstein via Libc-alpha:
>
> > Is there a control flow from L(SPECIAL_VALUES_BRANCH) that doesn't go to exit?
> > If not I think alot of the save/restores are pretty unnecissary.
>
> It depends on the vector calling convention. It seems to be different
> from the regular psABI calling convention, even for GPRs.
Unless I'm missing something this isn't a function (nor globally
visible). It's internal
and just about everything that is saved/restored has already been clobbered by
acos/acosf.
The save/restore is for restoring state internal to acos/acosf. Think
that the amount
of state that is being preserved is unnecessarily large.
>
> Thanks,
> Florian
>
next prev parent reply other threads:[~2021-12-15 20:32 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 19:37 [PATCH 00/42] x86-64: Add vector math functions " Sunil K Pandey
2021-11-24 19:37 ` [PATCH 01/42] x86-64: Add vector acos/acosf implementation " Sunil K Pandey
[not found] ` <CAFUsyfKpKz3=q_4JQUGOkUkUDpDUEEr_F9RpnoxJMgmwHfTfjw@mail.gmail.com>
[not found] ` <CAFUsyfJqPKwjB0oWDC8Ce8AacyC4wU6JHWeeXASQe-3dGJS9Og@mail.gmail.com>
2021-12-09 2:10 ` Sunil Pandey
2021-12-09 18:34 ` Joseph Myers
2021-11-24 19:37 ` [PATCH 02/42] x86-64: Add vector acos/acosf to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:37 ` [PATCH 03/42] x86-64: Add vector acosh/acoshf implementation to libmvec Sunil K Pandey
2021-11-24 19:37 ` [PATCH 04/42] x86-64: Add vector acosh/acoshf to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:37 ` [PATCH 05/42] x86-64: Add vector asin/asinf implementation to libmvec Sunil K Pandey
2021-11-24 22:51 ` Joseph Myers
2021-11-29 20:56 ` Sunil Pandey
2021-12-09 1:08 ` Sunil Pandey
2021-12-09 3:38 ` Noah Goldstein
2021-12-09 18:38 ` Joseph Myers
2021-12-15 18:54 ` [PATCH v3 0/1] Add vector math function acos/acosf " Sunil K Pandey
2021-12-15 18:54 ` [PATCH v3 1/1] x86-64: Add vector acos/acosf implementation " Sunil K Pandey
2021-12-15 19:43 ` Noah Goldstein
2021-12-15 19:57 ` Florian Weimer
2021-12-15 20:32 ` Noah Goldstein [this message]
2021-12-15 22:26 ` Sunil Pandey
2021-12-16 0:12 ` [PATCH v4 0/1] Add vector math function acos/acosf " Sunil K Pandey
2021-12-16 0:12 ` [PATCH v4 1/1] x86-64: Add vector acos/acosf implementation " Sunil K Pandey
2021-12-16 0:56 ` Noah Goldstein
2021-12-19 17:11 ` Sunil Pandey
2021-12-19 17:18 ` [PATCH v5 0/1] Add vector math function acos/acosf " Sunil K Pandey
2021-12-19 17:18 ` [PATCH v5 1/1] x86-64: Add vector acos/acosf implementation " Sunil K Pandey
2021-12-19 18:29 ` Noah Goldstein
2021-12-19 20:26 ` H.J. Lu
2021-12-19 20:42 ` Noah Goldstein
2021-12-20 16:08 ` Sunil Pandey
2021-12-20 19:20 ` Noah Goldstein
2021-12-20 19:36 ` Noah Goldstein
2021-12-20 20:30 ` Sunil Pandey
2021-12-21 5:40 ` [PATCH v6 0/1] Add vector math function acos/acosf " Sunil K Pandey
2021-12-21 5:40 ` [PATCH v6 1/1] x86-64: Add vector acos/acosf implementation " Sunil K Pandey
2021-12-21 6:44 ` [PATCH v6 0/1] Add vector math function acos/acosf " Noah Goldstein
2021-12-22 0:15 ` H.J. Lu
2021-12-22 16:23 ` [PATCH v7 " Sunil K Pandey
2021-12-22 16:23 ` [PATCH v7 1/1] x86-64: Add vector acos/acosf implementation " Sunil K Pandey
2021-12-22 20:51 ` H.J. Lu
2021-12-16 19:14 ` [PATCH v4 " Joseph Myers
2021-12-16 21:07 ` Sunil Pandey
2021-12-16 19:18 ` [PATCH v4 0/1] Add vector math function acos/acosf " Joseph Myers
2021-12-16 21:13 ` Adhemerval Zanella
2021-12-19 20:34 ` H.J. Lu
2021-12-20 19:10 ` Adhemerval Zanella
2021-12-20 19:55 ` H.J. Lu
2021-12-20 21:41 ` Joseph Myers
2021-12-20 22:07 ` Cornea, Marius
2021-12-20 22:19 ` Joseph Myers
2021-12-20 22:42 ` Cornea, Marius
2021-12-20 22:57 ` Joseph Myers
2021-12-20 23:11 ` Noah Goldstein
2021-12-20 23:58 ` H.J. Lu
2021-12-15 19:06 ` [PATCH 05/42] x86-64: Add vector asin/asinf implementation " Adhemerval Zanella
2021-11-24 19:37 ` [PATCH 06/42] x86-64: Add vector asin/asinf to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:37 ` [PATCH 07/42] x86-64: Add vector asinh/asinhf implementation to libmvec Sunil K Pandey
2021-11-24 19:37 ` [PATCH 08/42] x86-64: Add vector asinh/asinhf to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:37 ` [PATCH 09/42] x86-64: Add vector atan/atanf implementation to libmvec Sunil K Pandey
2021-11-24 19:37 ` [PATCH 10/42] x86-64: Add vector atan/atanf to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:37 ` [PATCH 11/42] x86-64: Add vector atan2/atan2f implementation to libmvec Sunil K Pandey
2021-11-24 19:37 ` [PATCH 12/42] x86-64: Add vector atan2/atan2f to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:37 ` [PATCH 13/42] x86-64: Add vector atanh/atanhf implementation to libmvec Sunil K Pandey
2021-11-24 19:37 ` [PATCH 14/42] x86-64: Add vector atanh/atanhf to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:37 ` [PATCH 15/42] x86-64: Add vector cbrt/cbrtf implementation to libmvec Sunil K Pandey
2021-11-24 19:37 ` [PATCH 16/42] x86-64: Add vector cbrt/cbrtf to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:37 ` [PATCH 17/42] x86-64: Add vector cosh/coshf implementation to libmvec Sunil K Pandey
2021-11-24 19:37 ` [PATCH 18/42] x86-64: Add vector cosh/coshf to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:37 ` [PATCH 19/42] x86-64: Add vector erf/erff implementation to libmvec Sunil K Pandey
2021-11-24 19:37 ` [PATCH 20/42] x86-64: Add vector erf/erff to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:37 ` [PATCH 21/42] x86-64: Add vector erfc/erfcf implementation to libmvec Sunil K Pandey
2021-11-24 19:37 ` [PATCH 22/42] x86-64: Add vector erfc/erfcf to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:37 ` [PATCH 23/42] x86-64: Add vector exp10/exp10f implementation to libmvec Sunil K Pandey
2021-11-24 19:37 ` [PATCH 24/42] x86-64: Add vector exp10/exp10f to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:37 ` [PATCH 25/42] x86-64: Add vector exp2/exp2f implementation to libmvec Sunil K Pandey
2021-11-24 19:37 ` [PATCH 26/42] x86-64: Add vector exp2/exp2f to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:37 ` [PATCH 27/42] x86-64: Add vector expm1/expm1f implementation to libmvec Sunil K Pandey
2021-11-24 19:37 ` [PATCH 28/42] x86-64: Add vector expm1/expm1f to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:37 ` [PATCH 29/42] x86-64: Add vector hypot/hypotf implementation to libmvec Sunil K Pandey
2021-11-24 19:37 ` [PATCH 30/42] x86-64: Add vector hypot/hypotf to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:37 ` [PATCH 31/42] x86-64: Add vector log10/log10f implementation to libmvec Sunil K Pandey
2021-11-24 19:37 ` [PATCH 32/42] x86-64: Add vector log10/log10f to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:37 ` [PATCH 33/42] x86-64: Add vector log1p/log1pf implementation to libmvec Sunil K Pandey
2021-11-24 19:37 ` [PATCH 34/42] x86-64: Add vector log1p/log1pf to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:38 ` [PATCH 35/42] x86-64: Add vector log2/log2f implementation to libmvec Sunil K Pandey
2021-11-24 19:38 ` [PATCH 36/42] x86-64: Add vector log2/log2f to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:38 ` [PATCH 37/42] x86-64: Add vector sinh/sinhf implementation to libmvec Sunil K Pandey
2021-11-24 19:38 ` [PATCH 38/42] x86-64: Add vector sinh/sinhf to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:38 ` [PATCH 39/42] x86-64: Add vector tan/tanf implementation to libmvec Sunil K Pandey
2021-11-24 19:38 ` [PATCH 40/42] x86-64: Add vector tan/tanf to libmvec microbenchmark Sunil K Pandey
2021-11-24 19:38 ` [PATCH 41/42] x86-64: Add vector tanh/tanhf implementation to libmvec Sunil K Pandey
2021-11-24 19:38 ` [PATCH 42/42] x86-64: Add vector tanh/tanhf to libmvec microbenchmark Sunil K Pandey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFUsyfJ+sURnik75vJ5XXpS9FwZruoH4yNOECg6=eH3qH1uASg@mail.gmail.com' \
--to=goldstein.w.n@gmail.com \
--cc=andrey.kolesov@intel.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=skpgkp2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).