From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 481CD385772C for ; Wed, 5 Apr 2023 21:03:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 481CD385772C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-93db98f7b33so62518566b.2 for ; Wed, 05 Apr 2023 14:03:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680728596; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jtrVC+G8B+3KKEbcM+xZVqmEAU5t3HpgSYfd/EJm2X4=; b=NP8riZNQs0LpiTjaQVNTIwnaoZR3RTxTvL10ee/hIsquCrRYF2lsFrZE8IWO7NkGha eKcpF8IeylRmclg3NItkUNDbsgAbvjtMV5LXg/LTUmS+9qtXW2uxxEGr3FwIZyEKIpj1 5CpTQiuOcHoX8lrJQZkhcL4Lbig9Y/bloMtujp03q1CmLHxWfNUFYjDBGI3CfXWmRPEQ Xzhfcn3bW2tj3Wxsu9utGv3jkciN1c+Q1nGy4n2NwgbPRx7lNewzo8ognHPzoK3K0wTH yXILceaqSSMu6vN82CKwR7BBkXKCShW5LS06roXV8YCXmz3Vkhd3k868aDLvza5W20rB vKrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680728596; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jtrVC+G8B+3KKEbcM+xZVqmEAU5t3HpgSYfd/EJm2X4=; b=iM+g7+myt2ZeksiQGS2OdOXoEgHLkF8TY+KIRO92GhDySkwfSZ7FgarcbX6ByR/D2f l0TaQaBUctD1HVzDZOcMySKAnTSF1qHRYGOG+z4VB4iAaZ6bOb4vc3Um6HCpsOgBW3e5 WZb2jk0dOgYTcF+otpohmTkgqVGOoRxNo4l5+NdMxeX4OaVgHCn0gRMKuupMTRE2Qc4S +84M62BA3ikr6Nem2AxrJoL267uVIvCDd71ihIW5iAq9rXCWFAVUyxcAHTdSS2DoDUVH RdQu8ajPzGA4ZXnm3N+hWgClNrps168+QpdxH2iAwDKDe8avI3jH0qYT8qiYgCFpjpKa 9U/g== X-Gm-Message-State: AAQBX9cvgbvmMhNGBxMP+9Ju6RxJKtlYyaqPQpCbeMkiFk3u0BxqsBBa 3cqAJSrTzjw3gA8LerAxTuU8anItngv1hwHIRWU= X-Google-Smtp-Source: AKy350a8DIaLgQt/h25am4dWCMKGk7s99+oZPzyNHsyFi4ybazfndk1ClEuMaWtz2fVrZ5ieQUsJpyyzgVfdh1zcup4= X-Received: by 2002:a50:d782:0:b0:501:d2f5:7da9 with SMTP id w2-20020a50d782000000b00501d2f57da9mr1926606edi.0.1680728595893; Wed, 05 Apr 2023 14:03:15 -0700 (PDT) MIME-Version: 1.0 References: <20230405162144.984598-1-hjl.tools@gmail.com> <20230405162144.984598-5-hjl.tools@gmail.com> In-Reply-To: From: Noah Goldstein Date: Wed, 5 Apr 2023 16:03:04 -0500 Message-ID: Subject: Re: [PATCH 04/19] : Add BUS_LOCK_DETECT support To: "H.J. Lu" Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Apr 5, 2023 at 1:20=E2=80=AFPM Noah Goldstein wrote: > > On Wed, Apr 5, 2023 at 11:22=E2=80=AFAM H.J. Lu via Libc-alpha > wrote: > > > > Add Bus lock debug exceptions (BUS_LOCK_DETECT) support to > > . > > --- > > manual/platform.texi | 3 +++ > > sysdeps/x86/bits/platform/x86.h | 2 +- > > sysdeps/x86/tst-get-cpu-features.c | 1 + > > 3 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/manual/platform.texi b/manual/platform.texi > > index 9251b63e47..78ee39f650 100644 > > --- a/manual/platform.texi > > +++ b/manual/platform.texi > > @@ -276,6 +276,9 @@ extensions. > > @item > > @code{BMI2} -- BMI2 instructions. > > > > +@item > > +@code{BUS_LOCK_DETECT} -- Bus lock debug exceptions. > > + > > @item > > @code{CLDEMOTE} -- CLDEMOTE instruction. > > > > diff --git a/sysdeps/x86/bits/platform/x86.h b/sysdeps/x86/bits/platfor= m/x86.h > > index c9189fa248..e25f1ac53c 100644 > > --- a/sysdeps/x86/bits/platform/x86.h > > +++ b/sysdeps/x86/bits/platform/x86.h > > @@ -187,7 +187,7 @@ enum > > instructions in 64-bit mode. */ > > x86_cpu_RDPID =3D x86_cpu_index_7_ecx + 22, > > x86_cpu_KL =3D x86_cpu_index_7_ecx + 23, > > - x86_cpu_INDEX_7_ECX_24 =3D x86_cpu_index_7_ecx + 24, > > + x86_cpu_BUS_LOCK_DETECT =3D x86_cpu_index_7_ecx + 24, > > x86_cpu_CLDEMOTE =3D x86_cpu_index_7_ecx + 25, > > x86_cpu_INDEX_7_ECX_26 =3D x86_cpu_index_7_ecx + 26, > > x86_cpu_MOVDIRI =3D x86_cpu_index_7_ecx + 27, > > diff --git a/sysdeps/x86/tst-get-cpu-features.c b/sysdeps/x86/tst-get-c= pu-features.c > > index 5f5cd3e448..dcb735ddd6 100644 > > --- a/sysdeps/x86/tst-get-cpu-features.c > > +++ b/sysdeps/x86/tst-get-cpu-features.c > > @@ -147,6 +147,7 @@ do_test (void) > > CHECK_CPU_FEATURE_PRESENT (LA57); > > CHECK_CPU_FEATURE_PRESENT (RDPID); > > CHECK_CPU_FEATURE_PRESENT (KL); > > + CHECK_CPU_FEATURE_PRESENT (BUS_LOCK_DETECT); > > CHECK_CPU_FEATURE_PRESENT (CLDEMOTE); > > CHECK_CPU_FEATURE_PRESENT (MOVDIRI); > > CHECK_CPU_FEATURE_PRESENT (MOVDIR64B); > > -- > > 2.39.2 > > > Rename 'bit_cpu_INDEX_7_ECX_24' in cpu-features.h? LGTM Reviewed-by: Noah Goldstein