From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <goldstein.w.n@gmail.com>
Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com
 [IPv6:2607:f8b0:4864:20::629])
 by sourceware.org (Postfix) with ESMTPS id A36FA3858400
 for <libc-alpha@sourceware.org>; Fri,  8 Oct 2021 21:04:54 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A36FA3858400
Received: by mail-pl1-x629.google.com with SMTP id 21so731937plo.13
 for <libc-alpha@sourceware.org>; Fri, 08 Oct 2021 14:04:54 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=Jrk8+Vt3hBstm+fp9QEkuO1GtjX9PAvjqtXV7Y9CWho=;
 b=5Erq3EZfod5D9cMkf3sltZGGATE+BTNfL7HBzhDXOvZk9BogOHsy9YYzQNMSF2jnSt
 Av84p7laQmUm9aO9mufPBnNG8ARw6tvYgTOr/IIPA5kc8ENp7IC6L1OoknNVuqX9C1QF
 aHVHdC4C1T3KjBcpeJxuoNAQQeZgoVAT6AUMCylqXzCb/p4w0NRlnvgMDuT0jlf/BHDj
 rR5qIKmFzu1aTi9O3RjfcldYqhA5CSg7APCZhAeuEVDMy86GbYX89MDvRK3Aqw+pGGE6
 yIfhjUhtfv8xfUYuuLgPnxn67UXknNwZNu3HGV29bSitsnIsGxKJF6g4HoqsF+nyDJkH
 yfgA==
X-Gm-Message-State: AOAM530L3bvKsWGkqJvgYil/PBHpATngE8UBVwW8Vhup6FOhE/wvp/VO
 Yfryg5DjD/g4O/GJcg5pzv8c4/A2l+NDJgq53by8WFJ4
X-Google-Smtp-Source: ABdhPJwf/EiCqoFE0XYS/yvk52/v0W4PkRwRzDr/0dnP/TP9Fln3BB7yV0eadlIB45JTvK342T+gl/S6Umh26WFKB/4=
X-Received: by 2002:a17:902:8d8b:b0:138:e09d:d901 with SMTP id
 v11-20020a1709028d8b00b00138e09dd901mr11718884plo.34.1633727093672; Fri, 08
 Oct 2021 14:04:53 -0700 (PDT)
MIME-Version: 1.0
References: <20210926205306.900081-1-goldstein.w.n@gmail.com>
 <CAMe9rOp-iU_K1HEgC69K4Cic6Z77mcjiNYa-1NFnYXvZpZfynA@mail.gmail.com>
In-Reply-To: <CAMe9rOp-iU_K1HEgC69K4Cic6Z77mcjiNYa-1NFnYXvZpZfynA@mail.gmail.com>
From: Noah Goldstein <goldstein.w.n@gmail.com>
Date: Fri, 8 Oct 2021 16:04:43 -0500
Message-ID: <CAFUsyfJ8_f0J0oYGBHh-euO8FgW1CTFr=DqDAV8n9NvLefrsLg@mail.gmail.com>
Subject: Re: [PATCH v1 1/3] benchtests: Add medium cases and increase iters in
 bench-memset.c
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
 "Carlos O'Donell" <carlos@systemhalted.org>
X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Oct 2021 21:04:56 -0000

On Fri, Oct 8, 2021 at 2:39 PM H.J. Lu <hjl.tools@gmail.com> wrote:

> On Sun, Sep 26, 2021 at 1:53 PM Noah Goldstein <goldstein.w.n@gmail.com>
> wrote:
> >
> > No bug.
> >
> > This commit adds new medium size cases for lengths in [512, 1024). As
> > well it increase the iters to INNER_LOOP_ITERS_LARGE for more reliable
> > results.
> >
> > Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
> > ---
> >  benchtests/bench-memset.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/benchtests/bench-memset.c b/benchtests/bench-memset.c
> > index d6619b4836..4284cb1724 100644
> > --- a/benchtests/bench-memset.c
> > +++ b/benchtests/bench-memset.c
> > @@ -43,7 +43,7 @@ static void
> >  do_one_test (json_ctx_t *json_ctx, impl_t *impl, CHAR *s,
> >              int c __attribute ((unused)), size_t n)
> >  {
> > -  size_t i, iters = INNER_LOOP_ITERS;
> > +  size_t i, iters = INNER_LOOP_ITERS_LARGE;
> >    timing_t start, stop, cur;
> >
> >    TIMING_NOW (start);
> > @@ -118,7 +118,7 @@ test_main (void)
> >           if (i & (i - 1))
> >             do_test (&json_ctx, 0, c, i);
> >         }
> > -      for (i = 32; i < 512; i+=32)
> > +      for (i = 32; i < 1024; i+=32)
> >         {
> >           do_test (&json_ctx, 0, c, i);
> >           do_test (&json_ctx, i, c, i);
> > --
> > 2.25.1
> >
>
> LGTM.
>
> Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
>
> Thanks.
>
> --
> H.J.
>

Thanks. Pushed.