From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id CC9783858D3C for ; Tue, 21 Mar 2023 18:01:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC9783858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x536.google.com with SMTP id cy23so62961080edb.12 for ; Tue, 21 Mar 2023 11:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679421680; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=z1igi/lml7m2RUujWAlG/gMB3iBxX2btI2pNXdWZWVg=; b=ScUa3a1Y/85Azb6AhrI5PjMNfYjrJeTPK1Ez+ZXt92RWNz7MJ+6FctaLzPvf1zof+Z ggSfk8PI+tUySaJT9AcMDK6wrXWS8UJBD8zH2uVZhCtVMGINFAppsY01f2vsCDqPSyct VboPWM7/hCPKJ8pJHzkElf6vaYUstfGixFRu2COCIqlRfItGmAfTpNGCZe+WPghYdZbp Q6lo6Pc9uyBOhs4KtORRYfm0qCvMe4vFj0+TzxBkiidkpcpsxa0NPbOJySzC/LQ93ET8 bPTjfWKHtge+lr+7bVlZKXXfW8JpoaYlWCszYGyEGco6cYDGqOCdv9VYgGTjZg1gfAVi yysw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679421680; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z1igi/lml7m2RUujWAlG/gMB3iBxX2btI2pNXdWZWVg=; b=EmjcqhM/eU6DWCpkXxZCax3HfJlh/gcTLormsQqtxwSl3Jbuln2EhIGZdv87aQXsvC AVD/3y2omiQr/Jb8tXwgikpm67eF8MNTMJKkLatssMJx34VFYHZbQfcZWnShbDvpq+7i An4xHHG/dUQtcz9in5tMhTTb3ypr5oZd5usyqo5WCY7MTJhBvGW29jLtHeH/ZiTRzQ0F 3YZ0ffSUjvjxtkxKbzzTNBm/t0GFYE2TkDtlBcMxzK4NqODqa64rpcbFu6iWhTMf6Gm5 gmrLjHoYhSFebUvuw40wjC+V4to8rrt0sZqjpvztqHqiDFNlLvy0QBhwrzswdRhEruA1 JaZQ== X-Gm-Message-State: AO0yUKW33e0V9WNx2MpMVKtAmefjbHWp1GDb2VUmmn0lE/B82KvXuZiw CVPbXsc6FKaM5DVpmOD+dbEcIAwjqYUW3oAQQy8= X-Google-Smtp-Source: AK7set+nEuTXiflM54J0DzsurzPtcN9ie1AFfv8Fmn/tBFt88NhF04f3U/NsV8Wlc2AOGfK9f0ATM/lKFTgauDFTT7Q= X-Received: by 2002:a50:9fa2:0:b0:4fa:7e99:9e2c with SMTP id c31-20020a509fa2000000b004fa7e999e2cmr2228487edf.0.1679421680415; Tue, 21 Mar 2023 11:01:20 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Noah Goldstein Date: Tue, 21 Mar 2023 13:01:09 -0500 Message-ID: Subject: Re: x86: Don't check PREFETCHWT1 in tst-cpu-features-cpuinfo.c To: DJ Delorie Cc: libc-alpha@sourceware.org, hjl.tools@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Mar 10, 2023 at 1:04=E2=80=AFAM Noah Goldstein wrote: > > On Thu, Mar 9, 2023 at 9:43=E2=80=AFPM DJ Delorie via Libc-alpha > wrote: > > > > > > As not noted in the kernel sources: > > > > > /* Intel-defined CPU features, CPUID level 0x00000007:0 (ECX), word 1= 6 */ > > > #define X86_FEATURE_AVX512VBMI (16*32+ 1) /* AVX512 Vector B= it Manipulation instructions*/ > > > #define X86_FEATURE_UMIP (16*32+ 2) /* User Mode Instr= uction Protection */ > > > > vs glibc: > > > > > /* ECX. */ > > > #define bit_cpu_PREFETCHWT1 (1u << 0) > > > #define bit_cpu_AVX512_VBMI (1u << 1) > > > #define bit_cpu_UMIP (1u << 2) > > > > Tested on the one machine I could find in our inventory that set that f= lag: > > > > - FAIL: elf/tst-cpu-features-cpuinfo > > - FAIL: elf/tst-cpu-features-cpuinfo-static > > - 27 FAIL > > + 23 FAIL > > > > (there were two unrelated timeouts in the "before" results) > > > > From c4a62abbeac4ced531ced3999a2cd2d4fab6bdc6 Mon Sep 17 00:00:00 2001 > > From: DJ Delorie > > Date: Thu, 9 Mar 2023 22:32:54 -0500 > > Subject: x86: Don't check PREFETCHWT1 in tst-cpu-features-cpuinfo.c > > > > Don't check PREFETCHWT1 against /proc/cpuinfo since kernel doesn't repo= rt > > PREFETCHWT1 in /proc/cpuinfo. > > > > diff --git a/sysdeps/x86/tst-cpu-features-cpuinfo.c b/sysdeps/x86/tst-c= pu-features-cpuinfo.c > > index c25240774e..e963592c4b 100644 > > --- a/sysdeps/x86/tst-cpu-features-cpuinfo.c > > +++ b/sysdeps/x86/tst-cpu-features-cpuinfo.c > > @@ -217,7 +217,10 @@ do_test (int argc, char **argv) > > fails +=3D CHECK_PROC (pku, PKU); > > fails +=3D CHECK_PROC (popcnt, POPCNT); > > fails +=3D CHECK_PROC (3dnowprefetch, PREFETCHW); > > +#if 0 > > + /* NB: /proc/cpuinfo doesn't report this feature. */ > > fails +=3D CHECK_PROC (prefetchwt1, PREFETCHWT1); > > +#endif > > #if 0 > > /* NB: /proc/cpuinfo doesn't report this feature. */ > > fails +=3D CHECK_PROC (ptwrite, PTWRITE); > > > > LGTM. Reviewed-by: Noah Goldstein