From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=I34z=3S=gmail.com=goldstein.w.n@sourceware.org>
Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b])
	by sourceware.org (Postfix) with ESMTPS id F15CB385222B
	for <libc-alpha@sourceware.org>; Fri, 18 Nov 2022 20:36:13 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F15CB385222B
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-ej1-x62b.google.com with SMTP id t25so15772324ejb.8
        for <libc-alpha@sourceware.org>; Fri, 18 Nov 2022 12:36:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=OEqfpN+h1gWkW15y97X+14K3viNyIk8YlyNGlaAbyBo=;
        b=VofAL+pBRam751qrOX/9HQsNp1XfpWEDMc//t2bzi2xFo0qvdStl8OeL3jpwtl1kM6
         oP1H4TtMYYQTGUtu6rkO7LpVMyJjf8gUIptd6vp3YuSBJFTYvoJV2ArsrJZq+raeJ7v6
         AQbPZHk+5bA5+sl5YjQSivmkD8MlcyBniNxUJdW/X8xVyEZjJwlQXWbQUhHldkQjd8HQ
         4X/oZcqwLxS16cDx/INGdWkbdTrUMwJlU+dO8f9wNSESXlbm0ehpi4Yralulw/nwkjTK
         FZg17H50LutrrBJECrPpQpyBVfg3KKqXoI2KleuzwKsj03V0N7ngA3YalRddLUrt+GdP
         6SDA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=OEqfpN+h1gWkW15y97X+14K3viNyIk8YlyNGlaAbyBo=;
        b=qTwC8JbcmEBPlxMMriEVgrFQRBNnb67bpL6vUq+E7ss9E59miw6l3hBGC+GPXjkSsT
         kb4DnvDOZyWSPaHwVCNI4qnI+YSgQ6CzSFUsjp3D4VBvxRImswoZK3mufcxbWFXUkhuQ
         HkIydulvWY9duanE4lBBvLlnj+UQ3zTEDEjKH+qrkXxGuoAGPgIe/KiDf7yBKuWVvHdZ
         OtQ3i0YTvn8HVXQ9/jkWrLpw4jypfKA5mHwSOhnZ8z8BJJYBnJoF1wFFSx626L1XCRM4
         bXfUzk0a5HuuN8a3FAH84DwQGvftn2anFDjvRFXcRdaPz6JeIzwjfhcJ8bMT5VWDpXjo
         mgNw==
X-Gm-Message-State: ANoB5plCIaPsB6hCZLYsLwurjAOdiBRWAC+vszl2esIEddK8znpakCDP
	iziu1XyZ/gpFpXWt0YrF6c9oJ7JmkG75Xg4iabpbVZwj
X-Google-Smtp-Source: AA0mqf6nXl4UUTjY9hsE+aHWM8ndyWVxIS/E71NZ7xuVODBIsZ+JU0SkTvunq9IT5dqk3G3cY/5Uxc2+j+2WgcTeLqM=
X-Received: by 2002:a17:906:d211:b0:79d:f5f2:6f55 with SMTP id
 w17-20020a170906d21100b0079df5f26f55mr6935332ejz.531.1668803772606; Fri, 18
 Nov 2022 12:36:12 -0800 (PST)
MIME-Version: 1.0
References: <20221118190835.1033248-1-goldstein.w.n@gmail.com>
 <20221118190835.1033248-2-goldstein.w.n@gmail.com> <CAMe9rOrmdfH=1+j1HSwzOQbVf_0GVf-fczh04a42Oweug5SroA@mail.gmail.com>
In-Reply-To: <CAMe9rOrmdfH=1+j1HSwzOQbVf_0GVf-fczh04a42Oweug5SroA@mail.gmail.com>
From: Noah Goldstein <goldstein.w.n@gmail.com>
Date: Fri, 18 Nov 2022 12:36:01 -0800
Message-ID: <CAFUsyfJcvX0g=zHnWjp7mBKK7v=SNhQFSnUk91pm2cFQxDqVZA@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] x86/fpu: Cleanup code in svml_{s|d}_wrapper_impl.h.S
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: libc-alpha@sourceware.org, andrey.kolesov@intel.com, 
	carlos@systemhalted.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

On Fri, Nov 18, 2022 at 11:56 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Fri, Nov 18, 2022 at 11:08 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > 1. Remove unnecessary spills.
> > 2. Split the shared avx/avx512 wrappers to a new file.
> > 3. Fix some small nit missed optimizations.
> >
> > All math and mathvec tests pass on x86.
> > ---
> >  sysdeps/x86_64/fpu/svml_d_wrapper_impl.h    | 253 ++--------------
> >  sysdeps/x86_64/fpu/svml_s_wrapper_impl.h    | 309 ++++----------------
> >  sysdeps/x86_64/fpu/svml_sd_wrapper_impl.h.S | 190 ++++++++++++
> >  3 files changed, 266 insertions(+), 486 deletions(-)
> >  create mode 100644 sysdeps/x86_64/fpu/svml_sd_wrapper_impl.h.S
>
> Please use svml_sd_wrapper_impl.h to be consistent with other .h files.

Done. V3 in a new thread because changed commit message (realized was
using .h.S there).
>
> Thanks.
>
> --
> H.J.