From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <goldstein.w.n@gmail.com>
Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com
 [IPv6:2607:f8b0:4864:20::22d])
 by sourceware.org (Postfix) with ESMTPS id 805AA38582BE
 for <libc-alpha@sourceware.org>; Thu,  7 Jul 2022 23:47:41 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 805AA38582BE
Received: by mail-oi1-x22d.google.com with SMTP id l81so25215218oif.9
 for <libc-alpha@sourceware.org>; Thu, 07 Jul 2022 16:47:41 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=ywjgYzox7qmIUA0iqQRKDdPwLJ+1qiSeDeBzbZO6WsI=;
 b=4604pPNoAjyL37ujqzMYs5XQVQ21qgoE1863wnnx/uzN8AFmISBypW9BcQCoJz8OoE
 DiWI1JkAi5uL26u65y3KQC2vc4B5GVUTfmlbUyoaqAgLQbXnM45F21Tmw6GH6+ZaSRis
 W892byVHcjOpbeMhlvN4vwGLAirrWQkiNXun6Vq493yBET7xKeW3IXVlOMlYjYOC+IfY
 MTYp18gv9YVjKG5VkeArcycYwD866rl0JhRztuOetcVlUU43waHQYLMKDrYlz7mM/HoR
 MKvp3QfhWngRlp4iFSDvmkpynYBWuuwcGOj4wMrnPp09sAZPB3w/wzjXOZDiCpE8d713
 r42Q==
X-Gm-Message-State: AJIora87B8nN4LLFLZEYhv+LmYYrO8aETJtd5WXahOnrom3IMqGKeo9X
 avvYTaviUTh/qLkbCMardj3oobE48v0+i/CDfwctebON
X-Google-Smtp-Source: AGRyM1siI9UREsXrs0Iwgf2LwKFVu8cHHH2IbbaPXmDDuMTlj5Eoihn97XeGckFkyFYQQz7+wpg/PZYdcrFgkj/DWeE=
X-Received: by 2002:a05:6808:170b:b0:335:1807:e4a2 with SMTP id
 bc11-20020a056808170b00b003351807e4a2mr274157oib.89.1657237660810; Thu, 07
 Jul 2022 16:47:40 -0700 (PDT)
MIME-Version: 1.0
References: <20220707233956.2483267-1-hjl.tools@gmail.com>
 <CAMe9rOq27YSS_1zwC9EPOjDgeHWT-a2uyQY-Y1dv5nwWkvb-xw@mail.gmail.com>
 <CAFUsyf+H=T7VtKpKB-_FKkkV-4kr+v_=uewtGXX-QOhU5RCy5g@mail.gmail.com>
In-Reply-To: <CAFUsyf+H=T7VtKpKB-_FKkkV-4kr+v_=uewtGXX-QOhU5RCy5g@mail.gmail.com>
From: Noah Goldstein <goldstein.w.n@gmail.com>
Date: Thu, 7 Jul 2022 16:47:30 -0700
Message-ID: <CAFUsyfJf83paA3YowMNCupX6v=_uJ+4MXSzO=TxxAaEJcS6mxA@mail.gmail.com>
Subject: Re: [PATCH] x86-64: Don't mark symbols as hidden in strcmp-XXX.S
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jul 2022 23:47:43 -0000

On Thu, Jul 7, 2022 at 4:45 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> On Thu, Jul 7, 2022 at 4:43 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Thu, Jul 7, 2022 at 4:39 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > >
> > > Don't mark symbols as hidden in strcmp-avx2.S, strcmp-evex.S and
> > > strcmp-sse42.S since they are marked as hidden in the IFUNC selectors.
> > > ---
> > >  sysdeps/x86_64/multiarch/strcmp-avx2.S  | 1 -
> > >  sysdeps/x86_64/multiarch/strcmp-evex.S  | 1 -
> > >  sysdeps/x86_64/multiarch/strcmp-sse42.S | 1 -
> > >  3 files changed, 3 deletions(-)
> > >
> > > diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > index 8da09bd86d..516cde1145 100644
> > > --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> > > @@ -184,7 +184,6 @@
> > >         .align  16
> > >         .type   STRCMP, @function
> > >         .globl  STRCMP
> > > -       .hidden STRCMP
> >
> > Hi Noah,
> >
> > Why aren't ENTRY/END used on STRCMP?
> >
>
> Not sure, I copied sse42 when doing avx2/evex.
>
> > >  # ifndef GLABEL
> > >  #  define GLABEL(...)  __VA_ARGS__
> > > diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > index 2a5b3ce037..e97d51bb26 100644
> > > --- a/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
> > > @@ -214,7 +214,6 @@
> > >         .align  16
> > >         .type   STRCMP, @function
> > >         .globl  STRCMP
> > > -       .hidden STRCMP
> > >
> > >  # ifdef USE_AS_STRCASECMP_L
> > >  ENTRY (STRCASECMP)
> > > diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > index a9178ad25c..60313c647a 100644
> > > --- a/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > +++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> > > @@ -77,7 +77,6 @@
> > >         .align  16
> > >         .type   STRCMP_SSE42, @function
> > >         .globl  STRCMP_SSE42
> > > -       .hidden STRCMP_SSE42
> > >  #ifdef USE_AS_STRCASECMP_L
> > >  ENTRY (GLABEL(__strcasecmp))
> > >         movq    __libc_tsd_LOCALE@gottpoff(%rip),%rax
> > > --
> > > 2.36.1
> > >
> >

Do you need to do strcmp-sse2.S?
> >
> > --
> > H.J.