From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by sourceware.org (Postfix) with ESMTPS id 036A43887F6C for ; Wed, 5 Apr 2023 21:04:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 036A43887F6C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x535.google.com with SMTP id t10so144202534edd.12 for ; Wed, 05 Apr 2023 14:04:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680728680; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hZu0ruh7VgrLhYJz/yW4iHYbIx15PmqkJqJlBc9T3L8=; b=Ho9O9+Ux9xFd/0MYeW4hbNbOFRRv4udiWHivfaRtTI5EUlE014wD7psW9R8tQz6whv hMtF5G9G0a9RfwnoN0JWceOYtMZA9J/uiDWwK9PDl5PkazM7rwM6QcUgbFTqJxEYSNb7 Pz+rr05pECzMlUTT45GrY/xPm9VV0IRiucCsfY/sB6O4TZAUFNi5F2Hw94KHqu8gBYuG vKcS52k0/5tVUrD+H3aNyF/Gdh6iEGSeWNf2ZJblTaA1sZb16e7wQa222JTuMroN6SOC L5oqvSghgWbv9TmhZ3Bp0+oijlkbtdNB6336Oeeg997usT+A4oVLpjGDpUb8T7ry7zso KSZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680728680; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hZu0ruh7VgrLhYJz/yW4iHYbIx15PmqkJqJlBc9T3L8=; b=QCH9bnG+NFKAM3aP30HIo+vNEsnjcG39ihUtHPSlTqddB3zlUuuLJy7lA6hLbRZnh8 +Q4wawlMnayDhNYdo2hMfKf3VSVGJp7W1xLamA8oNQ4j+0W+EUOioV/0ABbEmztEcZ+S ij3z/TdrafcneAjxTNuFthTJJTdbL2loQc96zvKTGSeDojMVxkov8i4SiCQcKhfr3nRH ACusb1ihc8WFkGv9iykg5belZ/kLwzxn/eekXRpej2xaSaEECAJ5LSVEHjAi9iLlXuph qiEcvD7qw100V4iMf3POzmq8a1JhyBJ+TGhu3gCkmYKUU6tIVcCKNJ/iquKSV2z7i0tl 7WEA== X-Gm-Message-State: AAQBX9feMSiOXg8DDT8vP1HC2rkb/RlbVrGav3AC62vhcD9kTHZBPsKK nKhwyLrxFBPyJ5nPDTrsDRlS44ysZakX1l3v8Eg= X-Google-Smtp-Source: AKy350ZRXhX/zxQTcKWKw7hPdzc31eJ3Z9uGdp0IPtdyEPBRgCaxnWF2a1TFz7BpguognJ8wTSiktGJInKBDnwjBtyc= X-Received: by 2002:a17:907:8c0c:b0:8f1:4cc5:f14c with SMTP id ta12-20020a1709078c0c00b008f14cc5f14cmr2480779ejc.0.1680728680653; Wed, 05 Apr 2023 14:04:40 -0700 (PDT) MIME-Version: 1.0 References: <20230405162144.984598-1-hjl.tools@gmail.com> <20230405162144.984598-12-hjl.tools@gmail.com> In-Reply-To: <20230405162144.984598-12-hjl.tools@gmail.com> From: Noah Goldstein Date: Wed, 5 Apr 2023 16:04:29 -0500 Message-ID: Subject: Re: [PATCH 11/19] : Add ArchPerfmonExt support To: "H.J. Lu" Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Apr 5, 2023 at 11:26=E2=80=AFAM H.J. Lu via Libc-alpha wrote: > > Add Architectural Performance Monitoring Extended Leaf (EAX =3D 23H) > support to . > --- > manual/platform.texi | 4 ++++ > sysdeps/x86/bits/platform/x86.h | 1 + > sysdeps/x86/tst-get-cpu-features.c | 1 + > 3 files changed, 6 insertions(+) > > diff --git a/manual/platform.texi b/manual/platform.texi > index e4d2c00886..ecee3a7b39 100644 > --- a/manual/platform.texi > +++ b/manual/platform.texi > @@ -206,6 +206,10 @@ The supported processor features are: > @item > @code{ARCH_CAPABILITIES} -- IA32_ARCH_CAPABILITIES MSR. > > +@item > +@code{ArchPerfmonExt} -- Architectural Performance Monitoring Extended > +Leaf (EAX =3D 23H). > + > @item > @code{AVX} -- The AVX instruction extensions. > > diff --git a/sysdeps/x86/bits/platform/x86.h b/sysdeps/x86/bits/platform/= x86.h > index 0187964aba..74b7f951e1 100644 > --- a/sysdeps/x86/bits/platform/x86.h > +++ b/sysdeps/x86/bits/platform/x86.h > @@ -293,6 +293,7 @@ enum > x86_cpu_AVX512_BF16 =3D x86_cpu_index_7_ecx_1_eax + 5, > x86_cpu_LASS =3D x86_cpu_index_7_ecx_1_eax + 6, > x86_cpu_CMPCCXADD =3D x86_cpu_index_7_ecx_1_eax + 7, > + x86_cpu_ArchPerfmonExt =3D x86_cpu_index_7_ecx_1_eax + 8, > x86_cpu_FZLRM =3D x86_cpu_index_7_ecx_1_eax + 1= 0, > x86_cpu_FSRS =3D x86_cpu_index_7_ecx_1_eax + 11, > x86_cpu_FSRCS =3D x86_cpu_index_7_ecx_1_eax + 1= 2, > diff --git a/sysdeps/x86/tst-get-cpu-features.c b/sysdeps/x86/tst-get-cpu= -features.c > index d8bc92560f..329d4aafb4 100644 > --- a/sysdeps/x86/tst-get-cpu-features.c > +++ b/sysdeps/x86/tst-get-cpu-features.c > @@ -205,6 +205,7 @@ do_test (void) > CHECK_CPU_FEATURE_PRESENT (AVX512_BF16); > CHECK_CPU_FEATURE_PRESENT (LASS); > CHECK_CPU_FEATURE_PRESENT (CMPCCXADD); > + CHECK_CPU_FEATURE_PRESENT (ArchPerfmonExt); > CHECK_CPU_FEATURE_PRESENT (FZLRM); > CHECK_CPU_FEATURE_PRESENT (FSRS); > CHECK_CPU_FEATURE_PRESENT (FSRCS); > -- > 2.39.2 > LGTM Reviewed-by: Noah Goldstein