From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 580363858D33 for ; Tue, 10 Jan 2023 17:16:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 580363858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62f.google.com with SMTP id cf18so24133488ejb.5 for ; Tue, 10 Jan 2023 09:16:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZuPa1L47j5V4XBNpZxlaItM5Jq/UI50SqYm+nd8wjyc=; b=BQ2MNK5Ih2KCYkLKF4/wTGzZO9miFpLyuPsq2kpkjKCDee8cCuVCNZhRtpXGzlaq7P GQrLkEwatAyY6SfhqMm5Ra7XaE69CjiUc7ron5sgO/eXmRge7e2Om7tAIR8ACe4e9acw 5tWTi4UQHjE1RUkrueMm17FWL7Dg62ORMShkPEetm8qISUoU8P8NIVGzmxBEUwIbKpgS 40e9q9G0ZdFeRTB1O40lLEXHrQmfwt3oBHLz7hzK1yxGc/PWa8kftWSzNKD+0uYFm+AC /mZHg24oVb3g+5Fm1/3XFdX02/83DbxmsD6oPBzY87bD4ZHQawEHZXz0L7GDn50wMWnv K5dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZuPa1L47j5V4XBNpZxlaItM5Jq/UI50SqYm+nd8wjyc=; b=rEeUNRwDACEzM7btikRGazEzsgrt7AzUH5YWjcD8x1fCPqL37P0WtHWLJ51UI4eXwF Hb9GvHb5wGtoxbasdi+5cS0+Q9/BGE4WudbeFqMGBkbnT5tgjDreOzbaXimwMCdgxvo8 sK9H1smUgCWSFhkHwZKBogh2WX/bD2e6vWBtv8N7kkP0nlf2WAIfN0ijiNLGrb8qMdqK uubYxQtsH0pxFFqN1EjTE7HdjagoHpR1tuJU6m+vssqRs/TXPLaVU9XRbtXLrvUHcxIr dsiH46c9gExfYQq+bHGQJpQ4+aCKjhgoFbPPJ9nsOP9L+bjYQljeF4nsmHch2/q9b0DO ny7g== X-Gm-Message-State: AFqh2kpkzpwHDunqtDQVHD62E3zbpD9B+ZGuwv24whdC8/0xV+TqT3xd 2le6iNhNLptuMkOKJ4EAA9BLt1KGzP3eJnOvYqj1b3Ju0jQ= X-Google-Smtp-Source: AMrXdXsbOgltub3/IdiuqElKjsGUzknb6GIswbUU0t9FLcI3zA5Y/PIue51/6qBtr2OmRT7/bMXqeVhTeU1dL0CMYo8= X-Received: by 2002:a17:906:281b:b0:7c1:98f:be57 with SMTP id r27-20020a170906281b00b007c1098fbe57mr3944399ejc.97.1673370983861; Tue, 10 Jan 2023 09:16:23 -0800 (PST) MIME-Version: 1.0 References: <20220919195920.956393-1-adhemerval.zanella@linaro.org> <20220919195920.956393-9-adhemerval.zanella@linaro.org> <66dba77d-29b0-a927-da2d-1d839112885b@linaro.org> In-Reply-To: <66dba77d-29b0-a927-da2d-1d839112885b@linaro.org> From: Noah Goldstein Date: Tue, 10 Jan 2023 09:16:13 -0800 Message-ID: Subject: Re: [PATCH v5 08/17] string: Improve generic strchrnul To: Richard Henderson Cc: Adhemerval Zanella Netto , Richard Henderson , libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jan 10, 2023 at 8:24 AM Richard Henderson wrote: > > On 1/10/23 06:18, Adhemerval Zanella Netto via Libc-alpha wrote: > > static __always_inline op_t > > check_mask (op_t word, uintptr_t s_int) > > { > > if (__BYTE_ORDER == __LITTLE_ENDIAN) > > return word >> (CHAR_BIT * (s_int % sizeof (s_int))); > > else > > return word << (CHAR_BIT * (s_int % sizeof (s_int))); > > } > > sizeof(op_t), which is usually the same size, but doesn't have to be. > Are we aligning by sizeof(op_t) or sizeof(void *)? The former then `word_containing` will also need to be changed. If the latter then sizeof(s_int) is correct. > > r~