From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by sourceware.org (Postfix) with ESMTPS id 5C9BC3858D3C for ; Wed, 13 Apr 2022 23:28:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C9BC3858D3C Received: by mail-yb1-xb32.google.com with SMTP id x200so6439845ybe.13 for ; Wed, 13 Apr 2022 16:28:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wNhW2GUpjz8OQukduTzdv87ClR2SIcppf4lVo0WT9xI=; b=fzgw/loenw/iE3hNceFCYOfZ/iIzcg35cKKu12Yb8y9sCBIsUb55PmJKyS1//nacUX ui6gPlNQ/vc5wzxakSGEX33gcRhCwYQYtfL23Pqe2hWdVSaGCtf1xrEfyobGoKkx5jrm puAf0s83y1VR/CGktZ5/GXj61+4ZGqNTJCpxFAkaeBpJ4MSSrwaGYK2KTDc7HD+lq7HO Qwm9F3HwfrHsbyhbBMYVzn8NC2XkJb65JU7/xx41fILPWPEGn+r2lrPaPbtad50Eh0fN fvmFf6n19xVAz2cZO8o0LCYCB12YE4gw0E/9GCObtt0AWMB1RX8Pqj64LciUinJHvY/i 6XfA== X-Gm-Message-State: AOAM530kLj4bzjtZuoiMujD3JxxgK2onv3cNe0lJyVNlnBGPlwTDgDlJ rQz5KOVxKg6we2p8qemPC7K8thXUx+f92uLMKHYjwNVw X-Google-Smtp-Source: ABdhPJyUzlOYOi3yXPjo0J5ebynf+vqeILsvIhN3xMHcbUvyhsY6bjPoZOtpG7rqYyxGSasnDf56x1RU7c8z6hOHod0= X-Received: by 2002:a25:1882:0:b0:63e:7c08:f570 with SMTP id 124-20020a251882000000b0063e7c08f570mr1047750yby.487.1649892515800; Wed, 13 Apr 2022 16:28:35 -0700 (PDT) MIME-Version: 1.0 References: <20220411165835.4028009-1-goldstein.w.n@gmail.com> <9a1dd0bc-57cc-0fa7-0d61-1b9cbae247a0@cs.ucla.edu> <92b7db75-0536-d28b-0618-34519305223b@cs.ucla.edu> <56ae0132-0509-31a9-a003-29c752575332@cs.ucla.edu> In-Reply-To: <56ae0132-0509-31a9-a003-29c752575332@cs.ucla.edu> From: Noah Goldstein Date: Wed, 13 Apr 2022 18:28:25 -0500 Message-ID: Subject: Re: [PATCH v1] Replace {u}int_fast{16|32} with {u}int32_t To: Paul Eggert Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2022 23:28:37 -0000 On Wed, Apr 13, 2022 at 2:11 PM Paul Eggert wrote: > > On 4/13/22 08:23, Noah Goldstein wrote: > > >> Both, I expect. We can assume int is at least 32 bits. > > > > Disagree with that a bit. fast32 is saving pretty specifically at least 32 bits > > which int doesn't say but int32_t does. > > I thought the idea was to not worry about losing the 16-bit vs 32-bit vs > whatever info, since it doesn't really matter and keeping the info > around just encourages bikeshedding later. The reason not replacing fast32 with int is int can be 2-bytes so it can be incorrect. uint32_t will always work where fast32 worked. > > If we want to keep that info then we should create private types like > glibc_int_fast32_t as I mentioned earlier. If not, let's just use 'int'. > glibc_int_fast32_t would work fine as well, just seems like a bigger change than is needed. > > > Can you confirm all the tz changes are okay? > > Oh, sorry, I didn't notice that you were changing zic.c. > > Unfortunately the zic.c changes are not OK, as zic.c is supposed to > portable to platforms that lack int32_t (the C standard allows such > platforms). Fixed in v4.