From: Noah Goldstein <goldstein.w.n@gmail.com>
To: Nisha Menon <nisha.s.menon@gmail.com>
Cc: Florian Weimer <fweimer@redhat.com>,
Noah Goldstein via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] compare_strings.py : Add --gmean flag
Date: Mon, 3 Apr 2023 18:35:44 -0500 [thread overview]
Message-ID: <CAFUsyfK2+y=ZO-jcyiE5bjZdxY3n8v4V1vhRDS5LmJoFLWmHYQ@mail.gmail.com> (raw)
In-Reply-To: <CABmriTFe9_B6U_9AWuhh=nx+DfBcJ0FbavnodZn2D2KaHMUvTw@mail.gmail.com>
On Mon, Apr 3, 2023 at 5:58 PM Nisha Menon <nisha.s.menon@gmail.com> wrote:
>
> On Mon, Apr 3, 2023 at 5:37 PM Florian Weimer <fweimer@redhat.com> wrote:
> >
> > * Noah Goldstein via Libc-alpha:
> >
> > > Is there an issue using statistics package and just doing:
> > > `statistics.geometric_mean`
> > > ?
> >
> > According to
> >
> > <https://docs.python.org/3/library/statistics.html#statistics.geometric_mean>
> >
> > it was added in Python 3.8, which is newer than what we aim for in
> > general (INSTALL currently mentions Python 3.4).
> >
>
> So is the fix okay as it is?
>
> Thanks,
> Nisha
Yeah LGTM.
next prev parent reply other threads:[~2023-04-03 23:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 14:11 Nisha Poyarekar
2023-04-03 15:34 ` Noah Goldstein
2023-04-03 21:37 ` Florian Weimer
2023-04-03 22:58 ` Nisha Menon
2023-04-03 23:35 ` Noah Goldstein [this message]
2023-04-04 0:33 ` Nisha Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFUsyfK2+y=ZO-jcyiE5bjZdxY3n8v4V1vhRDS5LmJoFLWmHYQ@mail.gmail.com' \
--to=goldstein.w.n@gmail.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=nisha.s.menon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).