From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by sourceware.org (Postfix) with ESMTPS id DB95A3858411 for ; Tue, 28 Sep 2021 16:48:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DB95A3858411 Received: by mail-lf1-x12e.google.com with SMTP id y26so56014974lfa.11 for ; Tue, 28 Sep 2021 09:48:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TvBnr9/9oKHquzej2OlVoeX4DhuE94YKFTNa48FPx+E=; b=S9L/cz+wupDKnhlKbaLwHHhEAL4W5nhEqUAegJQwZ0XbNKwzXryq35CCjA4lsQfo4h w0gkLYRf1b4r5Gd52hQtawColRCll7JNLWVB46KmkJLVbtn3cvsaten+HbgqP8/uUZjI 8HNvfArB+YChxtywj8W9NmBvyh/TST9aVDKs//CtTnarEKGWVhSj5YZ68x+gY7V3Db6e CVcY1IFQF1lEaDACutyPrfC3XXZ4vO+830Ft9TvYH6YeVyIfCpGlYAcC3NAVIda4Nri+ pKzI/JMivSPWKAl3za0KoVLzMYPQ99RyD0ifXwW9Fnyc6OC/UW7MDKlUg3Wdm9eMil7C vjBA== X-Gm-Message-State: AOAM5323AiKl8aO3kGNMmJFqBEpmj1u+YR4zUA+tH/EcSkUziDQSgLw5 BqEGjC417xLKxvZtA5tJ/4dRHx4b0+5Pnv+y36486vce X-Google-Smtp-Source: ABdhPJwP0UBGdwN92s5tsCoQWf19Bsocl4M3Xxj5CeRXvLj7G5MCAF9MMJeT3mOPsoXreb5u/AhBRbpAkpUdpRpnOxw= X-Received: by 2002:a2e:1511:: with SMTP id s17mr972954ljd.197.1632847679334; Tue, 28 Sep 2021 09:47:59 -0700 (PDT) MIME-Version: 1.0 References: <20210927203827.2852935-1-goldstein.w.n@gmail.com> <20210928012407.557866-1-goldstein.w.n@gmail.com> <87y27h9kuv.fsf@igel.home> In-Reply-To: <87y27h9kuv.fsf@igel.home> From: Noah Goldstein Date: Tue, 28 Sep 2021 11:47:48 -0500 Message-ID: Subject: Re: [PATCH v3] String: Add support for __memcmpeq() ABI on all targets To: Andreas Schwab Cc: Noah Goldstein via Libc-alpha Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Sep 2021 16:48:03 -0000 On Tue, Sep 28, 2021 at 3:15 AM Andreas Schwab wrote: > > On Sep 27 2021, Noah Goldstein via Libc-alpha wrote: > > > diff --git a/string/tester.c b/string/tester.c > > index 778160ae6e..7d8e1b7c1e 100644 > > --- a/string/tester.c > > +++ b/string/tester.c > > @@ -1449,6 +1449,19 @@ test_bcmp (void) > > check(bcmp("abc", "def", 0) == 0, 8); /* Zero count. */ > > } > > > > +static void > > +test_memcmpeq (void) > > +{ > > + it = "__memcmpeq"; > > + check(__memcmpeq("a", "a", 1) == 0, 1); /* Identity. */ > > + check(__memcmpeq("abc", "abc", 3) == 0, 2); /* Multicharacter. */ > > + check(__memcmpeq("abcd", "abce", 4) != 0, 3); /* Honestly unequal. */ > > + check(__memcmpeq("abce", "abcd", 4) != 0, 4); > > + check(__memcmpeq("alph", "beta", 4) != 0, 5); > > + check(__memcmpeq("abce", "abcd", 3) == 0, 6); /* Count limited. */ > > + check(__memcmpeq("abc", "def", 0) == 0, 8); /* Zero count. */ > > Style: space before paren. Fixed. > > Andreas. > > -- > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 > "And now for something completely different."