From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <goldstein.w.n@gmail.com>
Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com
 [IPv6:2607:f8b0:4864:20::1132])
 by sourceware.org (Postfix) with ESMTPS id 6B201385741A
 for <libc-alpha@sourceware.org>; Wed, 27 Apr 2022 16:24:27 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6B201385741A
Received: by mail-yw1-x1132.google.com with SMTP id
 00721157ae682-2f83983782fso24811567b3.6
 for <libc-alpha@sourceware.org>; Wed, 27 Apr 2022 09:24:27 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=yCO9x+NnGcHHGYVgOSmq6Mq3dGUwyJRHsawadZd68Jk=;
 b=2Qzki/HjPC1co7MShxS5L9sttLKs4e9lGDlOLeaB2LsOHOPjVhrA362s46wwawGqkN
 Gyw5CweiEeKkMBLW2X4Ok4WmexvOJ9sleDVzvLxh3k6WApGmd1Ge4uqTYd+uyiz9QEb7
 rz3qCH9bRJDqpOjxr5NRtUw7kd+wGphWJpMcultKhng9JWtLlKObBHG6J5u1DDnKP26H
 C3HhPo3hOjyR/7eL9+ZDmRuRNC47i2MLW59q9gtRqfgaZ6XpVN7FgAbx6Q//Qp/br8YC
 CFV8aCqp/nvfwVDawEWSyP9SrpcywRqRBjN3tlCrJE4Z4Os3L5HyzDq0NcSid+Vx9x9n
 CxUg==
X-Gm-Message-State: AOAM533RetXs6eNRblI6tL1wUknWFQ1KjptFOnUhioBKSp5OIWxVZ/2V
 xRH0EBSUUMRwVweXfjvVei54pMtglzgPky7RYHs=
X-Google-Smtp-Source: ABdhPJxk/G+n1Qbc7I1+aI72qdBl2/RMD3XvMaQpw2mXm0+1ctyE3huIDiTZFTEALwdopxjz6koRwkdi6Ir1100B/Kw=
X-Received: by 2002:a05:690c:d:b0:2d0:e02a:6cda with SMTP id
 bc13-20020a05690c000d00b002d0e02a6cdamr29800408ywb.192.1651076666937; Wed, 27
 Apr 2022 09:24:26 -0700 (PDT)
MIME-Version: 1.0
References: <20220414041231.926415-1-goldstein.w.n@gmail.com>
 <20220425163601.3670626-1-goldstein.w.n@gmail.com>
 <20220425163601.3670626-3-goldstein.w.n@gmail.com>
 <87mtg6izdr.fsf@oldenburg.str.redhat.com>
In-Reply-To: <87mtg6izdr.fsf@oldenburg.str.redhat.com>
From: Noah Goldstein <goldstein.w.n@gmail.com>
Date: Wed, 27 Apr 2022 11:24:16 -0500
Message-ID: <CAFUsyfK5dpuGgYpn7JQicG_Cp-WhepTMPmX190_Z-0iTqUq6Bg@mail.gmail.com>
Subject: Re: [PATCH v3 3/6] nss: Add tests for the nss_hash in nss_hash.h
To: Florian Weimer <fweimer@redhat.com>
Cc: Noah Goldstein via Libc-alpha <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Apr 2022 16:24:28 -0000

On Wed, Apr 27, 2022 at 5:39 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * Noah Goldstein via Libc-alpha:
>
> > diff --git a/nss/Makefile b/nss/Makefile
> > index d8b06b44fb..a978e3927a 100644
>
> > +static int
> > +do_fill_tests (size_t len, int fill)
> > +{
> > +  uint32_t expec, res;
> > +  char buf[len];
> > +  memset (buf, fill, len);
> > +
> > +  expec = simple_nss_hash (buf, len);
> > +  res = __nss_hash (buf, len);
> > +  if (expec != res)
> > +    {
> > +      printf ("FAIL: fill(%d) (%zu), %x != %x\n", fill, len, expec, res);
> > +      return 1;
>
> You could use FAIL_EXIT1 here.

Fixed in V4.
>
> Thanks,
> Florian
>