public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH v2] x86-64: Use YMM registers in memcmpeq-evex.S
@ 2023-06-01 15:53 H.J. Lu
  2023-06-01 16:08 ` Noah Goldstein
  0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2023-06-01 15:53 UTC (permalink / raw)
  To: libc-alpha; +Cc: Noah Goldstein, Sunil K Pandey, Florian Weimer

Since the assembly source file with -evex suffix should use YMM registers,
not ZMM registers, include x86-evex256-vecs.h by default to use YMM
registers in memcmpeq-evex.S
---
 sysdeps/x86_64/multiarch/memcmpeq-evex.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sysdeps/x86_64/multiarch/memcmpeq-evex.S b/sysdeps/x86_64/multiarch/memcmpeq-evex.S
index 3666f649cd..7eefff77f1 100644
--- a/sysdeps/x86_64/multiarch/memcmpeq-evex.S
+++ b/sysdeps/x86_64/multiarch/memcmpeq-evex.S
@@ -42,7 +42,7 @@
 # endif
 
 # ifndef VEC_SIZE
-#  include "x86-evex512-vecs.h"
+#  include "x86-evex256-vecs.h"
 # endif
 # include "reg-macros.h"
 
-- 
2.40.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] x86-64: Use YMM registers in memcmpeq-evex.S
  2023-06-01 15:53 [PATCH v2] x86-64: Use YMM registers in memcmpeq-evex.S H.J. Lu
@ 2023-06-01 16:08 ` Noah Goldstein
  0 siblings, 0 replies; 2+ messages in thread
From: Noah Goldstein @ 2023-06-01 16:08 UTC (permalink / raw)
  To: H.J. Lu; +Cc: libc-alpha, Sunil K Pandey, Florian Weimer

On Thu, Jun 1, 2023 at 10:53 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> Since the assembly source file with -evex suffix should use YMM registers,
> not ZMM registers, include x86-evex256-vecs.h by default to use YMM
> registers in memcmpeq-evex.S
> ---
>  sysdeps/x86_64/multiarch/memcmpeq-evex.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86_64/multiarch/memcmpeq-evex.S b/sysdeps/x86_64/multiarch/memcmpeq-evex.S
> index 3666f649cd..7eefff77f1 100644
> --- a/sysdeps/x86_64/multiarch/memcmpeq-evex.S
> +++ b/sysdeps/x86_64/multiarch/memcmpeq-evex.S
> @@ -42,7 +42,7 @@
>  # endif
>
>  # ifndef VEC_SIZE
> -#  include "x86-evex512-vecs.h"
> +#  include "x86-evex256-vecs.h"
>  # endif
>  # include "reg-macros.h"
>
> --
> 2.40.1
>

LGTM.

Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-01 16:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-01 15:53 [PATCH v2] x86-64: Use YMM registers in memcmpeq-evex.S H.J. Lu
2023-06-01 16:08 ` Noah Goldstein

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).