From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id 3280A3858401 for ; Thu, 1 Jun 2023 16:08:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3280A3858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ot1-x329.google.com with SMTP id 46e09a7af769-6af549a7fb4so1538720a34.1 for ; Thu, 01 Jun 2023 09:08:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685635726; x=1688227726; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zmI3T2uIrQaRExY/30MD7fZud9+vWwSZnZLUzcNZ3i4=; b=sOl+F8Vj4W01jSk0ifRy3T8qAV3kJuFDBVp6eT83QhooqPDrQSaJWerDBrf3A0639M vaHRj04eotPorlPi8ioruTP9JFI0uhmy8OKWGnMZKV+urRM37rYSWBKawckFH2cPU0IC CRp5gti7z+m0UOKQm4tZzlk9BX4vU39lvPfJC4g6LWgzpC2Mvd1XaYe4Xk7erY1EPbHH QnRJJBhB2p1ak4C/blorWJVeFIYp5eY+YIUytbpNV2Cz0XsOwAWuQ88AXcIb2udF5nHf LXidGWmiCYWUmEPwMjO05nhRy/if6p30hC7AcqWPiVMiZrxEyoy0nbp2GNjA0nu3queM gmKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685635726; x=1688227726; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zmI3T2uIrQaRExY/30MD7fZud9+vWwSZnZLUzcNZ3i4=; b=Yid60cFU4bXmrJWJ+iPI9hq/8gAEJMrPadyKnKV8vRMwH9HjPMzKjVQCEteh8LZhcY XQslkvIp6I0MLnqnqNsm9gMmIRYfdC+5ykFRB2cPxiXt7Yvkwea9TzsAOd68b1svlrfQ 6PhC9cKeCipLAXbHnuRInX2h0tSLOZZfryGJUMvMVadux6ZsDrjpsXWs7rEXAAQIRyk9 w8K87LODa65M31f/SENbtBAxtcmnJ+MGNTtsqGf1Ua/eQLjOF2LUgc5PCtJ0FB9wL9sq se6dc8ipZ/qLI3BD3A68IJT8OfFeCaNk9yVOk2neVMGNzekY8AT9nQNXn4grd4fb4+lL tonQ== X-Gm-Message-State: AC+VfDzSPHAQj8MyzQhjmmU9t2mDXE20SO3gzywC3zCy2eDKoMzyG2lx /e88+dyif8OGfx29bc+0rGtYbr2HAoGsvkvctTs= X-Google-Smtp-Source: ACHHUZ6cltyuvhEr2GLyiOA4yqZwJdKa7lKV52Bq6/R3Vct/JKCH/bE6bmZD5ljlmQ62kWXecg95KlwYH4PyIgmpoj0= X-Received: by 2002:aca:f354:0:b0:398:1fe2:b3bf with SMTP id r81-20020acaf354000000b003981fe2b3bfmr1077632oih.13.1685635726473; Thu, 01 Jun 2023 09:08:46 -0700 (PDT) MIME-Version: 1.0 References: <20230601155335.71684-1-hjl.tools@gmail.com> In-Reply-To: <20230601155335.71684-1-hjl.tools@gmail.com> From: Noah Goldstein Date: Thu, 1 Jun 2023 11:08:34 -0500 Message-ID: Subject: Re: [PATCH v2] x86-64: Use YMM registers in memcmpeq-evex.S To: "H.J. Lu" Cc: libc-alpha@sourceware.org, Sunil K Pandey , Florian Weimer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Jun 1, 2023 at 10:53=E2=80=AFAM H.J. Lu wrote= : > > Since the assembly source file with -evex suffix should use YMM registers= , > not ZMM registers, include x86-evex256-vecs.h by default to use YMM > registers in memcmpeq-evex.S > --- > sysdeps/x86_64/multiarch/memcmpeq-evex.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sysdeps/x86_64/multiarch/memcmpeq-evex.S b/sysdeps/x86_64/mu= ltiarch/memcmpeq-evex.S > index 3666f649cd..7eefff77f1 100644 > --- a/sysdeps/x86_64/multiarch/memcmpeq-evex.S > +++ b/sysdeps/x86_64/multiarch/memcmpeq-evex.S > @@ -42,7 +42,7 @@ > # endif > > # ifndef VEC_SIZE > -# include "x86-evex512-vecs.h" > +# include "x86-evex256-vecs.h" > # endif > # include "reg-macros.h" > > -- > 2.40.1 > LGTM. Reviewed-by: Noah Goldstein