From: Noah Goldstein <goldstein.w.n@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>,
"H.J. Lu" <hjl.tools@gmail.com>,
Sunil K Pandey <skpgkp2@gmail.com>
Subject: Re: [PATCH] x86-64: Use YMM registers in memcmpeq-evex.S
Date: Thu, 1 Jun 2023 10:44:21 -0500 [thread overview]
Message-ID: <CAFUsyfKL-D=cdU5qd2a9pakm7GdpVgtFcDzHs0RvzSmib6DY-Q@mail.gmail.com> (raw)
In-Reply-To: <87pm6f20zu.fsf@oldenburg.str.redhat.com>
On Thu, Jun 1, 2023 at 12:41 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * H. J. Lu via Libc-alpha:
>
> > Include x86-evex256-vecs.h by default to use YMM registers in
> > memcmpeq-evex.S.
Should we create an evex512 impl?
> > ---
> > sysdeps/x86_64/multiarch/memcmpeq-evex.S | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sysdeps/x86_64/multiarch/memcmpeq-evex.S b/sysdeps/x86_64/multiarch/memcmpeq-evex.S
> > index 3666f649cd..7eefff77f1 100644
> > --- a/sysdeps/x86_64/multiarch/memcmpeq-evex.S
> > +++ b/sysdeps/x86_64/multiarch/memcmpeq-evex.S
> > @@ -42,7 +42,7 @@
> > # endif
> >
> > # ifndef VEC_SIZE
> > -# include "x86-evex512-vecs.h"
> > +# include "x86-evex256-vecs.h"
> > # endif
> > # include "reg-macros.h"
>
> It would be nice if the commit message could describe the why, not just
> the what. 8-)
>
We use -evex.S postfix for 256-bit evex. This was mistakenly implemented as
evex512.
> Thanks,
> Florian
>
next prev parent reply other threads:[~2023-06-01 15:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 3:43 H.J. Lu
2023-06-01 5:41 ` Florian Weimer
2023-06-01 15:44 ` Noah Goldstein [this message]
2023-06-01 15:54 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFUsyfKL-D=cdU5qd2a9pakm7GdpVgtFcDzHs0RvzSmib6DY-Q@mail.gmail.com' \
--to=goldstein.w.n@gmail.com \
--cc=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=skpgkp2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).