From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <goldstein.w.n@gmail.com>
Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com
 [IPv6:2607:f8b0:4864:20::42e])
 by sourceware.org (Postfix) with ESMTPS id 641A9385801C
 for <libc-alpha@sourceware.org>; Sat,  5 Feb 2022 22:58:56 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 641A9385801C
Received: by mail-pf1-x42e.google.com with SMTP id v74so8359559pfc.1
 for <libc-alpha@sourceware.org>; Sat, 05 Feb 2022 14:58:56 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=lU9hjJtvYfuCkGNB8v+SXQe1B96+UVB5mBuGsK9KngE=;
 b=6r1+iuz83QAYCH6kBUOFqJ+FnpiXcaCpj00QFv2ImQVr4nBrbqzo8IlWAfBBPqgHYC
 EvrWtOKA2ke01TO9pJiOY0PFOXLXa0y2pIQGoYB9ErZge61RHp/R8ZsdIcd5vgr7PE89
 2650CChElRTlq4JTnCfOXrFtiXF1em8HU913UxqADUNnTNvrGsuj3+MGf2FlWiD/0rO3
 Ck5R34JiKIEi1ki9sRn5x9r1MisNVC81p0w2xwXpXEHwlcYdFgfMEOWKIirAFi+GhRq8
 gWCJitYsnAbKC/e92IFEgb38APEpMG7MuARPHLkYYLZDg90IPVA2ycmZVLSZxv6tjfuq
 djEg==
X-Gm-Message-State: AOAM532pzuqTAj7pS906O171QLSBXj0YRdzXNFa6RwCvjEwfe9P/vMiH
 /dgDPdU29h57OlWoU/l44PGJPFWvtjlVHnBazXiCHnWY
X-Google-Smtp-Source: ABdhPJyXIvAsnsiosENraKTDkAJMhc2BVyjfQ73S1gvoos/gQoODPPrDEcQTFTiQmowi1yTfnQn1MBris47peIjvHxQ=
X-Received: by 2002:a63:6a06:: with SMTP id f6mr4321280pgc.18.1644101935631;
 Sat, 05 Feb 2022 14:58:55 -0800 (PST)
MIME-Version: 1.0
References: <20220205091044.2014455-1-goldstein.w.n@gmail.com>
 <CAMe9rOotFu3YsRgkbHw=wDJwF7owyis-ETD8bd8CDbY3zSf-fQ@mail.gmail.com>
In-Reply-To: <CAMe9rOotFu3YsRgkbHw=wDJwF7owyis-ETD8bd8CDbY3zSf-fQ@mail.gmail.com>
From: Noah Goldstein <goldstein.w.n@gmail.com>
Date: Sat, 5 Feb 2022 16:58:44 -0600
Message-ID: <CAFUsyfKPfRrxaYKA9OUxk71r_tVALHsWr=r208odwHyq8k012g@mail.gmail.com>
Subject: Re: [PATCH v1] Benchtests: move 'alloc_bufs' from loop in
 bench-memset.c
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
 "Carlos O'Donell" <carlos@systemhalted.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Feb 2022 22:58:57 -0000

On Sat, Feb 5, 2022 at 11:29 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Sat, Feb 5, 2022 at 1:10 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > One buf allocation is sufficient. Calling `alloc_bufs' in the loop
> > just adds unnecessary syscall overhead.
> > ---
> >  benchtests/bench-memset.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/benchtests/bench-memset.c b/benchtests/bench-memset.c
> > index beba3fbe46..e1e2d5f176 100644
> > --- a/benchtests/bench-memset.c
> > +++ b/benchtests/bench-memset.c
> > @@ -74,7 +74,6 @@ do_test (json_ctx_t *json_ctx, size_t align, int c, size_t len)
> >    FOR_EACH_IMPL (impl, 0)
> >      {
> >        do_one_test (json_ctx, impl, (CHAR *) (buf1) + align, c, len);
> > -      alloc_bufs ();
> >      }
> >
> >    json_array_end (json_ctx);
> > @@ -88,8 +87,9 @@ test_main (void)
> >    size_t i;
> >    int c = 0;
> >
> > -  test_init ();
> >
> > +  test_init ();
> > +  alloc_bufs ();
> >    json_init (&json_ctx, 0, stdout);
> >
> >    json_document_begin (&json_ctx);
> > --
> > 2.25.1
> >
>
> LGTM.
>
> Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
>
> Thanks.

Thanks pushed.
>
> --
> H.J.