From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=YAzg=4L=gmail.com=goldstein.w.n@sourceware.org>
Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633])
	by sourceware.org (Postfix) with ESMTPS id AD99B3871FB2
	for <libc-alpha@sourceware.org>; Tue, 13 Dec 2022 19:08:29 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AD99B3871FB2
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-ej1-x633.google.com with SMTP id ud5so38975136ejc.4
        for <libc-alpha@sourceware.org>; Tue, 13 Dec 2022 11:08:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=jm8jAuQgCZX1oHg5dqmGtlJNNbTISVJ/9ReNBIC2MGs=;
        b=JS+u7qAI2AVN+3sJR+cjcq0eFqxv9OU/jbcKYMM73zj6nWFL0I5q9uvzEXYbJYxOyy
         Qxzctm5s78cI5Ya02knwedi6qdon4cvDmFyvQwkKtMRO0udfEI0OXf88JyduKilqtQZp
         F3XveS5u9Mktmi/fhZYanzOnAzpbrl0UZx8p74j8udVPHdbzvCyqPHLJQf85Rdj0dr45
         Yjo4ooEGtGSvhmXVAwKBbjObiHKuyWd5/6s054tMl0vzoqTLYTsb3eqLj/XuiXvTK8mI
         sKhQ7C8/SmH7YReaQep4IpuCe1jc63g/FjDqUyZ7gIttC3/CiMEY4V1MYqXPFTtu5HX0
         u9lA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=jm8jAuQgCZX1oHg5dqmGtlJNNbTISVJ/9ReNBIC2MGs=;
        b=x/AIuQSL+a+fo8cHWO/RU/BKjFlTnOGvC6jSBmzfoCSh4JIXAGdrpkXbY+zHZHRhyd
         S1Y6AVJeLuae/qyGrM9DEXpZlD/LXfdEwIu1iURhZy19DAHxLsTF3KISnDB2MuXy5645
         fN4ItjBPc2l27KY4wyFAEJzS+zEcepUm8N1q7CuxAe4itkxTO1oD9wZ6e1zCtxWmzREC
         +T0V3cclOczDb3TG05zLMGh6Nn8vzAlJe8Z8cac5bvFROqZOGeMOH6KaGLyR3hfupr0w
         C/UWkSwgwkd+t/xSqlLKbINoTrEGf7zYgwMBkSFmCpazjlTbE0KkOR2objFOH46sHSqR
         SJYw==
X-Gm-Message-State: ANoB5pnY36wKj6AJZLVfICuXhFA9MX7HNNDFYcGdL2mC6nAMggMvzI7g
	e2Se/ZfIFa45LugbrzhnGZ44EZaiELkzvhZnM38pk6C4Dl8=
X-Google-Smtp-Source: AA0mqf50YI94GPVmMGnXk83vVqkQdcIg+y/TjQgRQgzx10RMAlB2fgou/mW5k8erT/zOGtcGEjDY41UoIVeuhYtXCMc=
X-Received: by 2002:a17:906:d963:b0:7c1:98f:be57 with SMTP id
 rp3-20020a170906d96300b007c1098fbe57mr10392211ejb.97.1670958508349; Tue, 13
 Dec 2022 11:08:28 -0800 (PST)
MIME-Version: 1.0
References: <0a1f01d90f1f$96c7ce60$c4576b20$@yottadb.com>
In-Reply-To: <0a1f01d90f1f$96c7ce60$c4576b20$@yottadb.com>
From: Noah Goldstein <goldstein.w.n@gmail.com>
Date: Tue, 13 Dec 2022 11:08:09 -0800
Message-ID: <CAFUsyfKXSTCkLsAVGb+8T0nVPZPq_UykNAWNyCuBGTEQXdbJfw@mail.gmail.com>
Subject: Re: Bug 29863 - Segmentation fault in memcmp-sse2.S if memory
 contents can concurrently change
To: Narayanan Iyer <nars@yottadb.com>
Cc: libc-alpha@sourceware.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

On Tue, Dec 13, 2022 at 10:20 AM Narayanan Iyer via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Hi,
>
> I had created a glibc bug report at https://sourceware.org/bugzilla/show_bug.cgi?id=29863
>
> And have included the title of that report in the email subject as well.
>
> It has been a week since I created the issue and I did not hear anything back. I believe this is a regression in glibc 2.36 and have provided enough information in the bug report (along with the commit that caused the regression).
>
> Given the upcoming glibc 2.37 release, I was asked (by Carlos O'Donell <carlos@redhat.com>) to raise it on this mailing list to get the attention of the glibc developers.
>
> I am hoping one of you could take a quick look at the bug report and see if it is worth fixing it in time for glibc 2.37.
>
> Thanks,
> Narayanan.
>
>

The fix:
https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/x86_64/multiarch/memcmp-sse2.S;h=afd450d0206d6633da9fbc4607a7fa6aeb4e137c;hb=HEAD#l46
```
-#   define SIZE_OFFSET (CHAR_PER_VEC * 2)
+#   define SIZE_OFFSET 0
```

Is this something we have to support? I believe other functions /
implementations
of memcmp will suffer from a similar bug.