From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by sourceware.org (Postfix) with ESMTPS id 934113858416 for ; Thu, 28 Oct 2021 21:36:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 934113858416 Received: by mail-pj1-x1035.google.com with SMTP id s10-20020a17090a6e4a00b001a5f4da9892so1812239pjm.3 for ; Thu, 28 Oct 2021 14:36:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ybzpfp3/j0E2FPkR+czdVeQp05giyZ/u0RdgxqT8qHk=; b=vn1aTL4rSLb5B1xuvrKphkFK1OKsrh5fME6RJoFega0WkFbqgJHEKvwy8OdpE2il0d HNiEX0tudRospFmGwr8RMqlFxjLFM++PRGhRKIUxNA2GWhdYYbd6tyWH5cAQDLuO3aG6 1ILz+dWaTdm16sX0GboZDaRzczemONGsoc7J8Wz/jOozn3cdZ+0PJYrl/HS1rwaqcXTw 0C7MfDagtm3H2axWZzwAoJdqL15kUDdknH4JmLEWAlJ1dCdAOr98qlld2WTCv0uH6oPM bfcVUMan14hUNQ5tXG8xPmFyPAI2SG7VL+lsprJuDdVTfEU1h4fxBdGRJKx5T71LOJpg 5v7Q== X-Gm-Message-State: AOAM530in6+hdrWhCiqk4Iuw7KkDx0f7mL+CuUJaEC+kSALZTGNF1ueK H4o6CiwBxo+zxOnPzlOpakxXMNqsykBa7gdsXRw= X-Google-Smtp-Source: ABdhPJx0e9N4N7qU7w8ku/bAqzKQu6WH+bcoFizI0BzVlXhE46uv5z+jZVVK63IEkduIVCOqDvkR6WRQWHfTGGtLO+8= X-Received: by 2002:a17:90a:6b0b:: with SMTP id v11mr7272901pjj.178.1635457009778; Thu, 28 Oct 2021 14:36:49 -0700 (PDT) MIME-Version: 1.0 References: <20211028194738.82344-1-goldstein.w.n@gmail.com> <20211028211026.2430103-1-goldstein.w.n@gmail.com> In-Reply-To: From: Noah Goldstein Date: Thu, 28 Oct 2021 16:36:39 -0500 Message-ID: Subject: Re: [PATCH v2] x86_64: Add memcmpeq.S to fix disable-multi-arch build To: "H.J. Lu" Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Oct 2021 21:36:53 -0000 On Thu, Oct 28, 2021 at 4:14 PM H.J. Lu wrote: > > On Thu, Oct 28, 2021 at 2:10 PM Noah Goldstein via Libc-alpha > wrote: > > > > The following commit: > > > > commit cf4fd28ea453d1a9cec93939bc88b58ccef5437a > > Author: Noah Goldstein > > Date: Tue Oct 26 19:43:18 2021 -0500 > > > > Broke --disable-multi-arch build for x86_64 because x86_64/memcmpeq.S > > was not defined outside of multiarch and the alias for __memcmpeq in > > x86_64/memcmp.S was removed. > > > > This commit fixes that issue by adding x86_64/memcmpeq.S. > > > > make xcheck passes on x86_64 with and without --disable-multi-arch > > --- > > sysdeps/x86_64/memcmpeq.S | 21 +++++++++++++++++++++ > > 1 file changed, 21 insertions(+) > > create mode 100644 sysdeps/x86_64/memcmpeq.S > > > > diff --git a/sysdeps/x86_64/memcmpeq.S b/sysdeps/x86_64/memcmpeq.S > > new file mode 100644 > > index 0000000000..db1756915d > > --- /dev/null > > +++ b/sysdeps/x86_64/memcmpeq.S > > @@ -0,0 +1,21 @@ > > +/* __memcmpeq optimized with SSE2. > > + Copyright (C) 2017-2021 Free Software Foundation, Inc. > > + This file is part of the GNU C Library. > > + > > + The GNU C Library is free software; you can redistribute it and/or > > + modify it under the terms of the GNU Lesser General Public > > + License as published by the Free Software Foundation; either > > + version 2.1 of the License, or (at your option) any later version. > > + > > + The GNU C Library is distributed in the hope that it will be useful, > > + but WITHOUT ANY WARRANTY; without even the implied warranty of > > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > + Lesser General Public License for more details. > > + > > + You should have received a copy of the GNU Lesser General Public > > + License along with the GNU C Library; if not, see > > + . */ > > + > > +#define memcmp __memcmpeq > > +#define USE_AS_MEMCMPEQ 1 > > +#include "multiarch/memcmp-sse2.S" > > -- > > 2.25.1 > > > > LGTM. Thanks. Pushed. > > Reviewed-by: H.J. Lu > > Thanks. > > -- > H.J.