From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id 27DC2385B83B for ; Tue, 5 Oct 2021 16:33:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 27DC2385B83B Received: by mail-pf1-x42c.google.com with SMTP id g14so32297pfm.1 for ; Tue, 05 Oct 2021 09:33:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jLcjT+lrIuqApcgS9aUFgwxwMhVfwPbNg49FeZo9s3Q=; b=E2yB0qoA7CuWGGkYIOQrADiQxh2gJ3WtSTe+5h1GPZBTYM+iZRl1rXTvjFNrEc08CM L58GtaYVH3vEuIk+B/IgHlTMPLk4vMa7l7/N4cSVN2BI7ow55KTDiIRw/xzR2Fsq/3AR Aq9cK9JY0Xz2HlWn4sfQUX9GxN4pgvQJeR6byAHxgtzo8km3yyHxEzHY3p78LJxLyKl5 hqesBwdYBuMLeTAwKkxYW5KjzVSxO+/WvTK4bR0z/ECUenGjJGnxuN2jMCYfzzym5/wm XuBFRTAIGddouA/HnJk0/5xYVuxc34ZfFArIMziHjRGhgI5EMJgmusHjMBsKUcoueoJt ECQw== X-Gm-Message-State: AOAM531ZGDl/VUqSexoz6hme1WY0K2WDl/KMx9wd6YdmuT8FhH1473m7 d0/RXrdQwZoLoBv0n1V5vKQfjv8hZrEDSGZGwqHL98cp X-Google-Smtp-Source: ABdhPJzUlQT84QMpH56GIE6WZDQ+utHS/41aPbDEeHDzfIBDMmB7EqVgC7Xl+MHKYlMM5kZarUMCDCouQcmv1xUWULQ= X-Received: by 2002:aa7:9735:0:b0:44c:619f:29fc with SMTP id k21-20020aa79735000000b0044c619f29fcmr11813657pfg.79.1633451602124; Tue, 05 Oct 2021 09:33:22 -0700 (PDT) MIME-Version: 1.0 References: <20210926205306.900081-1-goldstein.w.n@gmail.com> In-Reply-To: <20210926205306.900081-1-goldstein.w.n@gmail.com> From: Noah Goldstein Date: Tue, 5 Oct 2021 11:33:11 -0500 Message-ID: Subject: Re: [PATCH v1 1/3] benchtests: Add medium cases and increase iters in bench-memset.c To: GNU C Library X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2021 16:33:25 -0000 On Sun, Sep 26, 2021 at 3:53 PM Noah Goldstein wrote: > No bug. > > This commit adds new medium size cases for lengths in [512, 1024). As > well it increase the iters to INNER_LOOP_ITERS_LARGE for more reliable > results. > > Signed-off-by: Noah Goldstein > --- > benchtests/bench-memset.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/benchtests/bench-memset.c b/benchtests/bench-memset.c > index d6619b4836..4284cb1724 100644 > --- a/benchtests/bench-memset.c > +++ b/benchtests/bench-memset.c > @@ -43,7 +43,7 @@ static void > do_one_test (json_ctx_t *json_ctx, impl_t *impl, CHAR *s, > int c __attribute ((unused)), size_t n) > { > - size_t i, iters = INNER_LOOP_ITERS; > + size_t i, iters = INNER_LOOP_ITERS_LARGE; > timing_t start, stop, cur; > > TIMING_NOW (start); > @@ -118,7 +118,7 @@ test_main (void) > if (i & (i - 1)) > do_test (&json_ctx, 0, c, i); > } > - for (i = 32; i < 512; i+=32) > + for (i = 32; i < 1024; i+=32) > { > do_test (&json_ctx, 0, c, i); > do_test (&json_ctx, i, c, i); > -- > 2.25.1 > > ping (for the patchset).