From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id 302EE3858D1E for ; Mon, 3 Oct 2022 21:11:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 302EE3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52b.google.com with SMTP id u21so12105002edi.9 for ; Mon, 03 Oct 2022 14:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=wdKu8UeJYtjVR23iGxfpKv8BHatKMiUFhTcZw5F3FTw=; b=dihKr0kAZGLx7dZchfDL4638g73g4caYZ8dU/VSUlRQ2DzIE+sIIunh6mjEkChR6J+ zBqDZUAker8ITGxUDK9/v7YPOEvKD25Rr8blyw8gYfD9lluLBjJCJwzYBZV2aTi1460+ cpxov8cC/OX0opJDc5s/AKMCAvbl4dm50u0Sgy/zPZMHSfofTVhq2kK5UOUqXfG8bJ41 HdlQUewA6IhKrCXauisQXBjc2ShCOmpSvJ3WoPr0HQm5EonF/m39xklF50niNEIQn/Ty 0rJ2z81rwdlcMW11T2Pvkm98qTSVaef6qrEBDhwsOkKyIlDmqkWwMPFKSNbOqkDyV2vq U+6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=wdKu8UeJYtjVR23iGxfpKv8BHatKMiUFhTcZw5F3FTw=; b=c8AtDel9rR94kT8DvugnziVmwTB2ari4H+dVJ3FFcNfQqdkiRqqTYvB+EmrW2znajH IOBXVP9MS7Hoc+/iJpT40XlH9lONTwN+PPDRsxnnSgkx5yXuUGdvY0pQ1Wft3mDPwS00 +tM3ASqbLHRjxDaCun0JLmN0AXOjpyclt65ojK4MEbZ8NVYmX1LA83zj90FsfCZ10LVq ++g/cvfIrqRyC6MZ+gg3pyE4shkt9aQN78Sf95E0R9R5H0T9AZBErhBM4G/FmQyYhnyo /yddTrY1OfCsaqAMsPjsVWUd+wBr9BqXCwSOjJ/SEPYZMBarn5vBaWDCN648bQD87bt1 wGxQ== X-Gm-Message-State: ACrzQf0CwP8ecHhnRQ9jmo4yANe3c+TirkGLSVDyE2zbh1n1VgI0Mq2P 4a7USToqrVt5p5o2Z5IDkL+3EA0tFP15B7LOyXY= X-Google-Smtp-Source: AMsMyM7ZjsmYlR94Z/t2WQgrTh5m8phjjG82yPTNDg2ITqg6E8QoyIrmFXyMDkpKduRVCvTTUiOL5OECTMNBhEKR36E= X-Received: by 2002:a05:6402:d05:b0:425:b7ab:776e with SMTP id eb5-20020a0564020d0500b00425b7ab776emr21211313edb.142.1664831486836; Mon, 03 Oct 2022 14:11:26 -0700 (PDT) MIME-Version: 1.0 References: <20221003195944.3274548-1-aurelien@aurel32.net> <20221003195944.3274548-2-aurelien@aurel32.net> In-Reply-To: <20221003195944.3274548-2-aurelien@aurel32.net> From: Noah Goldstein Date: Mon, 3 Oct 2022 14:11:15 -0700 Message-ID: Subject: Re: [PATCH v3 1/8] x86: include BMI1 and BMI2 in x86-64-v3 level To: Aurelien Jarno Cc: libc-alpha@sourceware.org, "H . J . Lu" , Sunil K Pandey Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Oct 3, 2022 at 12:59 PM Aurelien Jarno wrote: > > The "System V Application Binary Interface AMD64 Architecture Processor > Supplement" mandates the BMI1 and BMI2 CPU features for the x86-64-v3 > level. > --- > sysdeps/x86/get-isa-level.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sysdeps/x86/get-isa-level.h b/sysdeps/x86/get-isa-level.h > index 1ade78ab73..5b4dd5f062 100644 > --- a/sysdeps/x86/get-isa-level.h > +++ b/sysdeps/x86/get-isa-level.h > @@ -47,6 +47,8 @@ get_isa_level (const struct cpu_features *cpu_features) > isa_level |= GNU_PROPERTY_X86_ISA_1_V2; > if (CPU_FEATURE_USABLE_P (cpu_features, AVX) > && CPU_FEATURE_USABLE_P (cpu_features, AVX2) > + && CPU_FEATURE_USABLE_P (cpu_features, BMI1) > + && CPU_FEATURE_USABLE_P (cpu_features, BMI2) > && CPU_FEATURE_USABLE_P (cpu_features, F16C) > && CPU_FEATURE_USABLE_P (cpu_features, FMA) > && CPU_FEATURE_USABLE_P (cpu_features, LZCNT) > -- > 2.35.1 > LGTM. Reviewed-by: Noah Goldstein