From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id D8599385782A for ; Mon, 24 May 2021 03:15:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D8599385782A Received: by mail-pg1-x529.google.com with SMTP id t193so19072952pgb.4 for ; Sun, 23 May 2021 20:15:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=acMlQSExCqR//WL9uLmLjAzzpyaKcFH3sWiXnn03N7E=; b=Ru/AovuwAbhmAMNmYW7O+Vj5n2MnHPlgUnsNa2GZY9v2GXJITE2uzN1vPRym0DLG+b DwCuzZO5aDJ4VmyS1Mt2m4AJzNrADa7fxfCPPq3YfiEzqz3o4iONItsWhv0fST2mxtPN eNWEwrslmklcOVg/S7TZgmi+GlMDV61WJ5fuc8ACtag5jXx8xaDW5qj6rjAKL41ktOu7 uXBJbFfUDiK7v/vcRGhNpDrBbLKmQzWMjzGireqw0HfssL4HkpToSJ1sFaWp/C7MPOrF t2eMXKpZ1R7Y3SjiTamvKFN+Ahb9QjU7ORvI0vUI0hBLyYVPrQCM1D1dIvEy/QPD3XfD zGRw== X-Gm-Message-State: AOAM531si8sxY1OlCp8GhiH7ge/6ILMw3uKkRQ7J4Jam6bQrI8e/HVtB 7UIzCCyFEKiRyJ1mPAlumPv4mrw+9U9O7yBp6QE= X-Google-Smtp-Source: ABdhPJxHOWI6Q00cgGv4NFfJ+iNVI1qlJKzW7OShXj9u+4nKYQFTYCIqVI0YUXo4lG6bUVdb5GVI55GqA1/+VSYegUQ= X-Received: by 2002:a63:3dc5:: with SMTP id k188mr11076444pga.140.1621826156041; Sun, 23 May 2021 20:15:56 -0700 (PDT) MIME-Version: 1.0 References: <20210524013020.1869687-1-goldstein.w.n@gmail.com> <20210524013020.1869687-2-goldstein.w.n@gmail.com> In-Reply-To: From: Noah Goldstein Date: Sun, 23 May 2021 23:15:44 -0400 Message-ID: Subject: Re: [PATCH v1 2/2] x86: Improve memmove-vec-unaligned-erms.S To: "H.J. Lu" Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 May 2021 03:15:58 -0000 On Sun, May 23, 2021 at 9:45 PM H.J. Lu wrote: > > On Sun, May 23, 2021 at 6:30 PM Noah Goldstein wrote: > > > > This patch changes the condition for copy 4x VEC so that if length is > > exactly equal to 4 * VEC_SIZE it will use the 4x VEC case instead of > > 8x VEC case. > > > > Results For Skylake memcpy-avx2-erms > > size, al1 , al2 , Cur T , New T , Win , New / Cur > > 128 , 0 , 0 , 9.137 , 6.873 , New , 75.22 > > 128 , 7 , 0 , 12.933 , 7.732 , New , 59.79 > > 128 , 0 , 7 , 11.852 , 6.76 , New , 57.04 > > 128 , 7 , 7 , 12.587 , 6.808 , New , 54.09 > > > > Results For Icelake memcpy-evex-erms > > size, al1 , al2 , Cur T , New T , Win , New / Cur > > 128 , 0 , 0 , 9.963 , 5.416 , New , 54.36 > > 128 , 7 , 0 , 16.467 , 8.061 , New , 48.95 > > 128 , 0 , 7 , 14.388 , 7.644 , New , 53.13 > > 128 , 7 , 7 , 14.546 , 7.642 , New , 52.54 > > > > Results For Tigerlake memcpy-evex-erms > > size, al1 , al2 , Cur T , New T , Win , New / Cur > > 128 , 0 , 0 , 8.979 , 4.95 , New , 55.13 > > 128 , 7 , 0 , 14.245 , 7.122 , New , 50.0 > > 128 , 0 , 7 , 12.668 , 6.675 , New , 52.69 > > 128 , 7 , 7 , 13.042 , 6.802 , New , 52.15 > > > > Results For Skylake memmove-avx2-erms > > size, al1 , al2 , Cur T , New T , Win , New / Cur > > 128 , 0 , 32 , 6.181 , 5.691 , New , 92.07 > > 128 , 32 , 0 , 6.165 , 5.752 , New , 93.3 > > 128 , 0 , 7 , 13.923 , 9.37 , New , 67.3 > > 128 , 7 , 0 , 12.049 , 10.182 , New , 84.5 > > > > Results For Icelake memmove-evex-erms > > size, al1 , al2 , Cur T , New T , Win , New / Cur > > 128 , 0 , 32 , 5.479 , 4.889 , New , 89.23 > > 128 , 32 , 0 , 5.127 , 4.911 , New , 95.79 > > 128 , 0 , 7 , 18.885 , 13.547 , New , 71.73 > > 128 , 7 , 0 , 15.565 , 14.436 , New , 92.75 > > > > Results For Tigerlake memmove-evex-erms > > size, al1 , al2 , Cur T , New T , Win , New / Cur > > 128 , 0 , 32 , 5.275 , 4.815 , New , 91.28 > > 128 , 32 , 0 , 5.376 , 4.565 , New , 84.91 > > 128 , 0 , 7 , 19.426 , 14.273 , New , 73.47 > > 128 , 7 , 0 , 15.924 , 14.951 , New , 93.89 > > > > Signed-off-by: Noah Goldstein > > --- > > sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S > > index 5e4a071f16..d36cd288c7 100644 > > --- a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S > > +++ b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S > > @@ -420,7 +420,7 @@ L(more_2x_vec): > > cmpq $(VEC_SIZE * 8), %rdx > > ja L(more_8x_vec) > > cmpq $(VEC_SIZE * 4), %rdx > > - jb L(last_4x_vec) > > + jbe L(last_4x_vec) > > /* Copy from 4 * VEC to 8 * VEC, inclusively. */ > ^^^^^^^^^^^^^^^^^^^^ Please also update the comment to > "4 * VEC + 1" Fixed. > > > VMOVU (%rsi), %VEC(0) > > VMOVU VEC_SIZE(%rsi), %VEC(1) > > -- > > 2.25.1 > > > > Thanks. > > -- > H.J.