From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id DEE5E3858D39 for ; Fri, 8 Oct 2021 17:20:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DEE5E3858D39 Received: by mail-pg1-x52a.google.com with SMTP id s11so3716450pgr.11 for ; Fri, 08 Oct 2021 10:20:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pl16e4vcJdLOCDmMUsgjP6H348zYrBw//SM/I7kHzkk=; b=GcDG2Tyl6QgOzgBXJBBzwQ8pyrEET86gVR5+wJRn0E4s5ak52vkrdKBQTo658PN+3C 6X/uaorrdKhzHz/5PjlvgImS2tG1F7p67Nkk1dhP/nhin0oxaLY5/BosS76r0D56Q58+ mM+oV8ZPpam6Wphk3+6R4HZlCEZbNSw/ed6Csd05wkDMrhSqG+Vs/JSHb8KOZrQgd839 EBuMXBSaivkAxRs+rxBh+JrG0wGLIf8g87tfxjsS60TVCDs2tiuNSaYx9n+Gkvyl/Kq2 4E5zEY7ezh0qz1C6W9FyLimNcvlS+XfqYUl0R3KMUAhAg9i5BN2+N0nhs/EV5Lm7yo4/ BATw== X-Gm-Message-State: AOAM533FLzusKwFD15BhBGzQIz7mPenBY2wKMd6Fd176pDViWZUTLbcl o4smorLBD/en0wLiFgcWhFvqXcO0NyBQBQgaSj0s/p7R X-Google-Smtp-Source: ABdhPJyyjeXlQmbFNCo9jlOinzlFLo5l6/73agOTRE1pL2e5ojSYhhRlihKlwoIohtM2ejkSZxRRIbtZzA7NDDE+Jt4= X-Received: by 2002:a63:7d04:: with SMTP id y4mr5768439pgc.131.1633713619721; Fri, 08 Oct 2021 10:20:19 -0700 (PDT) MIME-Version: 1.0 References: <20210926205306.900081-1-goldstein.w.n@gmail.com> <20210926205306.900081-2-goldstein.w.n@gmail.com> In-Reply-To: From: Noah Goldstein Date: Fri, 8 Oct 2021 12:20:09 -0500 Message-ID: Subject: Re: [PATCH v1 2/3] x86: Modify ENTRY in sysdep.h so that p2align can be specified To: "H.J. Lu" Cc: GNU C Library , "Carlos O'Donell" X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Oct 2021 17:20:22 -0000 On Fri, Oct 8, 2021 at 9:27 AM H.J. Lu wrote: > On Sun, Sep 26, 2021 at 1:53 PM Noah Goldstein > wrote: > > > > No bug. > > > > This change adds a new macro ENTRY_P2ALIGN which takes a second > > argument, log2 of the desired function alignment. > > > > The old ENTRY(name) macro is just ENTRY_P2ALIGN(name, 4) so this > > doesn't affect any existing functionality. > > > > Signed-off-by: Noah Goldstein > > --- > > Note this is a duplicate of: > > [v2,1/2] x86: Modify ENTRY in sysdep.h so that p2align can be specified > > > https://patchwork.sourceware.org/project/glibc/patch/20210922051657.1655745-1-goldstein.w.n@gmail.com/ > > > > sysdeps/x86/sysdep.h | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/sysdeps/x86/sysdep.h b/sysdeps/x86/sysdep.h > > index cac1d762fb..937180c1bd 100644 > > --- a/sysdeps/x86/sysdep.h > > +++ b/sysdeps/x86/sysdep.h > > @@ -78,15 +78,18 @@ enum cf_protection_level > > #define ASM_SIZE_DIRECTIVE(name) .size name,.-name; > > > > /* Define an entry point visible from C. */ > > -#define ENTRY(name) > \ > > +#define ENTRY_P2ALIGN(name, alignment) > \ > > .globl C_SYMBOL_NAME(name); > \ > > .type C_SYMBOL_NAME(name),@function; > \ > > - .align ALIGNARG(4); > \ > > + .align ALIGNARG(alignment); > \ > > C_LABEL(name) > \ > > cfi_startproc; > \ > > _CET_ENDBR; > \ > > CALL_MCOUNT > > > > +/* Common entry 16 byte aligns. */ > > +#define ENTRY(name) ENTRY_P2ALIGN (name, 4) > > + > > #undef END > > #define END(name) > \ > > cfi_endproc; > \ > > -- > > 2.25.1 > > > > LGTM. > > Reviewed-by: H.J. Lu > > Thanks. > Thanks. Pushed. > > -- > H.J. >