From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) by sourceware.org (Postfix) with ESMTPS id 956723858D37 for ; Fri, 22 Apr 2022 18:07:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 956723858D37 Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-2ef4a241cc5so93734727b3.2 for ; Fri, 22 Apr 2022 11:07:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HajMHSRJT/FJatwknp6fceAF/tRDGZSYhC+SM+Cj/ms=; b=Vc9eYORV8JHbxUFSVXj85xNKSkOk+RQWC/FiZWilk0O2wt4Mhzbo9m+tOI/4GMlGmd QJseUnC3a2AXWc7LVWI5KueSuiGseZKOmzMG4JVi5lpXjBFczYkLQSECGcyyQob0uAFa r386r9Kzce9qhm1+bzV7X/evHq1oRNvICBe4Z+Nqt+yU5rEr1vld4odPY/nqLE8jUCkj XwrY2Sl+ybe3b8NrCd6mmb5463/Wy6LyAkieFQqgk1qhKuqB8iZhTJftzteMgTGHqHbQ SzXn61DuBqE4wrHImNQa2oNUj4NyzWFt/854MpZPXu6H4P9Is9a/xRrcInPTAtiHIqCg znfw== X-Gm-Message-State: AOAM530C8MN/aJJKcw+o75Q+yBrnM/BglFvyI55U6FQNt7XpVKGhNQEV nHyvTOLFVkVkH9VGdoMfWyySXBYu08kwJaxjuPQ= X-Google-Smtp-Source: ABdhPJwKQ3Tr1OS8Bcv58Zq/wat3QdD1e3C8hvKOyBhxUvTjrWoHMB3cWHAD65ryMAtcg77HQvJ7eozuJylK8inFMQk= X-Received: by 2002:a81:1f03:0:b0:2f4:c6c4:9177 with SMTP id f3-20020a811f03000000b002f4c6c49177mr6262263ywf.427.1650650827944; Fri, 22 Apr 2022 11:07:07 -0700 (PDT) MIME-Version: 1.0 References: <20220422175800.1262332-1-hjl.tools@gmail.com> In-Reply-To: <20220422175800.1262332-1-hjl.tools@gmail.com> From: Noah Goldstein Date: Fri, 22 Apr 2022 13:06:57 -0500 Message-ID: Subject: Re: [PATCH] x86-64: Fix SSE2 memcmp and SSSE3 memmove for x32 To: "H.J. Lu" Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2022 18:07:10 -0000 On Fri, Apr 22, 2022 at 12:58 PM H.J. Lu wrote: > > Clear the upper 32 bits in RDX (memory size) for x32 to fix > > FAIL: string/tst-size_t-memcmp > FAIL: string/tst-size_t-memcmp-2 > FAIL: string/tst-size_t-memcpy > FAIL: wcsmbs/tst-size_t-wmemcmp > > on x32 introduced by > > 8804157ad9 x86: Optimize memcmp SSE2 in memcmp.S > 26b2478322 x86: Reduce code size of mem{move|pcpy|cpy}-ssse3 > --- > sysdeps/x86_64/memcmp.S | 4 ++++ > sysdeps/x86_64/multiarch/memmove-ssse3.S | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/sysdeps/x86_64/memcmp.S b/sysdeps/x86_64/memcmp.S > index b153694048..5718a7da86 100644 > --- a/sysdeps/x86_64/memcmp.S > +++ b/sysdeps/x86_64/memcmp.S > @@ -46,6 +46,10 @@ > > .text > ENTRY(MEMCMP) > +# ifdef __ILP32__ > + /* Clear the upper 32 bits. */ > + movl %edx, %edx > +# endif > #ifdef USE_AS_WMEMCMP > /* Use 0xffff to test for mismatches on pmovmskb bitmask. Store > in ecx for code size. This is preferable to using `incw` as > diff --git a/sysdeps/x86_64/multiarch/memmove-ssse3.S b/sysdeps/x86_64/multiarch/memmove-ssse3.S > index 215583e7bd..310ff62b86 100644 > --- a/sysdeps/x86_64/multiarch/memmove-ssse3.S > +++ b/sysdeps/x86_64/multiarch/memmove-ssse3.S > @@ -27,6 +27,10 @@ ENTRY(MEMMOVE_CHK) > END(MEMMOVE_CHK) > > ENTRY_P2ALIGN(MEMMOVE, 6) > +# ifdef __ILP32__ > + /* Clear the upper 32 bits. */ > + movl %edx, %edx > +# endif > movq %rdi, %rax > L(start): > cmpq $16, %rdx > -- > 2.35.1 > LGTM.