From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id 965B03858D20 for ; Tue, 15 Feb 2022 12:59:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 965B03858D20 Received: by mail-lf1-x12f.google.com with SMTP id u20so8133621lff.2 for ; Tue, 15 Feb 2022 04:59:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wR0Z9oFhgE7zchFgNdn0zphykiFq9yTLZkW8i/zAoVA=; b=MWhfpMsNAd/aoYLezlSXmG3V0wEP+oEOcpcqJS0KUzfoX0+HBypqsTJ134RHWQ0HtZ NHrUhjV0xUI+UlKLJWZt/Ta5mQIcQ+uU5pCtiQF+JGEqQ9huWRtmllCagZV9fShvkmOQ 48fktzcO1Z7X4oICM655m1DWz6Zexb6kgb6jVom45dIZ+th+CdbA8mrxbwGahnw5wYKC zslLp/H2GAqHu0jcqmz6HtUdekyjZHdnkvSGL0HJ+CBEaQggrhsgQ1EkJaJHGc4CuCXL IReJG55BK4wRywE7JNx9YssYUGKJFtV2Zuc9k/Bp2q9ri2qqMNcJmQoeJ7xcnVtU6ByF P3LA== X-Gm-Message-State: AOAM5329NMz3XgoyoResl/zkpb+Rafj1EUm+0YBzVBlT6JQ4m2aMdWSG pqmL3chRQje7f+PdNpvf86hFCb9ar5mNIjWzxi2up3gU X-Google-Smtp-Source: ABdhPJwceN4Bcsrgy9A8lTsVl8dT4AZ02SAvktho2PcMwSpEPziZbYo/zgN75g13fd9DNRKQqfScC7xqtqmhUlF1qDY= X-Received: by 2002:a05:6512:3085:: with SMTP id z5mr3067009lfd.622.1644929947309; Tue, 15 Feb 2022 04:59:07 -0800 (PST) MIME-Version: 1.0 References: <20220109122946.2754917-1-goldstein.w.n@gmail.com> <20220110213540.1258344-1-goldstein.w.n@gmail.com> <20220110213540.1258344-5-goldstein.w.n@gmail.com> <87ilthv8s9.fsf@igel.home> <87y22dtg19.fsf@igel.home> <87tud1tf5d.fsf@igel.home> <87czjomgqn.fsf@igel.home> In-Reply-To: <87czjomgqn.fsf@igel.home> From: Noah Goldstein Date: Tue, 15 Feb 2022 06:58:55 -0600 Message-ID: Subject: Re: [PATCH v3 5/7] x86: Optimize strcmp-avx2.S To: Andreas Schwab Cc: "H.J. Lu" , Sunil K Pandey , Noah Goldstein via Libc-alpha Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Feb 2022 12:59:10 -0000 On Tue, Feb 15, 2022 at 6:55 AM Andreas Schwab wrote: > > #0 0x00007f4fd4a61df3 in __strncmp_avx2_w (a=0x55aaa1906ffa "tst-tlsmod%", > b=0x55aaa1940fed "tst-tls-manydynamic73mod", c=10) > at ../sysdeps/x86_64/multiarch/strncmp-avx2_w.c:11 > 11 if (n1 != n2) asm("hlt"); I'll check that input thanks! One thing, your check has some false positives as all that matters is n1 / n2 have same zero/non-zero status or same sign. > > -- > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 > "And now for something completely different."