From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 487193858C2D for ; Tue, 16 Aug 2022 07:26:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 487193858C2D Received: by mail-ej1-x62b.google.com with SMTP id k26so17333624ejx.5 for ; Tue, 16 Aug 2022 00:26:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=gxbpS2gUxfuN+I1AxRjCVgPPlROeoVDK2mhaPY5ZoOs=; b=3hJUwdIWNZdU/oX1pfw8O060vTGkCtVjqcUbY+Fdow1fRWa4nsITGDQaEzgm23xZEk jRYUeGW9gfwZ+6zkWeuwrkm883wbnqmrCKQ4opi/YX2abrXMDmwBBhdhAVysharK4nU1 KxRk9+xopGYaeVtF20N3zSujnPP1luyMG658NlEPLZpc6yzZrvS7ZZqRRUpjTWvgUb1v oa3rMmgVCnv7ssYWru7TjYYEudQOwUEWihwakITu1bLk15fUIiFr6zCPn8QZxKgDZJQz TFK01wiJeNyFE7d887aIih1avSPIFS0zaaWckqUGQIB5gTPTDBwV3cxGZbIdvQ+aHUTO /fcg== X-Gm-Message-State: ACgBeo0k8fwjZ6x9vUgHdSCmnSnLdRGt91cQbo/InmVhfBcW9u8p0sGX sAFZISf1C91cPOCOhU6W4l+9phR5PEd2dDvsJHE= X-Google-Smtp-Source: AA6agR7BEcBPDT+P6/40X/nkjUuMOKAR1P1/gpvalQmNba7dh/Xu7h5UZoJ1U5JQSpiYsUAlSVacYG/ToZ2og05LXok= X-Received: by 2002:a17:906:2bc7:b0:72f:dc70:a3c6 with SMTP id n7-20020a1709062bc700b0072fdc70a3c6mr12915301ejg.645.1660634794371; Tue, 16 Aug 2022 00:26:34 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Noah Goldstein Date: Tue, 16 Aug 2022 15:26:22 +0800 Message-ID: Subject: Re: [PATCH] Improve performance of libc locks To: Wilco Dijkstra Cc: "Carlos O'Donell" , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2022 07:26:39 -0000 On Tue, Aug 16, 2022 at 1:35 AM Wilco Dijkstra via Libc-alpha wrote: > > Hi Carlos, > > > This impacts all architectures. > > That was the goal indeed - we should add single-threaded optimizations in a > generic way. > > > If we don't have a benchmark that shows this specific base of ST vs MT and > > internal __libc_lock_lock-locks then we should add one. Improving the internal > > locking for our algorithms is always going to be a point of interest for IHVs. > > I can easily wrap my rand() microbench in json and add it to the benchtests. Think that would be good so we can easily measure on other architectures. > I think it would be harder to do more tests on internal locks/headers since they > are not easily usable from benchtest infrastructure (just including libc-lock.h > results in lots of errors...). > > Cheers, > Wilco