From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by sourceware.org (Postfix) with ESMTPS id 6ED353857340 for ; Wed, 20 Apr 2022 01:20:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6ED353857340 Received: by mail-yb1-xb35.google.com with SMTP id f38so256942ybi.3 for ; Tue, 19 Apr 2022 18:20:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=EaKFIjMSy7i/PRxdshpIMt2OmZU+BfV+H/ZjSUZpR88=; b=Px+uDeL7yt7jdksVJkHgj5x9EMbldf2Nfo3taqm7sX4I5eDu1zpX+M+xQkqM7DuiQ6 YtdAUZEvhPO9/u0Otr2h2GGTLTxFkvZM2hSc9EoUXakDdaWY5GMV1osH/46UwUrG7DM0 B/e/FKdb78uDMI7tzAHNvNNjJdWxcbT/5+Jr6Q26gEN5hzlymiZ68KMCRAYtpnnaRal/ XnlxtbyP4YI2oJ3bKUDtnHevVt6R1L3qiM74iuFjm4F5HgNWlbs79HuGCPhA5CT5QL8M ICwavmdD04oJjrrQaa1Gyvkf6nctmyYN/sFBStZqdxlp4VS1uS5o0zL5GhcJG2wWjCw3 pfKQ== X-Gm-Message-State: AOAM5312l3sVcr1vLiBvv/e6q75EXj7ptEOD0Df1stTi38HQg/6dow2Z 9rJZjlyMTReuDjFuZXrjnS1R89Vn/eLNOXykAfU= X-Google-Smtp-Source: ABdhPJyNyiW+fFsnlFPf9FjTsFuPUrMnfWMAor840SLeOYxrJraFxYb/bjLmKZTNCAPHdLs5rZu6s0W/PBVuRFNNPLw= X-Received: by 2002:a25:7544:0:b0:629:33a2:b142 with SMTP id q65-20020a257544000000b0062933a2b142mr18179891ybc.136.1650417602841; Tue, 19 Apr 2022 18:20:02 -0700 (PDT) MIME-Version: 1.0 References: <20220415055132.1257272-1-goldstein.w.n@gmail.com> <20220415172801.1525674-1-goldstein.w.n@gmail.com> In-Reply-To: From: Noah Goldstein Date: Tue, 19 Apr 2022 20:19:52 -0500 Message-ID: Subject: Re: [PATCH v3 1/3] x86: Optimize memcmp SSE2 in memcmp.S To: Joseph Myers Cc: "H.J. Lu" , GNU C Library Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2022 01:20:04 -0000 On Tue, Apr 19, 2022 at 5:56 PM Noah Goldstein wr= ote: > > On Tue, Apr 19, 2022 at 3:53 PM Noah Goldstein = wrote: > > > > On Tue, Apr 19, 2022 at 3:30 PM Joseph Myers = wrote: > > > > > > A recent commit, probably this one, broke the build for x86_64-linux-= gnu > > > --disable-multi-arch. > > > > > > /scratch/jmyers/glibc-bot/install/compilers/x86_64-linux-gnu/lib/gcc/= x86_64-glibc-linux-gnu/11.2.1/../../../../x86_64-glibc-linux-gnu/bin/ld: /s= cratch/jmyers/glibc-bot/build/glibcs/x86_64-linux-gnu-minimal/glibc/libc_pi= c.os: in function `internal_fnwmatch': > > > /scratch/jmyers/glibc-bot/src/glibc/posix/fnmatch_loop.c:513: undefin= ed reference to `__wmemcmp' > > > /scratch/jmyers/glibc-bot/install/compilers/x86_64-linux-gnu/lib/gcc/= x86_64-glibc-linux-gnu/11.2.1/../../../../x86_64-glibc-linux-gnu/bin/ld: /s= cratch/jmyers/glibc-bot/src/glibc/posix/fnmatch_loop.c:536: undefined refer= ence to `__wmemcmp' > > > /scratch/jmyers/glibc-bot/install/compilers/x86_64-linux-gnu/lib/gcc/= x86_64-glibc-linux-gnu/11.2.1/../../../../x86_64-glibc-linux-gnu/bin/ld: /s= cratch/jmyers/glibc-bot/src/glibc/posix/fnmatch_loop.c:704: undefined refer= ence to `__wmemcmp' > > > > > > https://sourceware.org/pipermail/libc-testresults/2022q2/009576.html > > > > Reproduced issue, think have fix. Testing it now. > > Posted a patch. Pushed fix. > > > > > > -- > > > Joseph S. Myers > > > joseph@codesourcery.com