From: Noah Goldstein <goldstein.w.n@gmail.com>
To: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v1] benchtests: Improve reliability of memcmp benchmarks
Date: Thu, 23 Sep 2021 10:48:26 -0500 [thread overview]
Message-ID: <CAFUsyfL7j-UMXXNou2hN5fy7aKcsJ8qi-Yfo2-__z=aDguU5Sg@mail.gmail.com> (raw)
In-Reply-To: <20210918213947.2426144-1-goldstein.w.n@gmail.com>
On Sat, Sep 18, 2021 at 4:39 PM Noah Goldstein <goldstein.w.n@gmail.com>
wrote:
> No bug. Remove reallocation of bufs between implementation tests. Move
> initialization outside of foreach implementation test loop. Increase
> iteration count.
>
> Generally before this commit was seeing a great deal of variability
> between runs. The goal of this commit is to make the results more
> reliable.
>
> Benchtests build and bench-memcmp succeeding.
> ---
> benchtests/bench-memcmp.c | 21 ++++++++++-----------
> 1 file changed, 10 insertions(+), 11 deletions(-)
>
> diff --git a/benchtests/bench-memcmp.c b/benchtests/bench-memcmp.c
> index 744c7ec5ba..0d6a93bf29 100644
> --- a/benchtests/bench-memcmp.c
> +++ b/benchtests/bench-memcmp.c
> @@ -63,7 +63,7 @@ static void
> do_one_test (json_ctx_t *json_ctx, impl_t *impl, const CHAR *s1,
> const CHAR *s2, size_t len, int exp_result)
> {
> - size_t i, iters = INNER_LOOP_ITERS8;
> + size_t i, iters = INNER_LOOP_ITERS_LARGE;
> timing_t start, stop, cur;
>
> TIMING_NOW (start);
> @@ -103,20 +103,19 @@ do_test (json_ctx_t *json_ctx, size_t align1, size_t
> align2, size_t len,
> json_attr_uint (json_ctx, "result", (double) exp_result);
> json_array_begin (json_ctx, "timings");
>
> - FOR_EACH_IMPL (impl, 0)
> - {
> - s1 = (CHAR *) (buf1 + align1);
> - s2 = (CHAR *) (buf2 + align2);
> + s1 = (CHAR *)(buf1 + align1);
> + s2 = (CHAR *)(buf2 + align2);
>
> - for (i = 0; i < len; i++)
> - s1[i] = s2[i] = 1 + (23 << ((CHARBYTES - 1) * 8)) * i % MAX_CHAR;
> + for (i = 0; i < len; i++)
> + s1[i] = s2[i] = 1 + (23 << ((CHARBYTES - 1) * 8)) * i % MAX_CHAR;
>
> - s1[len] = align1;
> - s2[len] = align2;
> - s2[len - 1] -= exp_result;
> + s1[len] = align1;
> + s2[len] = align2;
> + s2[len - 1] -= exp_result;
>
> + FOR_EACH_IMPL (impl, 0)
> + {
> do_one_test (json_ctx, impl, s1, s2, len, exp_result);
> - alloc_bufs ();
> }
>
> json_array_end (json_ctx);
> --
> 2.25.1
>
>
Going to check this in unless there are any objections.
next prev parent reply other threads:[~2021-09-23 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 21:39 Noah Goldstein
2021-09-23 15:48 ` Noah Goldstein [this message]
2021-10-08 19:40 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFUsyfL7j-UMXXNou2hN5fy7aKcsJ8qi-Yfo2-__z=aDguU5Sg@mail.gmail.com' \
--to=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).