From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 9A0303858D3C for ; Thu, 24 Mar 2022 19:18:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9A0303858D3C Received: by mail-pl1-x62f.google.com with SMTP id k6so5750996plg.12 for ; Thu, 24 Mar 2022 12:18:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BCFgRzWNSHOizSxMU6feUI2Lv9O9hWJytKbOULzhlb8=; b=CJ9I1HL3Txnsbzz6DDdaxV7PGoWTl4NIuwM5IDjdtHF2bIoi2SJYY/Y713SdcgBKag jI3K5QJZfWDxru2WMI4agsh097J47vT5ucqtHiEUUA9kEuWcltiLFSNnvK4c8RDEOLGH 9DaMmwJFkLQIFstv+9gOnRvKTgKY8Z2mj2Vc/lebOnA7l7Nh+fs4H0tUL8sZGYtNuwwa l7WkNZUFRtsYK4l/ULCPA5e8fFo1WFf1mS6vDABEnnGbMGGSYiNoHvah20YzebGqS0s/ ruuDyv2MPOy6OeVM0YNKU7GeYlmLQrIRduPt6N83sqMaZvpFFpwHMgey0OCGjobIn5UN CiDw== X-Gm-Message-State: AOAM532E9RmadgWfcsnkoghtx3fAb6Im7b53G04M49u2UYVbujmqZoQq SLH24hMUwbjO0E3+V4r2bstaief/n/6PK8CDL4qoaRqj X-Google-Smtp-Source: ABdhPJwzw5kfx1pzwmGiiKmWIyPqQnjn4iKKFPZXVZE2mPga2eZTSwWD6YvRoM4+/59PNPfc94W1Lkdsg9Kugliln9k= X-Received: by 2002:a17:90b:4c44:b0:1c7:1326:ec90 with SMTP id np4-20020a17090b4c4400b001c71326ec90mr19908935pjb.87.1648149532686; Thu, 24 Mar 2022 12:18:52 -0700 (PDT) MIME-Version: 1.0 References: <20220323215734.3927131-1-goldstein.w.n@gmail.com> <20220323215734.3927131-12-goldstein.w.n@gmail.com> In-Reply-To: From: Noah Goldstein Date: Thu, 24 Mar 2022 14:18:41 -0500 Message-ID: Subject: Re: [PATCH v1 12/23] x86: Fix fallback for wcsncmp_avx2 in strcmp-avx2.S [BZ #28896] To: "H.J. Lu" Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2022 19:18:55 -0000 On Thu, Mar 24, 2022 at 2:00 PM H.J. Lu wrote: > > On Wed, Mar 23, 2022 at 3:01 PM Noah Goldstein wrote: > > > > Overflow case for __wcsncmp_avx2_rtm should be __wcscmp_avx2_rtm not > > __wcscmp_avx2. > > > > All string/memory tests pass. > > --- > > sysdeps/x86_64/multiarch/strcmp-avx2.S | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S > > index 52ff5ad724..86a86b68e3 100644 > > --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S > > +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S > > @@ -122,7 +122,7 @@ ENTRY(STRCMP) > > are cases where length is large enough that it can never be a > > bound on valid memory so just use wcscmp. */ > > shrq $56, %rcx > > - jnz __wcscmp_avx2 > > + jnz OVERFLOW_STRCMP > > > > leaq (, %rdx, 4), %rdx > > # endif > > -- > > 2.25.1 > > > > Isn't it a bug? Is there a glibc bug? Should this also be fixed on release > branches? It is bug but no need for backport. > > -- > H.J.