From: Noah Goldstein <goldstein.w.n@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
Sunil K Pandey <skpgkp2@gmail.com>,
Noah Goldstein via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3 5/7] x86: Optimize strcmp-avx2.S
Date: Tue, 15 Feb 2022 07:32:15 -0600 [thread overview]
Message-ID: <CAFUsyfLK4UijysRnYZwUXWOt5E4TVqVo4tKx-mJjUj=W8yoV7w@mail.gmail.com> (raw)
In-Reply-To: <CAFUsyfJi8MZGDnmhmy8gyg-tVkCi12saobT59qukP2Nw3jD0gw@mail.gmail.com>
On Tue, Feb 15, 2022 at 7:09 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> On Tue, Feb 15, 2022 at 6:58 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > On Tue, Feb 15, 2022 at 6:55 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
> > >
> > > #0 0x00007f4fd4a61df3 in __strncmp_avx2_w (a=0x55aaa1906ffa "tst-tlsmod%",
> > > b=0x55aaa1940fed "tst-tls-manydynamic73mod", c=10)
> > > at ../sysdeps/x86_64/multiarch/strncmp-avx2_w.c:11
> > > 11 if (n1 != n2) asm("hlt");
> >
> > I'll check that input thanks!
> >
> > One thing, your check has some false positives as all that matters is
> > n1 / n2 have
> > same zero/non-zero status or same sign.
>
> Confirmed. Sorry for the bug, will ping back when fix is up.
Found a bug (hopefully the bug) in strncmp. Did you see this at all
in strcmp-avx2 or was it just the commit you were referencing?
> > >
> > > --
> > > Andreas Schwab, schwab@linux-m68k.org
> > > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
> > > "And now for something completely different."
next prev parent reply other threads:[~2022-02-15 13:32 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 12:29 [PATCH v1 1/5] x86: Optimize strcmp-avx2.S and fix for [BZ# 28755] Noah Goldstein
2022-01-09 12:29 ` [PATCH v1 2/5] x86: Optimize strcmp-evex.S " Noah Goldstein
2022-01-09 12:29 ` [PATCH v1 3/5] string: remove stupid_[strcmp, strncmp, wcscmp, wcsncmp] Noah Goldstein
2022-01-09 12:29 ` [PATCH v1 4/5] string: Improve coverage in test-strcmp.c and test-strncmp.c Noah Goldstein
2022-01-09 12:29 ` [PATCH v1 5/5] benchtests: Add more coverage for strcmp and strncmp benchmarks Noah Goldstein
2022-01-09 12:35 ` [PATCH v1 1/5] x86: Optimize strcmp-avx2.S and fix for [BZ# 28755] Noah Goldstein
2022-01-09 14:07 ` H.J. Lu
2022-01-10 0:29 ` Noah Goldstein
2022-01-10 0:27 ` [PATCH v2 1/7] x86: Fix __wcsncmp_avx2 in strcmp-avx2.S " Noah Goldstein
2022-01-10 0:27 ` [PATCH v2 2/7] x86: Fix __wcsncmp_evex in strcmp-evex.S " Noah Goldstein
2022-01-10 0:35 ` H.J. Lu
2022-01-10 0:27 ` [PATCH v2 3/7] string/test-str*cmp: remove stupid_[strcmp, strncmp, wcscmp, wcsncmp] Noah Goldstein
2022-01-10 0:37 ` H.J. Lu
2022-01-10 0:27 ` [PATCH v2 4/7] string: Improve coverage in test-strcmp.c and test-strncmp.c Noah Goldstein
2022-01-10 0:38 ` H.J. Lu
2022-01-10 2:51 ` Noah Goldstein
2022-01-10 0:27 ` [PATCH v2 5/7] x86: Optimize strcmp-avx2.S Noah Goldstein
2022-01-10 0:41 ` H.J. Lu
2022-01-10 1:06 ` Noah Goldstein
2022-01-10 1:58 ` H.J. Lu
2022-01-10 2:54 ` Noah Goldstein
2022-01-10 0:27 ` [PATCH v2 6/7] x86: Optimize strcmp-evex.S Noah Goldstein
2022-01-10 0:41 ` H.J. Lu
2022-01-10 0:27 ` [PATCH v2 7/7] benchtests: Add more coverage for strcmp and strncmp benchmarks Noah Goldstein
2022-01-10 0:34 ` [PATCH v2 1/7] x86: Fix __wcsncmp_avx2 in strcmp-avx2.S [BZ# 28755] H.J. Lu
2022-01-10 21:35 ` [PATCH v3 " Noah Goldstein
2022-01-10 21:35 ` [PATCH v3 2/7] x86: Fix __wcsncmp_evex in strcmp-evex.S " Noah Goldstein
2022-01-11 2:15 ` H.J. Lu
2022-01-26 22:04 ` H.J. Lu
2022-04-29 22:05 ` Sunil Pandey
2022-01-10 21:35 ` [PATCH v3 3/7] string/test-str*cmp: remove stupid_[strcmp, strncmp, wcscmp, wcsncmp] Noah Goldstein
2022-01-10 21:35 ` [PATCH v3 4/7] string: Improve coverage in test-strcmp.c and test-strncmp.c Noah Goldstein
2022-01-10 21:35 ` [PATCH v3 5/7] x86: Optimize strcmp-avx2.S Noah Goldstein
2022-02-14 14:10 ` Andreas Schwab
2022-02-14 18:23 ` H.J. Lu
2022-02-14 19:16 ` Andreas Schwab
2022-02-14 19:30 ` H.J. Lu
2022-02-14 19:35 ` Andreas Schwab
2022-02-14 20:59 ` H.J. Lu
2022-02-14 21:10 ` H.J. Lu
2022-02-15 11:11 ` Andreas Schwab
2022-02-15 12:55 ` Andreas Schwab
2022-02-15 12:58 ` Noah Goldstein
2022-02-15 13:09 ` Noah Goldstein
2022-02-15 13:32 ` Noah Goldstein [this message]
2022-02-15 13:37 ` Noah Goldstein
2022-02-15 16:33 ` Noah Goldstein
2022-02-14 23:42 ` Noah Goldstein
2022-02-15 10:43 ` Andreas Schwab
2022-02-15 11:22 ` Andreas Schwab
2022-02-15 11:28 ` Noah Goldstein
2022-02-15 12:24 ` Andreas Schwab
2022-01-10 21:35 ` [PATCH v3 6/7] x86: Optimize strcmp-evex.S Noah Goldstein
2022-01-10 21:35 ` [PATCH v3 7/7] benchtests: Add more coverage for strcmp and strncmp benchmarks Noah Goldstein
2022-01-11 2:15 ` [PATCH v3 1/7] x86: Fix __wcsncmp_avx2 in strcmp-avx2.S [BZ# 28755] H.J. Lu
2022-01-26 22:05 ` H.J. Lu
2022-01-27 4:29 ` H.J. Lu
2022-01-27 5:10 ` H.J. Lu
2022-01-27 5:52 ` Noah Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFUsyfLK4UijysRnYZwUXWOt5E4TVqVo4tKx-mJjUj=W8yoV7w@mail.gmail.com' \
--to=goldstein.w.n@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
--cc=skpgkp2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).