From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id C68E83858416 for ; Fri, 22 Oct 2021 01:01:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C68E83858416 Received: by mail-pg1-x52f.google.com with SMTP id t7so1818709pgl.9 for ; Thu, 21 Oct 2021 18:01:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6x9ZJvemmX00yuvUwWvd65GRbc63fDy6JhmTHN+lTYg=; b=mRhB/pFTKxRbKC1x0qJlHmNZDCFetMkhLgLB5+pdbUqoM+5il6zFmFa/t1dJ+Z75Ad Ly+0NSMdHQKTEH0nqmbSvLbdVY/pdXFMX8hN8CK8aYimqHnXSRWem+rZ0MH6qNhDsO4Q /4LNyoVg1+lukWIwauWZ2JmGot3BdH8cxqWCmzu3MZm4psWUspU5L0XdgrZAkW7fS8Xa RRA7iwcFTeKOLgJzwbIPNNqZ80agfItllTGtY71WYsKKDtUUyl3iXQhQRZjiWnsIGVaz hzok+YlX8Ysbb6NBfYGcNpt1Iv23tBKYInXpmenJjJq6dyMWICKE4N8ZVR86oYOU4j+U y9pA== X-Gm-Message-State: AOAM532eldceDm4mptpU7Nu7ZJTz8qLL+MZfBvnhyVJpma3843/gJ//k MPCiRZb4yF6HVocm3NBoFoE3m/SlJ0gE5qnkXCY= X-Google-Smtp-Source: ABdhPJxYX/48k1/jZVmATmkzijtsRaQ4nYSEX7V2kq5ImFPMIdaAcYr3u0De3aUq7OOZDpRQrOVPS5tJ1c+ZPniIkpI= X-Received: by 2002:a63:dc42:: with SMTP id f2mr7082821pgj.152.1634864503910; Thu, 21 Oct 2021 18:01:43 -0700 (PDT) MIME-Version: 1.0 References: <20210927203827.2852935-1-goldstein.w.n@gmail.com> <20211021223850.415607-1-goldstein.w.n@gmail.com> <20211021223850.415607-3-goldstein.w.n@gmail.com> In-Reply-To: From: Noah Goldstein Date: Thu, 21 Oct 2021 20:01:33 -0500 Message-ID: Subject: Re: [PATCH v8 3/3] String: Add tests for __memcmpeq To: "H.J. Lu" Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2021 01:01:46 -0000 On Thu, Oct 21, 2021 at 7:42 PM H.J. Lu wrote: > > On Thu, Oct 21, 2021 at 4:47 PM Noah Goldstein wrote: > > > > On Thu, Oct 21, 2021 at 5:58 PM H.J. Lu wrote: > > > > > > On Thu, Oct 21, 2021 at 3:40 PM Noah Goldstein wrote: > > > > > > > > No bug. > > > > > > > > This commit adds tests for the new function __memcmpeq. The new tests > > > > use the existing tests in 'test-memcmp.c' but relax the result > > > > requirement to only check for zero or non-zero returns. > > > > > > > > All string tests include test-memcmpeq are passing. > > > > --- > > > > Note at the momement for test-memcmpeq.c the > > > > tests only appear to do the generic versions. > > > > > > > > For example on x86_64 the output of test-memcmpeq.out is: > > > > > > > > > > > > ``` > > > > __memcmpeq simple_memcmp > > > > ``` > > > > > > > > whereas test-memcmp.out is: > > > > > > > > ``` > > > > simple_memcmp __memcmp_avx2_movbe > > > > __memcmp_evex_movbe __memcmp_sse4_1 __memcmp_ssse3 __memcmp_sse2 > > > > ``` > > > > > > > > So the test is not going through all available ifuncs. I'm not > > > > sure if this is expected or indicates a bug in the previous > > > > patches adding support for __memcmpeq. > > > > > > > > > > This doesn't look right. If __memcmpeq is a true alias of memcmp, you > > > should only have simple_memcmpeq and __memcmpeq. > > > > Figured. Any idea what the issue might be? > > Where is your branch? I can take a look. Made a new branch on your gitlab here: https://gitlab.com/x86-glibc/glibc/-/tree/users/goldsteinn/memcmpeq-abi > > -- > H.J.