From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by sourceware.org (Postfix) with ESMTPS id ACF873857341 for ; Tue, 19 Apr 2022 22:56:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ACF873857341 Received: by mail-yb1-xb36.google.com with SMTP id h8so33710570ybj.11 for ; Tue, 19 Apr 2022 15:56:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=iEH1xsBfWLj94/qkAHD6uFrRThlgQ0rjHuEJC5y46xc=; b=JZZz7r2lS6Ia58gfK1bONp8KtYQevVX2901XXLfZbd60hKGd7nqju2JJLQos9Q2HLZ vX7QQSocHPEFltqhjWBZLDtsT/ecl2dU+rfBGB732eiPtGcrWlEAPH5xnqUz8yt7Ag3Z WyEmr1fwYKtsF7CxK0pP9EBjfXcsYRrsK41sO6pwR0Za2l1TZvK15V7EMdRxHjVNURVG wbn8m8rHkdEDdUw7UKMswHnrTvbBN69SK6b2BqG1+bOgwoORUtuc79f6M3XA4twi++VO lJLU4cOyFSdI7kkiZED9+rhZKoifN2gdyBemzGg7deByZQw4vgAPhr2NOvKsTnNVaUEz 5Qlw== X-Gm-Message-State: AOAM532vfIrvKfMcdwb//BoDdNvWUKUimf1vJrlL6jMfedMrdhkyBQcY HtbBqvej7iHV3fxaObv/XIRtusYocUhJfmj9KrGE6qlm X-Google-Smtp-Source: ABdhPJyHwUE4gyFBH57vtjh5jEvEvhJA9TgexEcxeIorPkrbjkVSzvf6jYWfT0kDpPpXbQ//2FjCOAtwOXOL8mrEI5I= X-Received: by 2002:a25:35d5:0:b0:632:c30d:cc0f with SMTP id c204-20020a2535d5000000b00632c30dcc0fmr17950634yba.43.1650408983653; Tue, 19 Apr 2022 15:56:23 -0700 (PDT) MIME-Version: 1.0 References: <20220415055132.1257272-1-goldstein.w.n@gmail.com> <20220415172801.1525674-1-goldstein.w.n@gmail.com> In-Reply-To: From: Noah Goldstein Date: Tue, 19 Apr 2022 17:56:13 -0500 Message-ID: Subject: Re: [PATCH v3 1/3] x86: Optimize memcmp SSE2 in memcmp.S To: Joseph Myers Cc: "H.J. Lu" , GNU C Library Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2022 22:56:26 -0000 On Tue, Apr 19, 2022 at 3:53 PM Noah Goldstein wr= ote: > > On Tue, Apr 19, 2022 at 3:30 PM Joseph Myers wr= ote: > > > > A recent commit, probably this one, broke the build for x86_64-linux-gn= u > > --disable-multi-arch. > > > > /scratch/jmyers/glibc-bot/install/compilers/x86_64-linux-gnu/lib/gcc/x8= 6_64-glibc-linux-gnu/11.2.1/../../../../x86_64-glibc-linux-gnu/bin/ld: /scr= atch/jmyers/glibc-bot/build/glibcs/x86_64-linux-gnu-minimal/glibc/libc_pic.= os: in function `internal_fnwmatch': > > /scratch/jmyers/glibc-bot/src/glibc/posix/fnmatch_loop.c:513: undefined= reference to `__wmemcmp' > > /scratch/jmyers/glibc-bot/install/compilers/x86_64-linux-gnu/lib/gcc/x8= 6_64-glibc-linux-gnu/11.2.1/../../../../x86_64-glibc-linux-gnu/bin/ld: /scr= atch/jmyers/glibc-bot/src/glibc/posix/fnmatch_loop.c:536: undefined referen= ce to `__wmemcmp' > > /scratch/jmyers/glibc-bot/install/compilers/x86_64-linux-gnu/lib/gcc/x8= 6_64-glibc-linux-gnu/11.2.1/../../../../x86_64-glibc-linux-gnu/bin/ld: /scr= atch/jmyers/glibc-bot/src/glibc/posix/fnmatch_loop.c:704: undefined referen= ce to `__wmemcmp' > > > > https://sourceware.org/pipermail/libc-testresults/2022q2/009576.html > > Reproduced issue, think have fix. Testing it now. Posted a patch. > > > > -- > > Joseph S. Myers > > joseph@codesourcery.com