From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x31.google.com (mail-oa1-x31.google.com [IPv6:2001:4860:4864:20::31]) by sourceware.org (Postfix) with ESMTPS id BEED13858D1E for ; Thu, 28 Mar 2024 19:28:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BEED13858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BEED13858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::31 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711654134; cv=none; b=vOrTMv1eVXG6xka8wS9twMKV1FkldHyjT4aDtanPmCi6I6ecQxiMJjeMZbYli7oPQQ9AmlrsVjgPzdzJE5X4c04SJw+i5sY+cdKxCK7zTyfFwJnr81npv6QUJzVSb0SaShUmumQTnZB2PZsOhnuVcHC4k1NEqbEMay79Z5CCJBg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711654134; c=relaxed/simple; bh=CeqG5HPwL1gVfynWpQkYf9ECBP9J/w7JlRDRQ0+05Ao=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=XGKNC288fBIwRBhSECHKC8rV+WnYVZ9WLZvLCqr+a9zW46s4XeTwTP36JppCAh/1lhdTeoXULYhDHU8TyjmVdkCpacsMHwNqi7rI5e2zwhLtvSXFpxOTnUmRk7GOgL+epkpbe3BTc1Be91zisNNRJ3q5u+KCfyd3fkOG+uFdORY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-22a639aedb6so681645fac.3 for ; Thu, 28 Mar 2024 12:28:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711654132; x=1712258932; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=moW13hjtoUzqTb3pdksWK10cd+vDL7tTtW5iT6z7Y1c=; b=ThjEtx7X30ARf1IBMVkCZduBOYtPrB0AlC8713AjTkLLrNbz73iUI70dLUL5T3iAYM 8OS8pR6xhsZ6BQHFnm2RG6oY4ADvO3+WinFLlOOVI1b1O00nOsiok8dCAVcvmaj5yVRd RaaDoceIy7IVjb5H7G2483vN0M2GIV4OZtVthJr2EGhftkE71ECObUfS0xnOpG6XQQZL NI9vxnDr3q06xyPQrQ7rengo76UCbwvx/flyYg9CkzOHFUDOJkojGvnGV+GIk6coaODt RB3NHzc9JQAUsWrDXDEsr6VGCsMONPCm/z5qWp+KwAesvD+3wheJxkvSYDkVltXSgb1k eZlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711654132; x=1712258932; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=moW13hjtoUzqTb3pdksWK10cd+vDL7tTtW5iT6z7Y1c=; b=soTIkwcWUBYN+BLjVAPQJBkoC5B2aZzmhS41H/FJkUSVY0GZbhyFlnsJXDomH76NPx vcm3KuUXFMAIjovbZ3lXuZxIHBMvvRpeYK9vw8WnQQpOxuchnpfWWv92kt4jEvRiearJ DeTRx7SnvDTWNOeNoaC+3XRtbzaA3Da9h8VOWVq57j7dPGnmmwTECk/wnX81fUnKuAzw V2H52i+1nm2EGsY0msSS/G3kP3Dh1J2lUjTAJ57WN8Hw0FZD8AOC3wGmBNxwzn3nyF/y vuqHvZ1L8LLRefL1nW8Z7V8YePwVD9Yb2JN8kfNb2kQnY9TdcoucZVOj4YmOSUlqthgs 6UtA== X-Gm-Message-State: AOJu0YxCrQUmZXuyMdrz+5BkuC8vfWJpV3BWkSwNKaOrr3tRVxaVuXyM O9RkAUQG7oR/wpIvQ4+vJM+gw26IRF7wGRUdbXIn63ltaWVaUuKNd7fpYFlM6ScCWSSToHcXhib zNKPcD1G2i2OCWmJUJNnDrxnn6FHxpx24 X-Google-Smtp-Source: AGHT+IEn7l4Q1prdoPGh6MwJXK2j/sq1zN3dcIjtRgdDPXnQNHAjDUngVbeYSi7uBNvy3MlL2iiNWIeb+LeYFl7KRow= X-Received: by 2002:a05:6870:440e:b0:221:c7bc:99a3 with SMTP id u14-20020a056870440e00b00221c7bc99a3mr183788oah.5.1711654131932; Thu, 28 Mar 2024 12:28:51 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Noah Goldstein Date: Thu, 28 Mar 2024 14:28:41 -0500 Message-ID: Subject: Re: [PATCH] Benchtests: Improve large memcpy/memset benchmarks To: Wilco Dijkstra Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Mar 27, 2024 at 12:02=E2=80=AFPM Wilco Dijkstra wrote: > > Hi Noah, > > > > @@ -33,7 +31,7 @@ static void > > > do_one_test (json_ctx_t *json_ctx, impl_t *impl, char *dst, char *sr= c, > > > size_t len) > > > { > > > - size_t i, iters =3D 16; > > > + size_t i, iters =3D (MIN_PAGE_SIZE * 8) / len; > > maybe MAX(16, (MIN_PAGE_SIZE * )/ len). Likewise above. > > I'm not sure how that helps - the issue was that 16 iterations was not on= ly > too small for smaller sizes but also too large for large sizes. This uses= 8 > iterations for the largest sizes (which takes ~7 seconds on an older mach= ine). I see, didn't realize 16 was too high. Although do think we should ensure at least 1 iter. > > > Also, can you include the iter count in the output? > > The time it prints is already divided by iterations, so it's not directly= usable. > > A better option for these benchmarks would be to print the bandwidth. iter count allows us to better estimate the variance. > > Cheers, > Wilco