From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <goldstein.w.n@gmail.com>
Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com
 [IPv6:2001:4860:4864:20::2c])
 by sourceware.org (Postfix) with ESMTPS id 7719E3856DCA
 for <libc-alpha@sourceware.org>; Wed, 13 Jul 2022 18:53:18 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7719E3856DCA
Received: by mail-oa1-x2c.google.com with SMTP id
 586e51a60fabf-10bffc214ffso15189691fac.1
 for <libc-alpha@sourceware.org>; Wed, 13 Jul 2022 11:53:18 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=o2Hw5HIeoDRRpghK8b1AsSg+WOldMPbUZsqgDEBRQXg=;
 b=FOzoG3q4nYKDrU1G3jK9r2HCXFBmII7Wyn1LllRsM4g7RqGw/UuVNeKmsMCqA/jDod
 XVwVo7FerN+O3L7k+O06UgJrNG3vJdJofaPFMLFLyfLnHNZzXOcLmkgudE5q+9V1CNv2
 c2+LSxW219gudLlYqA121faLPtJONKzzh38pC6xsYFlCyC8iLB+iwRZD5VpVeixV/+Hj
 KmCbp8rQY9NTsZA/9uIC2MigI7IN+RPdZrX3b2PpyfGU+MiAEsw9+qXKaJREuNhYLkGc
 2RKwaIcURREQYpqEDDY3AYjyMvx+ItFiGcZBHSMN0gwEPS7d38T8drgbekbRs53jXOj0
 C4cA==
X-Gm-Message-State: AJIora/DYy9WeyVuGUv++2JDjS4ia7oDzGmForDH/oQjT8pYoEVsstXB
 bzrt7D9QW37AtVVXYlwpQo2mE/7tP+P5Q9UHOT4=
X-Google-Smtp-Source: AGRyM1vriMkEou3K+mqvzL9MEJsTxJg51wR74H8PHLe7WgJXbAXEaQxq0rBZ1jzLkCT+KoFooc8iGAfqAZGIiMNUL3E=
X-Received: by 2002:a05:6870:41ca:b0:101:d588:6241 with SMTP id
 z10-20020a05687041ca00b00101d5886241mr5290265oac.175.1657738397863; Wed, 13
 Jul 2022 11:53:17 -0700 (PDT)
MIME-Version: 1.0
References: <20220713173657.516725-1-adhemerval.zanella@linaro.org>
 <20220713173657.516725-6-adhemerval.zanella@linaro.org>
 <CAFUsyf+wtuP-j7o2Zr0+tdABBY99fwYN0b9TehU0aHYiH55-XA@mail.gmail.com>
 <c9dd98ad-a4ef-a9c3-2f0e-cb35d631ef72@linaro.org>
 <CAFUsyfJuT6DqS6sNX96-VrnvUxyx8z7S8mvgLMvxdxwCW873nw@mail.gmail.com>
 <CAFUsyf+jvtc0UFOkUTspc460_z0ABbax1jifoEZ993WGuOwqfQ@mail.gmail.com>
 <bcfe6ae0-d3b9-530c-225e-6383c78027c6@linaro.org>
In-Reply-To: <bcfe6ae0-d3b9-530c-225e-6383c78027c6@linaro.org>
From: Noah Goldstein <goldstein.w.n@gmail.com>
Date: Wed, 13 Jul 2022 11:53:07 -0700
Message-ID: <CAFUsyfLZ8jCNWGFEHJww8P5xS==BLvmySaRh8bTmUj3NDNAu0A@mail.gmail.com>
Subject: Re: [PATCH v9 5/9] x86: Add SSE2 optimized chacha20
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Cc: GNU C Library <libc-alpha@sourceware.org>,
 Florian Weimer <fweimer@redhat.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jul 2022 18:53:19 -0000

On Wed, Jul 13, 2022 at 11:29 AM Adhemerval Zanella Netto
<adhemerval.zanella@linaro.org> wrote:
>
>
>
> On 13/07/22 15:27, Noah Goldstein wrote:
> >>>>> +
> >>>>
> >>>> If you have time make the ifunc changes to avx2 can you add:
> >>>>
> >>>> #include <isa-level.h>
> >>>> #if MINIMUM_X86_ISA_LEVEL <= 1
> >>>> <contentions of file>
> >>>> #endif
> >>>>
> >>>> as a build guard?
> >>>
> >>> Alright, I will add it.
> >
> > Err it should be
> > #if MINIMUM_X86_ISA_LEVEL <= 2
> >
> > sorry.
>
> I think it makes more sense to add the #if MINIMUM_X86_ISA_LEVEL <= 2 check
> on the AVX2 patch, since this patch isolated is required for all ISA levels.

Agreed. Good point.